Merge branch 'eui-v88.4.x' of github.com:cee-chen/kibana into eui-v88…

….4.x

api_docs/data_view_editor.devdocs.json

@@ -320,4 +320,4 @@
     "misc": [],
     "objects": []
   }
-}
+}

api_docs/kbn_deeplinks_ml.devdocs.json

@@ -45,7 +45,7 @@
         "label": "DeepLinkId",
         "description": [],
         "signature": [
-          "\"ml\" | \"ml:nodes\" | \"ml:notifications\" | \"ml:overview\" | \"ml:settings\" | \"ml:dataVisualizer\" | \"ml:anomalyDetection\" | \"ml:anomalyExplorer\" | \"ml:singleMetricViewer\" | \"ml:dataComparison\" | \"ml:dataFrameAnalytics\" | \"ml:resultExplorer\" | \"ml:analyticsMap\" | \"ml:aiOps\" | \"ml:logRateAnalysis\" | \"ml:logPatternAnalysis\" | \"ml:changePointDetections\" | \"ml:modelManagement\" | \"ml:nodesOverview\" | \"ml:memoryUsage\" | \"ml:fileUpload\" | \"ml:indexDataVisualizer\" | \"ml:calendarSettings\" | \"ml:filterListsSettings\""
+          "\"ml\" | \"ml:nodes\" | \"ml:notifications\" | \"ml:overview\" | \"ml:settings\" | \"ml:dataVisualizer\" | \"ml:anomalyDetection\" | \"ml:anomalyExplorer\" | \"ml:singleMetricViewer\" | \"ml:dataDrift\" | \"ml:dataFrameAnalytics\" | \"ml:resultExplorer\" | \"ml:analyticsMap\" | \"ml:aiOps\" | \"ml:logRateAnalysis\" | \"ml:logPatternAnalysis\" | \"ml:changePointDetections\" | \"ml:modelManagement\" | \"ml:nodesOverview\" | \"ml:memoryUsage\" | \"ml:fileUpload\" | \"ml:indexDataVisualizer\" | \"ml:calendarSettings\" | \"ml:filterListsSettings\""
         ],
         "path": "packages/deeplinks/ml/deep_links.ts",
         "deprecated": false,
@@ -60,7 +60,7 @@
         "label": "LinkId",
         "description": [],
         "signature": [
-          "\"nodes\" | \"notifications\" | \"overview\" | \"settings\" | \"dataVisualizer\" | \"anomalyDetection\" | \"anomalyExplorer\" | \"singleMetricViewer\" | \"dataComparison\" | \"dataFrameAnalytics\" | \"resultExplorer\" | \"analyticsMap\" | \"aiOps\" | \"logRateAnalysis\" | \"logPatternAnalysis\" | \"changePointDetections\" | \"modelManagement\" | \"nodesOverview\" | \"memoryUsage\" | \"fileUpload\" | \"indexDataVisualizer\" | \"calendarSettings\" | \"filterListsSettings\""
+          "\"nodes\" | \"notifications\" | \"overview\" | \"settings\" | \"dataVisualizer\" | \"anomalyDetection\" | \"anomalyExplorer\" | \"singleMetricViewer\" | \"dataDrift\" | \"dataFrameAnalytics\" | \"resultExplorer\" | \"analyticsMap\" | \"aiOps\" | \"logRateAnalysis\" | \"logPatternAnalysis\" | \"changePointDetections\" | \"modelManagement\" | \"nodesOverview\" | \"memoryUsage\" | \"fileUpload\" | \"indexDataVisualizer\" | \"calendarSettings\" | \"filterListsSettings\""
         ],
         "path": "packages/deeplinks/ml/deep_links.ts",
         "deprecated": false,
@@ -70,4 +70,4 @@
     ],
     "objects": []
   }
-}
+}

package.json

@@ -938,7 +938,7 @@
     "maplibre-gl": "3.1.0",
     "markdown-it": "^12.3.2",
     "md5": "^2.1.0",
-    "mdast-util-to-hast": "10.0.1",
+    "mdast-util-to-hast": "10.2.0",
     "memoize-one": "^6.0.0",
     "mime": "^2.4.4",
     "mime-types": "^2.1.27",
@@ -1042,7 +1042,7 @@
     "type-detect": "^4.0.8",
     "typescript-fsa": "^3.0.0",
     "typescript-fsa-reducers": "^1.2.2",
-    "unified": "^9.2.1",
+    "unified": "9.2.2",
     "use-resize-observer": "^9.1.0",
     "usng.js": "^0.4.5",
     "utility-types": "^3.10.0",

packages/deeplinks/ml/deep_links.ts

@@ -15,7 +15,7 @@ export type LinkId =
   | 'anomalyDetection'
   | 'anomalyExplorer'
   | 'singleMetricViewer'
-  | 'dataComparison'
+  | 'dataDrift'
   | 'dataFrameAnalytics'
   | 'resultExplorer'
   | 'analyticsMap'

packages/default-nav/ml/default_navigation.ts

@@ -114,9 +114,9 @@ export const defaultNavigation: MlNodeDefinition = {
         },
         {
           title: i18n.translate('defaultNavigation.ml.dataComparison', {
-            defaultMessage: 'Data comparison',
+            defaultMessage: 'Data drift',
           }),
-          link: 'ml:dataComparison',
+          link: 'ml:dataDrift',
         },
       ],
     },

packages/kbn-unified-data-table/src/components/data_table.test.tsx

@@ -432,4 +432,37 @@ describe('UnifiedDataTable', () => {
       expect(tourStep).toEqual('test-expand');
     });
   });
+
+  describe('gridStyleOverride', () => {
+    it('should render the grid with the default style if no gridStyleOverride is provided', async () => {
+      const component = await getComponent({
+        ...getProps(),
+      });
+
+      const grid = findTestSubject(component, 'docTable');
+
+      expect(grid.hasClass('euiDataGrid--bordersHorizontal')).toBeTruthy();
+      expect(grid.hasClass('euiDataGrid--fontSizeSmall')).toBeTruthy();
+      expect(grid.hasClass('euiDataGrid--paddingLarge')).toBeTruthy();
+      expect(grid.hasClass('euiDataGrid--rowHoverHighlight')).toBeTruthy();
+      expect(grid.hasClass('euiDataGrid--headerUnderline')).toBeTruthy();
+      expect(grid.hasClass('euiDataGrid--stripes')).toBeTruthy();
+    });
+    it('should render the grid with style override if gridStyleOverride is provided', async () => {
+      const component = await getComponent({
+        ...getProps(),
+        gridStyleOverride: {
+          stripes: false,
+          rowHover: 'none',
+          border: 'none',
+        },
+      });
+
+      const grid = findTestSubject(component, 'docTable');
+
+      expect(grid.hasClass('euiDataGrid--stripes')).toBeFalsy();
+      expect(grid.hasClass('euiDataGrid--rowHoverHighlight')).toBeFalsy();
+      expect(grid.hasClass('euiDataGrid--bordersNone')).toBeTruthy();
+    });
+  });
 });

packages/kbn-unified-data-table/src/components/data_table.tsx

@@ -27,6 +27,7 @@ import {
   EuiDataGridControlColumn,
   EuiDataGridCustomBodyProps,
   EuiDataGridCellValueElementProps,
+  EuiDataGridStyle,
 } from '@elastic/eui';
 import type { DataView } from '@kbn/data-views-plugin/public';
 import {
@@ -282,6 +283,10 @@ export interface UnifiedDataTableProps {
    * Optional key/value pairs to set guided onboarding steps ids for a data table components included to guided tour.
    */
   componentsTourSteps?: Record<string, string>;
+  /**
+   * Optional gridStyle override.
+   */
+  gridStyleOverride?: EuiDataGridStyle;
 }
 
 export const EuiDataGridMemoized = React.memo(EuiDataGrid);
@@ -335,6 +340,7 @@ export const UnifiedDataTable = ({
   externalCustomRenderers,
   consumer = 'discover',
   componentsTourSteps,
+  gridStyleOverride,
 }: UnifiedDataTableProps) => {
   const { fieldFormats, toastNotifications, dataViewFieldEditor, uiSettings, storage, data } =
     services;
@@ -789,7 +795,7 @@ export const UnifiedDataTable = ({
             toolbarVisibility={toolbarVisibility}
             rowHeightsOptions={rowHeightsOptions}
             inMemory={inMemory}
-            gridStyle={GRID_STYLE}
+            gridStyle={gridStyleOverride ?? GRID_STYLE}
             renderCustomGridBody={renderCustomGridBody}
             trailingControlColumns={trailingControlColumns}
           />

packages/shared-ux/chrome/navigation/mocks/src/navlinks.ts

@@ -62,7 +62,7 @@ const allNavLinks: AppDeepLinkId[] = [
   'ml:fileUpload',
   'ml:filterListsSettings',
   'ml:indexDataVisualizer',
-  'ml:dataComparison',
+  'ml:dataDrift',
   'ml:logPatternAnalysis',
   'ml:logRateAnalysis',
   'ml:memoryUsage',

src/plugins/data_view_editor/public/data_view_editor_service.ts

@@ -37,12 +37,24 @@ export const matchedIndiciesDefault = {
   visibleIndices: [],
 };
 
+/**
+ * ConstructorArgs for DataViewEditorService
+ */
 export interface DataViewEditorServiceConstructorArgs {
+  /**
+   * Dependencies for the DataViewEditorService
+   */
   services: {
     http: HttpSetup;
     dataViews: DataViewsServicePublic;
   };
+  /**
+   * Whether service requires requireTimestampField
+   */
   requireTimestampField?: boolean;
+  /**
+   * Initial type, indexPattern, and name to populate service
+   */
   initialValues: {
     name?: string;
     type?: INDEX_PATTERN_TYPE;

src/plugins/data_view_editor/public/data_view_editor_service_lazy.ts

@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export { DataViewEditorService } from './data_view_editor_service';

src/plugins/data_view_editor/public/index.ts

@@ -20,7 +20,11 @@
 
 import { DataViewEditorPlugin } from './plugin';
 
-export type { PluginStart as DataViewEditorStart, DataViewEditorProps } from './types';
+export type {
+  PluginStart as DataViewEditorStart,
+  DataViewEditorProps,
+  DataViewEditorService,
+} from './types';
 
 export function plugin() {
   return new DataViewEditorPlugin();

src/plugins/data_view_editor/public/mocks.ts

@@ -23,6 +23,7 @@ const createStartContract = (): Start => {
     userPermissions: {
       editDataView: jest.fn(),
     },
+    dataViewEditorServiceFactory: jest.fn(),
   };
 };
 

src/plugins/data_view_editor/public/plugin.tsx

@@ -63,6 +63,14 @@ export class DataViewEditorPlugin
       userPermissions: {
         editDataView: () => dataViews.getCanSaveSync(),
       },
+      /**
+       * Helper method to generate a new data view editor service.
+       * @returns DataViewEditorService
+       */
+      dataViewEditorServiceFactory: async () => {
+        const module = await import('./data_view_editor_service_lazy');
+        return module;
+      },
     };
   }
 

src/plugins/data_view_editor/public/types.ts

@@ -24,6 +24,7 @@ import type {
   INDEX_PATTERN_TYPE,
   MatchedItem,
 } from '@kbn/data-views-plugin/public';
+import type { DataViewEditorService } from './data_view_editor_service';
 import { DataPublicPluginStart, IndexPatternAggRestrictions } from './shared_imports';
 
 export interface DataViewEditorContext {
@@ -74,12 +75,20 @@ export interface DataViewEditorProps {
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface PluginSetup {}
 
+export type { DataViewEditorService };
 export interface PluginStart {
   openEditor(options: DataViewEditorProps): () => void;
   IndexPatternEditorComponent: FC<DataViewEditorProps>;
   userPermissions: {
     editDataView: () => boolean;
   };
+  /**
+   * Helper method to generate a new data view editor service.
+   * @param requireTimestampField - whether service requires requireTimestampField
+   * @param initialValues - initial type, indexPattern, and name to populate service
+   * @returns DataViewEditorService
+   */
+  dataViewEditorServiceFactory: () => Promise<typeof import('./data_view_editor_service_lazy')>;
 }
 
 // eslint-disable-next-line @typescript-eslint/no-empty-interface

src/plugins/saved_objects_finder/public/finder/saved_object_finder.tsx

@@ -75,6 +75,7 @@ interface BaseSavedObjectFinder {
   savedObjectMetaData: Array<SavedObjectMetaData<FinderAttributes>>;
   showFilter?: boolean;
   leftChildren?: ReactElement | ReactElement[];
+  children?: ReactElement | ReactElement[];
   helpText?: string;
 }
 

test/functional/apps/dashboard/group3/copy_panel_to.ts

@@ -14,7 +14,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const dashboardPanelActions = getService('dashboardPanelActions');
   const testSubjects = getService('testSubjects');
   const kibanaServer = getService('kibanaServer');
-  const find = getService('find');
 
   const PageObjects = getPageObjects([
     'header',

x-pack/packages/ml/aiops_components/src/document_count_chart/document_count_chart.tsx

@@ -104,6 +104,8 @@ export interface DocumentCountChartProps {
   brushSelectionUpdateHandler?: BrushSelectionUpdateHandler;
   /** Optional width */
   width?: number;
+  /** Optional chart height */
+  height?: number;
   /** Data chart points */
   chartPoints: LogRateHistogramItem[];
   /** Data chart points split */
@@ -130,6 +132,8 @@ export interface DocumentCountChartProps {
   deviationBrush?: BrushSettings;
   /** Optional settings override for the 'baseline' brush */
   baselineBrush?: BrushSettings;
+  /** Optional data-test-subject */
+  dataTestSubj?: string;
 }
 
 const SPEC_ID = 'document_count';
@@ -174,9 +178,11 @@ function getBaselineBadgeOverflow(
  */
 export const DocumentCountChart: FC<DocumentCountChartProps> = (props) => {
   const {
+    dataTestSubj,
     dependencies,
     brushSelectionUpdateHandler,
     width,
+    height,
     chartPoints,
     chartPointsSplit,
     timeRangeEarliest,
@@ -417,7 +423,7 @@ export const DocumentCountChart: FC<DocumentCountChartProps> = (props) => {
   return (
     <>
       {isBrushVisible && (
-        <div className="aiopsHistogramBrushes" data-test-subj="aiopsHistogramBrushes">
+        <div className="aiopsHistogramBrushes" data-test-subj={'aiopsHistogramBrushes'}>
           <div css={{ height: BADGE_HEIGHT }}>
             <BrushBadge
               label={
@@ -461,11 +467,14 @@ export const DocumentCountChart: FC<DocumentCountChartProps> = (props) => {
           </div>
         </div>
       )}
-      <div css={{ width: width ?? '100%' }} data-test-subj="aiopsDocumentCountChart">
+      <div
+        css={{ width: width ?? '100%' }}
+        data-test-subj={dataTestSubj ?? 'aiopsDocumentCountChart'}
+      >
         <Chart
           size={{
             width: '100%',
-            height: 120,
+            height: height ?? 120,
           }}
         >
           <Settings