Revert "Revert "[ci] skip building ts refs when not necessary (#95739)…

…" (#95746)" (#95750) Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
elastic · Apr 19, 2021 · b7a9b84 · b7a9b84
1 parent 6712bc0
commit b7a9b84
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/.ci/Jenkinsfile_baseline_capture b/.ci/Jenkinsfile_baseline_capture
@@ -23,6 +23,7 @@ kibanaPipeline(timeoutMinutes: 210) {
             ) {
               withGcpServiceAccount.fromVaultSecret('secret/kibana-issues/dev/ci-artifacts-key', 'value') {
                 withEnv([
+                  'BUILD_TS_REFS_DISABLE=false', // disabled in root config so we need to override that here
                   'BUILD_TS_REFS_CACHE_ENABLE=true',
                   'BUILD_TS_REFS_CACHE_CAPTURE=true',
                   'DISABLE_BOOTSTRAP_VALIDATION=true',

diff --git a/src/dev/ci_setup/setup.sh b/src/dev/ci_setup/setup.sh
@@ -21,10 +21,6 @@ cp "src/dev/ci_setup/.bazelrc-ci" "$HOME/.bazelrc";
 echo "# Appended by src/dev/ci_setup/setup.sh" >> "$HOME/.bazelrc"
 echo "build --remote_header=x-buildbuddy-api-key=$KIBANA_BUILDBUDDY_CI_API_KEY" >> "$HOME/.bazelrc"
 
-if [[ "$BUILD_TS_REFS_CACHE_ENABLE" != "true" ]]; then
-  export BUILD_TS_REFS_CACHE_ENABLE=false
-fi
-
 ###
 ### install dependencies
 ###

diff --git a/src/dev/typescript/build_ts_refs_cli.ts b/src/dev/typescript/build_ts_refs_cli.ts
@@ -21,7 +21,7 @@ const CACHE_WORKING_DIR = Path.resolve(REPO_ROOT, 'data/ts_refs_output_cache');
 const TS_ERROR_REF = /\sTS\d{1,6}:\s/;
 
 const isTypeFailure = (error: any) =>
-  error.exitCode === 1 &&
+  error.exitCode > 0 &&
   error.stderr === '' &&
   typeof error.stdout === 'string' &&
   TS_ERROR_REF.test(error.stdout);

diff --git a/test/scripts/checks/type_check.sh b/test/scripts/checks/type_check.sh
@@ -2,5 +2,13 @@
 
 source src/dev/ci_setup/setup_env.sh
 
+checks-reporter-with-killswitch "Build TS Refs" \
+  node scripts/build_ts_refs \
+    --ignore-type-failures \
+    --clean \
+    --no-cache \
+    --force \
+    --debug
+
 checks-reporter-with-killswitch "Check Types" \
   node scripts/type_check
diff --git a/vars/workers.groovy b/vars/workers.groovy
@@ -101,6 +101,7 @@ def base(Map params, Closure closure) {
       "TEST_BROWSER_HEADLESS=1",
       "GIT_BRANCH=${checkoutInfo.branch}",
       "TMPDIR=${env.WORKSPACE}/tmp", // For Chrome and anything else that respects it
+      "BUILD_TS_REFS_DISABLE=true", // no need to build ts refs in bootstrap
     ]) {
       withCredentials([
         string(credentialsId: 'vault-addr', variable: 'VAULT_ADDR'),