Skip to content

Commit

Permalink
[Maps] Show create filter button for top-term tooltip property (#62461)…
Browse files Browse the repository at this point in the history
… (#62987)

* [Maps] Show create filter button top-term tooltip property

* add missing imports

* update import for NP migration

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
nreese and elasticmachine authored Apr 8, 2020
1 parent ed10553 commit b545619
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/maps/public/layers/fields/es_agg_field.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export class ESAggField implements IESAggField {
async createTooltipProperty(value: string | undefined): Promise<ITooltipProperty> {
const indexPattern = await this._source.getIndexPattern();
const tooltipProperty = new TooltipProperty(this.getName(), await this.getLabel(), value);
return new ESAggTooltipProperty(tooltipProperty, indexPattern, this);
return new ESAggTooltipProperty(tooltipProperty, indexPattern, this, this.getAggType());
}

getValueAggDsl(indexPattern: IndexPattern): unknown | null {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,25 @@
* you may not use this file except in compliance with the Elastic License.
*/
import { ESTooltipProperty } from './es_tooltip_property';
import { AGG_TYPE } from '../../../common/constants';
import { ITooltipProperty } from './tooltip_property';
import { IField } from '../fields/field';
import { IndexPattern } from '../../../../../../src/plugins/data/public';

export class ESAggTooltipProperty extends ESTooltipProperty {
private readonly _aggType: AGG_TYPE;

constructor(
tooltipProperty: ITooltipProperty,
indexPattern: IndexPattern,
field: IField,
aggType: AGG_TYPE
) {
super(tooltipProperty, indexPattern, field);
this._aggType = aggType;
}

isFilterable(): boolean {
return false;
return this._aggType === AGG_TYPE.TERMS;
}
}

0 comments on commit b545619

Please sign in to comment.