fixes

elastic · Mar 19, 2020 · b4da458 · b4da458
1 parent 3591126
commit b4da458
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/editor.js b/src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/editor.js
@@ -165,6 +165,12 @@ function VisualizeAppController(
 
   $scope.embeddableHandler = embeddableHandler;
 
+  const handleUiStateChange = () => {
+    stateContainer.transitions.updateUiState(visStateToEditorState().uiState);
+  };
+
+  $scope.vis.uiState.on('change', handleUiStateChange);
+
   $scope.topNavMenu = [
     ...(visualizeCapabilities.save
       ? [
@@ -576,6 +582,7 @@ function VisualizeAppController(
       savedVis.destroy();
       subscriptions.unsubscribe();
       $scope.eventEmitter.off('apply', _applyVis);
+      $scope.vis.uiState.off('change', handleUiStateChange);
 
       unsubscribePersisted();
       unsubscribeStateUpdates();

diff --git a/src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/lib/visualize_app_state.ts b/src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/lib/visualize_app_state.ts
@@ -82,6 +82,7 @@ export function useVisualizeAppState({ stateDefaults, kbnUrlStateStorage }: Argu
         linked: false,
       }),
       updateVisState: state => newVisState => ({ ...state, vis: toObject(newVisState) }),
+      updateUiState: state => newUiState => ({ ...state, uiState: newUiState }),
       updateFromSavedQuery: state => savedQuery => ({
         ...state,
         savedQuery: savedQuery.id,

diff --git a/src/legacy/core_plugins/kibana/public/visualize/np_ready/types.d.ts b/src/legacy/core_plugins/kibana/public/visualize/np_ready/types.d.ts
@@ -56,6 +56,7 @@ export interface VisualizeAppStateTransitions {
     state: VisualizeAppState
   ) => ({ query, parentFilters }: { query?: Query; parentFilters?: Filter[] }) => VisualizeAppState;
   updateVisState: (state: VisualizeAppState) => (vis: PureVisState) => VisualizeAppState;
+  updateUiState: (state: VisualizeAppState) => (uiState: PersistedState) => VisualizeAppState;
   updateFromSavedQuery: (state: VisualizeAppState) => (savedQuery: SavedQuery) => VisualizeAppState;
 }
 

diff --git a/...acy/core_plugins/visualizations/public/np_ready/public/embeddable/visualize_embeddable.ts b/...acy/core_plugins/visualizations/public/np_ready/public/embeddable/visualize_embeddable.ts
@@ -162,6 +162,8 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
         });
         this.vis.uiState.on('change', this.uiStateChangeHandler);
       }
+    } else if (this.parent) {
+      this.vis.uiState.clearAllKeys();
     }
   }
-Original file line number
+Diff line change
@@ Expand Up @@
             });
             this.vis.uiState.on('change', this.uiStateChangeHandler);
           }
+        } else if (this.parent) {
+          this.vis.uiState.clearAllKeys();
         }
       }
@@ Expand Down @@