Skip to content

Commit

Permalink
[Console] Move out of quarantined (#52270)
Browse files Browse the repository at this point in the history
* WiP, lotta broken things, working through new editor.ts

* RowParser -> TS

* Utils to TS and regular module

* Finished first version of core & sense editor wrappers. Tokenizer provider test working. Still need to delete some files

* WiP - moved A LOT of code around and busy fixing sense-editor tests

* Fix sense editor test

* Clean up mocks

* Moved A LOT of code out of quarantined.
Still working on sense editor's integration test
Not running yet.

* WiP still finishing up manual testing

* Fix use of Ace Range and fix open documentation

* Move out of quarantined!

* Remove load remote editor state for now

* - fix use of token iterator
- remove ace ranges from sense editor spec and fix spec 🤦

* Address getSelectionRange document TODO
Clean up use of jquery
Remove use of `done` inside async tests (input_tokenization.test.js)
Capitalize elasticsearch
Introduce helper for converting to AceRange inside legacy core editor
Update typings
Clean up imports
Cleaner variable assignment

* Update src/legacy/core_plugins/console/public/np_ready/application/models/sense_editor/curl.ts

Co-Authored-By: Rory Hunter <[email protected]>

* Remove commented-out code
lib/utils.js -> lib/utils.ts
Rename engulfling range (sense_editor)

* Rename format request function

* utils.ts default export usage cleanup

* Update replace regex and add another utils test

* Remove legacy replace behaviour

* Fix typo in comment
  • Loading branch information
jloleysens authored Dec 10, 2019
1 parent f6c44df commit b4a2751
Show file tree
Hide file tree
Showing 160 changed files with 2,094 additions and 1,949 deletions.
18 changes: 5 additions & 13 deletions src/legacy/core_plugins/console/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import Boom from 'boom';
import { first } from 'rxjs/operators';
import { resolve, join, sep } from 'path';
import { resolve, join } from 'path';
import url from 'url';
import { has, isEmpty, head, pick } from 'lodash';

Expand Down Expand Up @@ -51,9 +51,7 @@ function filterHeaders(originalHeaders: any, headersToKeep: any) {

// eslint-disable-next-line
export default function(kibana: any) {
const modules = resolve(__dirname, 'public/webpackShims/');
const quarantinedSrc = resolve(__dirname, 'public/quarantined/src/');
const npSrc = resolve(__dirname, 'np_ready/public');
const npSrc = resolve(__dirname, 'public/np_ready');

let defaultVars: any;
return new kibana.Plugin({
Expand Down Expand Up @@ -180,16 +178,10 @@ export default function(kibana: any) {
},

uiExports: {
devTools: [`${npSrc}/legacy`],
styleSheetPaths: resolve(__dirname, 'public/quarantined/index.scss'),

devTools: [resolve(__dirname, 'public/legacy')],
styleSheetPaths: resolve(npSrc, 'application/styles/index.scss'),
injectDefaultVars: () => defaultVars,

noParse: [
join(modules, 'ace' + sep),
join(modules, 'moment_src/moment' + sep),
join(quarantinedSrc, 'sense_editor/mode/worker.js'),
],
noParse: [join(npSrc, 'application/models/legacy_core_editor/mode/worker/worker.js')],
},
} as any);
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit b4a2751

Please sign in to comment.