Skip to content

Commit

Permalink
fix(NA): tests and error flow on the bazel package task for plugin he…
Browse files Browse the repository at this point in the history
…lpers
  • Loading branch information
mistic committed Jun 14, 2023
1 parent 5e200bc commit b213cbb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,6 @@ it('builds a generated plugin into a viable archive', async () => {
expect(filterLogs(buildProc.all)).toMatchInlineSnapshot(`
" info deleting the build and target directories
info run bazel and build required artifacts for the optimizer
│ INFO: Invocation ID: 0a55204d-302f-409d-b104-18c73f7ec8ba
│ INFO: Analyzed 3 targets (0 packages loaded, 0 targets configured).
│ INFO: Found 3 targets...
│ INFO: Elapsed time: <time>, Critical Path: <time>
│ INFO: 1 process: 1 internal.
succ bazel run successfully and artifacts were created
info running @kbn/optimizer
│ succ browser bundle created at plugins/foo_test_plugin/build/kibana/fooTestPlugin/target/public
Expand Down
2 changes: 2 additions & 0 deletions packages/kbn-plugin-helpers/src/tasks/bazel_packages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@ export async function buildBazelPackages({ log, dist }: TaskContext) {
].concat(dist ? [`--define=dist=true`] : []),
{
logPrefix: ' │ ',
quiet: true
}
);

log.success('bazel run successfully and artifacts were created');
} catch (e) {
log.error(`bazel run failed: ${e}`);
process.exit(1);
}
}

0 comments on commit b213cbb

Please sign in to comment.