Kevin Qualters review: remove useMemo, use more named constants for r…

…eadability
elastic · Apr 9, 2020 · b0f29c1 · b0f29c1
1 parent ef59961
commit b0f29c1
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx b/x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx
@@ -120,9 +120,10 @@ export const ProcessEventDot = styled(
        *  18.75 : The smallest readable font size at which labels/descriptions can be read. Font size will not scale below this.
        *  12.5 : A 'slope' at which the font size will scale w.r.t. to zoom level otherwise
        */
-      const scaledTypeSize = useMemo(() => {
-        return magFactorX > 1 ? 18.75 + 12.5 * (magFactorX - 1) : 18.75;
-      }, [magFactorX]);
+      const minimumFontSize = 18.75;
+      const slopeOfFontScale = 12.5;
+      const fontSizeAdjustmentForScale = magFactorX > 1 ? slopeOfFontScale * (magFactorX - 1) : 0;
+      const scaledTypeSize =  minimumFontSize + fontSizeAdjustmentForScale;
 
       const markerBaseSize = 15;
       const markerSize = markerBaseSize;