a11y: don't pass id not necesserilly

elastic · Feb 22, 2020 · ad5834e · ad5834e
1 parent e5802f7
commit ad5834e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 46 deletions.
diff --git a/...dvanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap b/...dvanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap
diff --git a/src/plugins/advanced_settings/public/management_app/components/field/field.tsx b/src/plugins/advanced_settings/public/management_app/components/field/field.tsx
@@ -299,10 +299,14 @@ export class Field extends PureComponent<FieldProps> {
       defVal,
       ariaName,
     } = setting;
-    const a11yProps: { [key: string]: string } = {
-      ['aria-label']: ariaName,
-      ['aria-describedby']: id,
-    };
+    const a11yProps: { [key: string]: string } = unsavedChanges
+      ? {
+          ['aria-label']: ariaName,
+          ['aria-describedby']: id,
+        }
+      : {
+          ['aria-label']: ariaName,
+        };
     const currentValue = unsavedChanges
       ? unsavedChanges.value
       : getEditableValue(type, value, defVal);