[Profiling] Profiling data access plugin (#165198)

This is part 1 of a series of PRs to expose the flamegraph to be used by
other plugins.

**The problem**
Currently for plugin-A to show data from plugin-B, it needs to add
dependency on plugin-B. If plugin-B wants to show data from plugin-A, it
also needs to add plugin-A as a dependency, and here is where the
problem happens. In such scenario, we have a cyclic dependency problem.

**The solution**
To solve this problem a new plugin is created, `profiling-data-access`.
This plugin exposes services that consumer plugins can call in other to
have the data they need to show on their end. The `profiling` plugin is
also using this new plugin. For now, only the flamegraph service is
available, The idea is to slowly migrate the data fetching from
profiling to this new plugin in other to facilitate the integration
across plugins.

**Why some many files?**
As I said, only the flamegraph logic was moved to the new plugin, but it
has many files that it needs to properly build the response of the
service call. I moved all these files to the `common` folder inside the
new plugin and adjusted the imports in the profiling plugin.

<img width="1032" alt="Screenshot 2023-08-31 at 09 29 27"
src="https://github.com/elastic/kibana/assets/55978943/287bd28e-b834-45e0-8042-576d1fcff6cd">

---------

Co-authored-by: kibanamachine <[email protected]>

.github/CODEOWNERS

@@ -545,6 +545,7 @@ packages/kbn-plugin-helpers @elastic/kibana-operations
 examples/portable_dashboards_example @elastic/kibana-presentation
 examples/preboot_example @elastic/kibana-security @elastic/kibana-core
 src/plugins/presentation_util @elastic/kibana-presentation
+x-pack/plugins/profiling_data_access @elastic/profiling-ui
 x-pack/plugins/profiling @elastic/profiling-ui
 x-pack/packages/kbn-random-sampling @elastic/kibana-visualizations
 packages/kbn-react-field @elastic/kibana-data-discovery

docs/developer/plugin-list.asciidoc

@@ -697,6 +697,10 @@ Elastic.
 |Universal Profiling provides fleet-wide, whole-system, continuous profiling with zero instrumentation. Get a comprehensive understanding of what lines of code are consuming compute resources throughout your entire fleet by visualizing your data in Kibana using the flamegraph, stacktraces, and top functions views.
 
 
+|{kib-repo}blob/{branch}/x-pack/plugins/profiling_data_access[profilingDataAccess]
+|WARNING: Missing README.
+
+
 |{kib-repo}blob/{branch}/x-pack/plugins/remote_clusters/README.md[remoteClusters]
 |This plugin helps users manage their remote clusters, which enable cross-cluster search and cross-cluster replication.
 

package.json

@@ -556,6 +556,7 @@
     "@kbn/portable-dashboards-example": "link:examples/portable_dashboards_example",
     "@kbn/preboot-example-plugin": "link:examples/preboot_example",
     "@kbn/presentation-util-plugin": "link:src/plugins/presentation_util",
+    "@kbn/profiling-data-access-plugin": "link:x-pack/plugins/profiling_data_access",
     "@kbn/profiling-plugin": "link:x-pack/plugins/profiling",
     "@kbn/random-sampling": "link:x-pack/packages/kbn-random-sampling",
     "@kbn/react-field": "link:packages/kbn-react-field",

tsconfig.base.json

@@ -1084,6 +1084,8 @@
       "@kbn/preboot-example-plugin/*": ["examples/preboot_example/*"],
       "@kbn/presentation-util-plugin": ["src/plugins/presentation_util"],
       "@kbn/presentation-util-plugin/*": ["src/plugins/presentation_util/*"],
+      "@kbn/profiling-data-access-plugin": ["x-pack/plugins/profiling_data_access"],
+      "@kbn/profiling-data-access-plugin/*": ["x-pack/plugins/profiling_data_access/*"],
       "@kbn/profiling-plugin": ["x-pack/plugins/profiling"],
       "@kbn/profiling-plugin/*": ["x-pack/plugins/profiling/*"],
       "@kbn/random-sampling": ["x-pack/packages/kbn-random-sampling"],

x-pack/plugins/profiling/common/columnar_view_model.test.ts

@@ -7,12 +7,14 @@
 
 import { sum } from 'lodash';
 
-import { createCalleeTree } from './callee';
+import { createCalleeTree } from '@kbn/profiling-data-access-plugin/common/callee';
 import { createColumnarViewModel } from './columnar_view_model';
-import { createBaseFlameGraph, createFlameGraph } from './flamegraph';
-import { decodeStackTraceResponse } from './stack_traces';
-
-import { stackTraceFixtures } from './__fixtures__/stacktraces';
+import {
+  createBaseFlameGraph,
+  createFlameGraph,
+} from '@kbn/profiling-data-access-plugin/common/flamegraph';
+import { decodeStackTraceResponse } from '@kbn/profiling-data-access-plugin/common/stack_traces';
+import { stackTraceFixtures } from '@kbn/profiling-data-access-plugin/common/__fixtures__/stacktraces';
 
 describe('Columnar view model operations', () => {
   stackTraceFixtures.forEach(({ response, seconds, upsampledBy }) => {

x-pack/plugins/profiling/common/columnar_view_model.ts

@@ -6,8 +6,7 @@
  */
 
 import { ColumnarViewModel } from '@elastic/charts';
-
-import { ElasticFlameGraph } from './flamegraph';
+import { ElasticFlameGraph } from '@kbn/profiling-data-access-plugin/common/flamegraph';
 import { frameTypeToRGB, rgbToRGBA } from './frame_type_colors';
 
 function normalize(n: number, lower: number, upper: number): number {

x-pack/plugins/profiling/common/frame_type_colors.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { FrameType } from './profiling';
+import { FrameType } from '@kbn/profiling-data-access-plugin/common/profiling';
 
 /*
  * Helper to calculate the color of a given block to be drawn. The desirable outcomes of this are:

x-pack/plugins/profiling/common/functions.test.ts

@@ -6,11 +6,9 @@
  */
 
 import { sum } from 'lodash';
-
 import { createTopNFunctions } from './functions';
-import { decodeStackTraceResponse } from './stack_traces';
-
-import { stackTraceFixtures } from './__fixtures__/stacktraces';
+import { decodeStackTraceResponse } from '@kbn/profiling-data-access-plugin/common/stack_traces';
+import { stackTraceFixtures } from '@kbn/profiling-data-access-plugin/common/__fixtures__/stacktraces';
 
 describe('TopN function operations', () => {
   stackTraceFixtures.forEach(({ response, seconds, upsampledBy }) => {

x-pack/plugins/profiling/common/functions.ts

@@ -6,7 +6,10 @@
  */
 import * as t from 'io-ts';
 import { sumBy } from 'lodash';
-import { createFrameGroupID, FrameGroupID } from './frame_group';
+import {
+  createFrameGroupID,
+  FrameGroupID,
+} from '@kbn/profiling-data-access-plugin/common/frame_group';
 import {
   createStackFrameMetadata,
   emptyExecutable,
@@ -19,7 +22,7 @@ import {
   StackFrameMetadata,
   StackTrace,
   StackTraceID,
-} from './profiling';
+} from '@kbn/profiling-data-access-plugin/common/profiling';
 
 interface TopNFunctionAndFrameGroup {
   Frame: StackFrameMetadata;

x-pack/plugins/profiling/common/index.ts

@@ -41,18 +41,6 @@ export function timeRangeFromRequest(request: any): [number, number] {
   return [timeFrom, timeTo];
 }
 
-// Converts from a Map object to a Record object since Map objects are not
-// serializable to JSON by default
-export function fromMapToRecord<K extends string, V>(m: Map<K, V>): Record<string, V> {
-  const output: Record<string, V> = {};
-
-  for (const [key, value] of m) {
-    output[key] = value;
-  }
-
-  return output;
-}
-
 export const NOT_AVAILABLE_LABEL = i18n.translate('xpack.profiling.notAvailableLabel', {
   defaultMessage: 'N/A',
 });