[ML] Fixing overview page max anomaly score (#48110) (#48368)

* [ML] Fixing overview page max anomaly score * removing unnecessary copy of maxScore
elastic · Oct 16, 2019 · ac4482a · ac4482a
1 parent ba0db38
commit ac4482a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...plugins/ml/public/overview/components/anomaly_detection_panel/anomaly_detection_panel.tsx b/...plugins/ml/public/overview/components/anomaly_detection_panel/anomaly_detection_panel.tsx
@@ -98,13 +98,13 @@ export const AnomalyDetectionPanel: FC = () => {
           return ml.results.getMaxAnomalyScore(group.jobIds, twentyFourHoursAgo, latestTimestamp);
         });
 
-      const results = await Promise.all(promises.map(p => p.catch(() => undefined)));
+      const results = await Promise.all(promises);
       const tempGroups = { ...groupsObject };
       // Check results for each group's promise index and update state
       Object.keys(scores).forEach(groupId => {
         const resultsIndex = scores[groupId] && scores[groupId].index;
-        scores[groupId] = resultsIndex !== undefined && results[resultsIndex];
-        tempGroups[groupId].max_anomaly_score = resultsIndex !== undefined && results[resultsIndex];
+        const { maxScore } = resultsIndex !== undefined && results[resultsIndex];
+        tempGroups[groupId].max_anomaly_score = maxScore || undefined;
       });
 
       setGroups(tempGroups);

diff --git a/x-pack/legacy/plugins/ml/server/models/results_service/results_service.js b/x-pack/legacy/plugins/ml/server/models/results_service/results_service.js
@@ -264,7 +264,7 @@ export function resultsServiceProvider(callWithRequest) {
     const resp = await callWithRequest('search', query);
     const maxScore = _.get(resp, ['aggregations', 'max_score', 'value'], null);
 
-    return maxScore;
+    return { maxScore };
   }
 
   // Obtains the latest bucket result timestamp by job ID.