Update generated graph drawing and add map of allowed keys for condit…

…ional edges
elastic · Dec 2, 2024 · ab7c000 · ab7c000
1 parent f6c400e
commit ab7c000
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/x-pack/plugins/security_solution/docs/siem_migration/img/agent_graph.png b/x-pack/plugins/security_solution/docs/siem_migration/img/agent_graph.png
diff --git a/x-pack/plugins/security_solution/server/lib/siem_migrations/rules/task/agent/graph.ts b/x-pack/plugins/security_solution/server/lib/siem_migrations/rules/task/agent/graph.ts
@@ -36,7 +36,11 @@ export function getRuleMigrationAgent({
     .addNode('translationSubGraph', translationSubGraph)
     // Edges
     .addEdge(START, 'matchPrebuiltRule')
-    .addConditionalEdges('matchPrebuiltRule', matchedPrebuiltRuleConditional)
+    .addConditionalEdges(
+      'matchPrebuiltRule',
+      (state: MigrateRuleState) => matchedPrebuiltRuleConditional(state),
+      { translate: 'translationSubGraph', end: END }
+    )
     .addEdge('translationSubGraph', END);
 
   const graph = siemMigrationAgentGraph.compile();
@@ -46,7 +50,7 @@ export function getRuleMigrationAgent({
 
 const matchedPrebuiltRuleConditional = (state: MigrateRuleState) => {
   if (state.elastic_rule?.prebuilt_rule_id) {
-    return END;
+    return 'end';
   }
-  return 'translation';
+  return 'translate';
 };
diff --git a/...y_solution/server/lib/siem_migrations/rules/task/agent/sub_graphs/translate_rule/graph.ts b/...y_solution/server/lib/siem_migrations/rules/task/agent/sub_graphs/translate_rule/graph.ts
@@ -59,7 +59,7 @@ export function getTranslateRuleGraph({
     .addEdge('retrieveIntegrations', 'translateRule')
     .addEdge('translateRule', 'validation')
     .addEdge('esql_errors', 'validation')
-    .addConditionalEdges('validation', (state: TranslateRuleState) => validationRouter({ state }), {
+    .addConditionalEdges('validation', (state: TranslateRuleState) => validationRouter(state), {
       esql_error: 'esql_errors',
       end: END,
     });
@@ -69,7 +69,7 @@ export function getTranslateRuleGraph({
   return graph;
 }
 
-const validationRouter = ({ state }: TranslateRuleState) => {
+const validationRouter = (state: TranslateRuleState) => {
   if (
     state.validation_errors.iterations <= MAX_VALIDATION_ITERATIONS &&
     state.translation_result === SiemMigrationRuleTranslationResult.FULL