[Entity Analytics] Remove everything except esarchiver calls from `…

…before` and `after` calls in cypress tests (#177175) ## Summary A couple of small tweaks to our cypress tests to move any non-archiver code out of `before` and `after` hooks and into `beforeEach`. Flaky test run serverless and ess https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5219 ✅ ✅ See #174247 for context Co-authored-by: Kibana Machine <[email protected]>
elastic · Feb 20, 2024 · a6a0c12 · a6a0c12
1 parent 64f7037
commit a6a0c12
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 14 deletions.
diff --git a/...ecurity_solution_cypress/cypress/e2e/entity_analytics/dashboards/upgrade_risk_score.cy.ts b/...ecurity_solution_cypress/cypress/e2e/entity_analytics/dashboards/upgrade_risk_score.cy.ts
@@ -36,15 +36,14 @@ import { deleteRiskEngineConfiguration } from '../../../tasks/api_calls/risk_eng
 const spaceId = 'default';
 
 describe('Upgrade risk scores', { tags: ['@ess', '@serverless'] }, () => {
-  before(() => {
+  beforeEach(() => {
     login();
     deleteRiskEngineConfiguration();
     createRule(getNewRule({ rule_id: 'rule1' }));
   });
 
   describe('show upgrade risk button', () => {
     beforeEach(() => {
-      login();
       deleteRiskScore({ riskScoreEntity: RiskScoreEntity.host, spaceId });
       deleteRiskScore({ riskScoreEntity: RiskScoreEntity.user, spaceId });
       installLegacyRiskScoreModule(RiskScoreEntity.host, spaceId);

diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts
@@ -62,28 +62,25 @@ describe(
     },
   },
   () => {
-    before(() => {
+    beforeEach(() => {
       cy.task('esArchiverLoad', { archiveName: 'risk_scores_new_complete_data' });
       cy.task('esArchiverLoad', { archiveName: 'query_alert', useCreate: true, docsOnly: true });
       cy.task('esArchiverLoad', { archiveName: 'user_managed_data' });
       enableAssetCriticality();
+      mockRiskEngineEnabled();
+      login();
+      visitWithTimeRange(ALERTS_URL);
+      waitForAlerts();
     });
 
-    after(() => {
+    afterEach(() => {
       cy.task('esArchiverUnload', 'risk_scores_new_complete_data');
       cy.task('esArchiverUnload', 'user_managed_data');
       deleteAlertsAndRules(); // esArchiverUnload doesn't work properly when using with `useCreate` and `docsOnly` flags
       deleteCriticality({ idField: 'host.name', idValue: SIEM_KIBANA_HOST_NAME });
       deleteCriticality({ idField: 'user.name', idValue: USER_NAME });
     });
 
-    beforeEach(() => {
-      mockRiskEngineEnabled();
-      login();
-      visitWithTimeRange(ALERTS_URL);
-      waitForAlerts();
-    });
-
     describe('User details', () => {
       it('should display entity flyout and open risk input panel', () => {
         expandFirstAlertUserFlyout();

diff --git a/...k/test/security_solution_cypress/cypress/e2e/entity_analytics/host_details/risk_tab.cy.ts b/...k/test/security_solution_cypress/cypress/e2e/entity_analytics/host_details/risk_tab.cy.ts
@@ -22,7 +22,6 @@ describe('risk tab', { tags: ['@ess', '@serverless'] }, () => {
   // FLAKY: https://github.com/elastic/kibana/issues/169034
   describe.skip('with legacy risk score', () => {
     before(() => {
-      // illegal_argument_exception: unknown setting [index.lifecycle.rollover_alias]
       cy.task('esArchiverLoad', { archiveName: 'risk_hosts' });
     });
 

diff --git a/...test/security_solution_cypress/cypress/e2e/entity_analytics/hosts/hosts_risk_column.cy.ts b/...test/security_solution_cypress/cypress/e2e/entity_analytics/hosts/hosts_risk_column.cy.ts
@@ -16,7 +16,6 @@ import { mockRiskEngineEnabled } from '../../../tasks/entity_analytics';
 describe('All hosts table', { tags: ['@ess', '@serverless'] }, () => {
   describe('with legacy risk score', () => {
     before(() => {
-      // illegal_argument_exception: unknown setting [index.lifecycle.name]
       cy.task('esArchiverLoad', { archiveName: 'risk_hosts' });
     });
 
@@ -39,7 +38,6 @@ describe('All hosts table', { tags: ['@ess', '@serverless'] }, () => {
 
   describe('with new risk score', () => {
     before(() => {
-      // illegal_argument_exception: unknown setting [index.lifecycle.name]
       cy.task('esArchiverLoad', { archiveName: 'risk_scores_new' });
     });