Skip to content

Commit

Permalink
Add hacky workaround for getDerivedStateFromProps change in react 16.4 (
Browse files Browse the repository at this point in the history
  • Loading branch information
Bargs authored Nov 6, 2018
1 parent 7748fe6 commit a61c11e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/ui/public/query_bar/components/query_bar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ declare module '@elastic/eui' {
export const EuiOutsideClickDetector: SFC<any>;
}

import { debounce } from 'lodash';
import { debounce, isEqual } from 'lodash';
import React, { Component, SFC } from 'react';
import { getFromLegacyIndexPattern } from 'ui/index_patterns/static_utils';
import { kfetch } from 'ui/kfetch';
Expand Down Expand Up @@ -84,23 +84,30 @@ interface State {
index: number | null;
suggestions: AutocompleteSuggestion[];
suggestionLimit: number;
currentProps?: Props;
}

export class QueryBar extends Component<Props, State> {
public static getDerivedStateFromProps(nextProps: Props, prevState: State) {
if (isEqual(prevState.currentProps, nextProps)) {
return null;
}

if (nextProps.query.query !== prevState.query.query) {
return {
query: {
query: toUser(nextProps.query.query),
language: nextProps.query.language,
},
currentProps: nextProps,
};
} else if (nextProps.query.language !== prevState.query.language) {
return {
query: {
query: '',
language: nextProps.query.language,
},
currentProps: nextProps,
};
}

Expand Down

0 comments on commit a61c11e

Please sign in to comment.