Don't refetch when disabled filters change

elastic · Jul 29, 2019 · a618a3e · a618a3e
1 parent 11480fb
commit a618a3e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/visualize/editor/editor.js b/src/legacy/core_plugins/kibana/public/visualize/editor/editor.js
@@ -405,8 +405,14 @@ function VisEditor(
     // update the searchSource when filters update
     const filterUpdateSubscription = subscribeWithScope($scope, queryFilter.getUpdates$(), {
       next: () => {
-        $scope.filters = queryFilter.getFilters();
+        const filters = queryFilter.getFilters();
+        const isFetchRequired = !_.isEqual(
+          (filters || []).filter(filter => !filter.meta.disabled),
+          ($scope.filters || []).filter(filter => !filter.meta.disabled),
+        );
+        $scope.filters = filters;
         $scope.globalFilters = queryFilter.getGlobalFilters();
+        if (isFetchRequired) $scope.fetch();
       }
     });
 

diff --git a/src/legacy/core_plugins/kibana/public/visualize/editor/visualization_editor.js b/src/legacy/core_plugins/kibana/public/visualize/editor/visualization_editor.js
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { debounce } from 'lodash';
+import { debounce, isEqual } from 'lodash';
 import { uiModules } from 'ui/modules';
 import 'angular-sanitize';
 import { VisEditorTypesRegistryProvider } from 'ui/registry/vis_editor_types';
@@ -59,9 +59,16 @@ uiModules
           editor.destroy();
         });
 
-        $scope.$watchGroup(['timeRange', 'filters'], debounce(() => {
-          $scope.renderFunction();
-        }, 100));
+        const debouncedRender = debounce($scope.renderFunction, 100);
+        $scope.$watch('timeRange', debouncedRender);
+        $scope.$watch('filters', filters => {
+          if (!isEqual(
+            (filters || []).filter(filter => !filter.meta.disabled),
+            ($scope.filters || []).filter(filter => !filter.meta.disabled),
+          )) {
+            debouncedRender();
+          }
+        });
       }
     };
   });