make remove filter work (#58871) (#59217)

elastic · Mar 4, 2020 · a181529 · a181529
1 parent ed63c1c
commit a181529
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/legacy/core_plugins/vis_type_vega/public/vega_view/vega_base_view.js b/src/legacy/core_plugins/vis_type_vega/public/vega_view/vega_base_view.js
@@ -279,10 +279,17 @@ export class VegaBaseView {
    */
   async removeFilterHandler(query, index) {
     const indexId = await this._findIndex(index);
-    const filter = esFilters.buildQueryFilter(query, indexId);
+    const filterToRemove = esFilters.buildQueryFilter(query, indexId);
+
+    const currentFilters = this._filterManager.getFilters();
+    const existingFilter = currentFilters.find(filter =>
+      esFilters.compareFilters(filter, filterToRemove)
+    );
+
+    if (!existingFilter) return;
 
     try {
-      this._filterManager.removeFilter(filter);
+      this._filterManager.removeFilter(existingFilter);
     } catch (err) {
       this.onError(err);
     }