Skip to content

Commit

Permalink
added integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
juliaElastic committed Feb 23, 2024
1 parent 3d99a0d commit a06af7a
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 2 deletions.
3 changes: 1 addition & 2 deletions x-pack/plugins/fleet/server/routes/agent_policy/handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,7 @@ export const createAgentPolicyHandler: FleetRequestHandler<
const user = (await appContextService.getSecurity()?.authc.getCurrentUser(request)) || undefined;
const withSysMonitoring = request.query.sys_monitoring ?? false;
const monitoringEnabled = request.body.monitoring_enabled;
const force = request.body.force;
const { has_fleet_server: hasFleetServer, ...newPolicy } = request.body;
const { has_fleet_server: hasFleetServer, force, ...newPolicy } = request.body;
const spaceId = fleetContext.spaceId;
const authorizationHeader = HTTPAuthorizationHeader.parseFromRequest(request, user?.username);

Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugins/fleet/server/services/agent_policy_create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ async function createPackagePolicy(
spaceId: string;
user: AuthenticatedUser | undefined;
authorizationHeader?: HTTPAuthorizationHeader | null;
force?: boolean;
}
) {
const newPackagePolicy = await packagePolicyService
Expand All @@ -78,6 +79,7 @@ async function createPackagePolicy(
user: options.user,
bumpRevision: false,
authorizationHeader: options.authorizationHeader,
force: options.force,
});
}

Expand Down Expand Up @@ -149,6 +151,7 @@ export async function createAgentPolicyWithPackages({
spaceId,
user,
authorizationHeader,
force,
});
}

Expand All @@ -158,6 +161,7 @@ export async function createAgentPolicyWithPackages({
spaceId,
user,
authorizationHeader,
force,
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,32 @@ export default function (providerContext: FtrProviderContext) {
});
});

it('should create .fleet-policies document with inputs', async () => {
const res = await supertest
.post(`/api/fleet/agent_policies?sys_monitoring=true`)
.set('kbn-xsrf', 'xxxx')
.send({
name: 'test-policy-with-system',
namespace: 'default',
force: true, // using force to bypass package verification error
})
.expect(200);

const policyDocRes = await es.search({
index: '.fleet-policies',
query: {
term: {
policy_id: res.body.item.id,
},
},
});

expect(policyDocRes?.hits?.hits.length).to.eql(1);
const source = policyDocRes?.hits?.hits[0]?._source as any;
expect(source?.revision_idx).to.eql(1);
expect(source?.data?.inputs.length).to.eql(3);
});

it('should return a 400 with an empty namespace', async () => {
await supertest
.post(`/api/fleet/agent_policies`)
Expand Down

0 comments on commit a06af7a

Please sign in to comment.