initServicesAndConstants in the start method instead of in the react …

…component
elastic · Nov 21, 2019 · 9bfc86d · 9bfc86d
1 parent 8c64c06
commit 9bfc86d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/x-pack/legacy/plugins/file_upload/public/components/json_upload_and_parse.js b/x-pack/legacy/plugins/file_upload/public/components/json_upload_and_parse.js
@@ -16,7 +16,6 @@ import { IndexSettings } from './index_settings';
 import { JsonIndexFilePicker } from './json_index_file_picker';
 import { JsonImportProgress } from './json_import_progress';
 import _ from 'lodash';
-import { initServicesAndConstants } from '../kibana_services';
 
 const INDEXING_STAGE = {
   INDEXING_STARTED: i18n.translate(
@@ -66,11 +65,6 @@ export class JsonUploadAndParse extends Component {
     indexPatternResp: '',
   };
 
-  constructor(props) {
-    super(props);
-    initServicesAndConstants(props);
-  }
-
   componentDidMount() {
     this._isMounted = true;
   }

diff --git a/x-pack/legacy/plugins/file_upload/public/plugin.ts b/x-pack/legacy/plugins/file_upload/public/plugin.ts
@@ -9,6 +9,8 @@ import { Plugin, CoreStart } from 'src/core/public';
 import { initResources } from './util/indexing_service';
 // @ts-ignore
 import { JsonUploadAndParse } from './components/json_upload_and_parse';
+// @ts-ignore
+import { initServicesAndConstants } from './kibana_services';
 
 /**
  * These are the interfaces with your public contracts. You should export these
@@ -23,12 +25,7 @@ export class FileUploadPlugin implements Plugin<FileUploadPluginSetup, FileUploa
   public setup() {}
 
   public start(core: CoreStart) {
-    const { savedObjects, http, injectedMetadata } = core;
-    Object.assign(JsonUploadAndParse.defaultProps, {
-      savedObjects,
-      http,
-      injectedMetadata,
-    });
+    initServicesAndConstants(core);
     return {
       JsonUploadAndParse,
     };