[ML] PR remarks

elastic · Jun 17, 2020 · 9a29a0c · 9a29a0c
1 parent 50fb091
commit 9a29a0c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/x-pack/test/functional/services/ml/anomaly_explorer.ts b/x-pack/test/functional/services/ml/anomaly_explorer.ts
@@ -77,11 +77,16 @@ export function MachineLearningAnomalyExplorerProvider({ getService }: FtrProvid
       await this.filterWithSearchString(dashboardTitle);
       await testSubjects.isDisplayed('mlDashboardSelectionTable > checkboxSelectAll');
       await testSubjects.click('mlDashboardSelectionTable > checkboxSelectAll');
-      await testSubjects.isChecked('mlDashboardSelectionTable > checkboxSelectAll');
+      expect(await testSubjects.isChecked('mlDashboardSelectionTable > checkboxSelectAll')).to.be(
+        true
+      );
       await testSubjects.clickWhenNotDisabled('mlAddAndEditDashboardButton');
       const embeddable = await testSubjects.find('mlAnomalySwimlaneEmbeddableWrapper');
       const swimlane = await embeddable.findByClassName('ml-swimlanes');
-      expect(await swimlane.isDisplayed()).to.be(true);
+      expect(await swimlane.isDisplayed()).to.eql(
+        true,
+        'Anomaly swimlane should be displayed in dashboard'
+      );
     },
 
     async waitForDashboardsToLoad() {

diff --git a/x-pack/test/functional/services/ml/test_resources.ts b/x-pack/test/functional/services/ml/test_resources.ts
@@ -315,8 +315,8 @@ export function MachineLearningTestResourcesProvider({ getService }: FtrProvider
     },
 
     async deleteDashboards() {
-      for (const search of Object.values(dashboards)) {
-        await this.deleteDashboardByTitle(search.requestBody.attributes.title);
+      for (const dashboard of Object.values(dashboards)) {
+        await this.deleteDashboardByTitle(dashboard.requestBody.attributes.title);
       }
     },