Add cache for formatted hits

elastic · Oct 16, 2021 · 97c4984 · 97c4984
1 parent 22be128
commit 97c4984
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/src/plugins/discover/public/application/helpers/format_hit.ts b/src/plugins/discover/public/application/helpers/format_hit.ts
@@ -14,13 +14,21 @@ import { formatFieldValue } from './format_value';
 
 // TODO: Test coverage
 // TODO: documentation
-// TODO: Build cache
+
+const formattedHitCache = new WeakMap<estypes.SearchHit, FormattedHit>();
+
+type FormattedHit = Array<[string, JSX.Element]>;
 
 export function formatHit(
   hit: estypes.SearchHit,
   dataView: DataView,
   fieldsToShow: string[]
-): Array<[string, JSX.Element]> {
+): FormattedHit {
+  const cached = formattedHitCache.get(hit);
+  if (cached) {
+    return cached;
+  }
+
   const highlights = hit.highlight ?? {};
   // Keys are sorted in the hits object
   const flattened = flattenHit(hit, dataView, { includeIgnoredValues: true, source: true });
@@ -40,5 +48,7 @@ export function formatHit(
     }
   });
   const maxEntries = getServices().uiSettings.get<number>(MAX_DOC_FIELDS_DISPLAYED);
-  return [...highlightPairs, ...sourcePairs].slice(0, maxEntries);
+  const formatted = [...highlightPairs, ...sourcePairs].slice(0, maxEntries);
+  formattedHitCache.set(hit, formatted);
+  return formatted;
 }