Add missing attributes for new version of @langtrase/trace-attributes

elastic · Nov 18, 2024 · 978c692 · 978c692
1 parent 9676052
commit 978c692
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/kbn-server-route-repository-client/src/create_observable_from_http_response.ts b/packages/kbn-server-route-repository-client/src/create_observable_from_http_response.ts
@@ -37,10 +37,10 @@ export function createObservableFromHttpResponse(
   }
 
   return new Observable<string>((subscriber) => {
-    const parser = createParser((event) => {
-      if (event.type === 'event') {
+    const parser = createParser({
+      onEvent: (event) => {
         subscriber.next(event.data);
-      }
+      },
     });
 
     const readStream = async () => {

diff --git a/...ability_ai_assistant/server/service/client/operators/with_langtrace_chat_complete_span.ts b/...ability_ai_assistant/server/service/client/operators/with_langtrace_chat_complete_span.ts
@@ -41,7 +41,10 @@ export function withLangtraceChatCompleteSpan<T extends ChatEvent>({
     'http.max.retries': 0,
     // dummy URL
     'url.full': 'http://localhost:3000/chat/completions',
+    'url.path': '/chat/completions',
     'http.timeout': 120 * 1000,
+    'gen_ai.operation.name': 'chat_completion',
+    'gen_ai.request.model': model,
     'llm.prompts': JSON.stringify(
       messages.map((message) => ({
         role: message.message.role,