[7.x] Spaces - fix react hook deps (#49618) (#49656)

* fix react hook deps * removing lint override for spaces
elastic · Oct 29, 2019 · 964658c · 964658c
1 parent 9c75659
commit 964658c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -229,12 +229,6 @@ module.exports = {
         'react-hooks/exhaustive-deps': 'off',
       },
     },
-    {
-      files: ['x-pack/legacy/plugins/spaces/**/*.{js,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: ['x-pack/legacy/plugins/transform/**/*.{js,ts,tsx}'],
       rules: {

diff --git a/...s/public/views/management/components/copy_saved_objects_to_space/copy_to_space_flyout.tsx b/...s/public/views/management/components/copy_saved_objects_to_space/copy_to_space_flyout.tsx
@@ -72,7 +72,7 @@ export const CopySavedObjectsToSpaceFlyout = (props: Props) => {
           }),
         });
       });
-  }, []);
+  }, [spacesManager, toastNotifications]);
   const eligibleSpaces = spaces.filter(space => space.id !== props.activeSpace.id);
 
   const [copyInProgress, setCopyInProgress] = useState(false);
-Original file line number
+Diff line change
@@ Expand Up @@
               }),
             });
           });
-      }, []);
+      }, [spacesManager, toastNotifications]);
       const eligibleSpaces = spaces.filter(space => space.id !== props.activeSpace.id);
       const [copyInProgress, setCopyInProgress] = useState(false);
@@ Expand Down @@