Fix router test for creating an ML rule

We were sending invalid parameters.
elastic · Mar 18, 2020 · 8ff01e9 · 8ff01e9
1 parent 1aa4321
commit 8ff01e9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/__mocks__/request_responses.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/__mocks__/request_responses.ts
@@ -293,17 +293,20 @@ export const getCreateRequest = () =>
     body: typicalPayload(),
   });
 
-export const createMlRuleRequest = () =>
-  requestMock.create({
+export const createMlRuleRequest = () => {
+  const { query, language, index, ...mlParams } = typicalPayload();
+
+  return requestMock.create({
     method: 'post',
     path: DETECTION_ENGINE_RULES_URL,
     body: {
-      ...typicalPayload(),
+      ...mlParams,
       type: 'machine_learning',
       anomaly_threshold: 50,
       machine_learning_job_id: 'some-uuid',
     },
   });
+};
 
 export const getSetSignalStatusByIdsRequest = () =>
   requestMock.create({

diff --git a/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.test.ts b/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.test.ts
@@ -50,7 +50,7 @@ describe('create_rules', () => {
   });
 
   describe('creating an ML Rule', () => {
-    it('works', async () => {
+    it('is successful', async () => {
       const response = await server.inject(createMlRuleRequest(), context);
       expect(response.status).toEqual(200);
     });