address review feedback

elastic · Jul 8, 2020 · 8f37c18 · 8f37c18
1 parent 5d0675d
commit 8f37c18
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/x-pack/plugins/index_management/__jest__/client_integration/helpers/setup_environment.tsx b/x-pack/plugins/index_management/__jest__/client_integration/helpers/setup_environment.tsx
@@ -36,7 +36,7 @@ setExtensionsService(services.extensionsService);
 setUiMetricService(services.uiMetricService);
 const appDependencies = {
   services,
-  core: { getUrlForApp: () => {}, navigateToApp: () => {} },
+  core: { getUrlForApp: () => {} },
   plugins: {},
 } as any;
 

diff --git a/x-pack/plugins/index_management/public/application/app_context.tsx b/x-pack/plugins/index_management/public/application/app_context.tsx
@@ -21,7 +21,6 @@ export interface AppDependencies {
   core: {
     fatalErrors: CoreStart['fatalErrors'];
     getUrlForApp: CoreStart['application']['getUrlForApp'];
-    navigateToApp: CoreStart['application']['navigateToApp'];
   };
   plugins: {
     usageCollection: UsageCollectionSetup;

diff --git a/x-pack/plugins/index_management/public/application/mount_management_section.ts b/x-pack/plugins/index_management/public/application/mount_management_section.ts
@@ -43,7 +43,6 @@ export async function mountManagementSection(
     core: {
       fatalErrors,
       getUrlForApp: application.getUrlForApp,
-      navigateToApp: application.navigateToApp,
     },
     plugins: {
       usageCollection,

diff --git a/...ment/public/application/sections/home/template_list/template_details/tabs/tab_summary.tsx b/...ment/public/application/sections/home/template_list/template_details/tabs/tab_summary.tsx
@@ -53,7 +53,7 @@ export const TabSummary: React.FunctionComponent<Props> = ({ templateDetails })
   const numIndexPatterns = indexPatterns.length;
 
   const {
-    core: { navigateToApp },
+    core: { getUrlForApp },
   } = useAppContext();
 
   return (
@@ -159,9 +159,9 @@ export const TabSummary: React.FunctionComponent<Props> = ({ templateDetails })
               <EuiDescriptionListDescription>
                 {ilmPolicy && ilmPolicy.name ? (
                   <EuiLink
-                    onClick={() =>
-                      navigateToApp('management', { path: getILMPolicyPath(ilmPolicy.name) })
-                    }
+                    href={getUrlForApp('management', {
+                      path: getILMPolicyPath(ilmPolicy.name),
+                    })}
                   >
                     {ilmPolicy.name}
                   </EuiLink>