[Transform] Add spacer, rename indices,

elastic · Jun 5, 2020 · 8e7b21a · 8e7b21a
1 parent cd293f2
commit 8e7b21a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/x-pack/plugins/transform/public/app/components/toast_notification_text.tsx b/x-pack/plugins/transform/public/app/components/toast_notification_text.tsx
@@ -51,7 +51,7 @@ export const ToastNotificationText: FC<ToastNotificationTextProps> = ({
 
   const unformattedText = text.message ? text.message : text;
   const formattedText = typeof unformattedText === 'object' ? JSON.stringify(text, null, 2) : text;
-  const textLength = previewTextLength || 140;
+  const textLength = previewTextLength ?? 140;
   const previewText = `${formattedText.substring(0, textLength)}${
     formattedText.length > textLength ? ' ...' : ''
   }`;

diff --git a/x-pack/plugins/transform/public/app/hooks/use_delete_transform.tsx b/x-pack/plugins/transform/public/app/hooks/use_delete_transform.tsx
@@ -157,7 +157,7 @@ export const useDeleteTransforms = () => {
           const destinationIndex = status.destinationIndex;
 
           // if we are only deleting one transform, show the success toast messages
-          if (!isBulk) {
+          if (!isBulk && status.transformDeleted) {
             if (status.transformDeleted?.success) {
               toastNotifications.addSuccess(
                 i18n.translate('xpack.transform.transformList.deleteTransformSuccessMessage', {

diff --git a/...form/public/app/sections/transform_management/components/transform_list/action_delete.tsx b/...form/public/app/sections/transform_management/components/transform_list/action_delete.tsx
@@ -15,6 +15,7 @@ import {
   EuiFlexGroup,
   EuiFlexItem,
   EuiSwitch,
+  EuiSpacer,
 } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { TRANSFORM_STATE } from '../../../../../../common';
@@ -99,18 +100,18 @@ export const DeleteAction: FC<DeleteActionProps> = ({ items, forceDisable }) =>
           {
             <EuiSwitch
               data-test-subj="transformBulkDeleteIndexSwitch"
-              style={{ paddingBottom: 10 }}
               label={i18n.translate(
                 'xpack.transform.actionDeleteTransform.bulkDeleteDestinationIndexTitle',
                 {
-                  defaultMessage: 'Delete destination indexes',
+                  defaultMessage: 'Delete destination indices',
                 }
               )}
               checked={deleteDestIndex}
               onChange={toggleDeleteIndex}
             />
           }
         </EuiFlexItem>
+        <EuiSpacer size="s" />
         <EuiFlexItem>
           {
             <EuiSwitch
@@ -143,7 +144,6 @@ export const DeleteAction: FC<DeleteActionProps> = ({ items, forceDisable }) =>
           {userCanDeleteIndex && (
             <EuiSwitch
               data-test-subj="transformDeleteIndexSwitch"
-              style={{ paddingBottom: 10 }}
               label={i18n.translate(
                 'xpack.transform.actionDeleteTransform.deleteDestinationIndexTitle',
                 {
@@ -156,8 +156,9 @@ export const DeleteAction: FC<DeleteActionProps> = ({ items, forceDisable }) =>
             />
           )}
         </EuiFlexItem>
-        <EuiFlexItem>
-          {userCanDeleteIndex && indexPatternExists && (
+        {userCanDeleteIndex && indexPatternExists && (
+          <EuiFlexItem>
+            <EuiSpacer size="s" />
             <EuiSwitch
               data-test-subj="transformDeleteIndexPatternSwitch"
               label={i18n.translate(
@@ -170,8 +171,8 @@ export const DeleteAction: FC<DeleteActionProps> = ({ items, forceDisable }) =>
               checked={deleteIndexPattern}
               onChange={toggleDeleteIndexPattern}
             />
-          )}
-        </EuiFlexItem>
+          </EuiFlexItem>
+        )}
       </EuiFlexGroup>
     </>
   );