Skip to content

Commit

Permalink
address review requests
Browse files Browse the repository at this point in the history
  • Loading branch information
spalger committed May 4, 2017
1 parent d2bf829 commit 8db3d65
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/cli/cluster/worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ module.exports = class Worker extends EventEmitter {
// we don't need to react to process.exit anymore
this.processBinder.destroy();

// wait until the cluster reports this fork has exitted, then resolve
// wait until the cluster reports this fork has exited, then resolve
await new Promise(resolve => this.once('fork:exit', resolve));
}
}
Expand Down Expand Up @@ -153,7 +153,7 @@ module.exports = class Worker extends EventEmitter {
this.forkBinder.on('online', () => this.onOnline());
this.forkBinder.on('disconnect', () => this.onDisconnect());

// when the cluster says a fork has exitted, check if it is ours
// when the cluster says a fork has exited, check if it is ours
this.clusterBinder.on('exit', (fork, code) => this.onExit(fork, code));

// when the process exits, make sure we kill our workers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,6 @@ const noop = () => {};
* @type {Object}
*/
export class ChromedriverApi extends EventEmitter {

/**
* Create an instance of the ChromedriverApi for a url.
*
* @param {ToolingLog} log
* @param {Lifecycle} lifecycle
* @param {String} url
* @return {Promise<ChromedriverApi>}
*/
static async factory(log, url) {
return (await ping(url))
? createRemoteChromedriverApi(log, url)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function createLocalChromedriverApi(log, url) {

proc.on('exit', (code) => {
if (!api.isStopped() || code > 0) {
api.emit('error', new Error(`Chromedriver exitted with code ${code}`));
api.emit('error', new Error(`Chromedriver exited with code ${code}`));
}
});

Expand Down

0 comments on commit 8db3d65

Please sign in to comment.