[Alerting] Migrate Actions, Alerts, Stack Alerts and TriggersActionsU…

…I plugins to TS project references (#88556) * [Alerting] Migrate Actions plugin to TS project references * alerts plugin ts migration * triggers_actions_ui plugin ts migration * fixed build * fixed build
elastic · Jan 20, 2021 · 8b1a228 · 8b1a228
1 parent c9002a2
commit 8b1a228
Show file tree

Hide file tree

Showing 10 changed files with 133 additions and 7 deletions.
diff --git a/x-pack/examples/alerting_example/tsconfig.json b/x-pack/examples/alerting_example/tsconfig.json
@@ -9,7 +9,7 @@
     "public/**/*.tsx",
     "server/**/*.ts",
     "common/**/*.ts",
-    "../../../typings/**/*",
+    "../../typings/**/*",
   ],
   "exclude": [],
   "references": [

diff --git a/x-pack/plugins/actions/server/lib/ensure_sufficient_license.ts b/x-pack/plugins/actions/server/lib/ensure_sufficient_license.ts
@@ -6,9 +6,10 @@
 import { ActionType } from '../types';
 import { LICENSE_TYPE } from '../../../licensing/common/types';
 import { ServerLogActionTypeId, IndexActionTypeId } from '../builtin_action_types';
-import { CASE_ACTION_TYPE_ID } from '../../../case/server';
 import { ActionTypeConfig, ActionTypeSecrets, ActionTypeParams } from '../types';
 
+export const CASE_ACTION_TYPE_ID = '.case';
+
 const ACTIONS_SCOPED_WITHIN_STACK = new Set([
   ServerLogActionTypeId,
   IndexActionTypeId,

diff --git a/x-pack/plugins/actions/tsconfig.json b/x-pack/plugins/actions/tsconfig.json
@@ -0,0 +1,27 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "composite": true,
+    "outDir": "./target/types",
+    "emitDeclarationOnly": true,
+    "declaration": true,
+    "declarationMap": true
+  },
+  "include": [
+    "server/**/*",
+    // have to declare *.json explicitly due to https://github.com/microsoft/TypeScript/issues/25636
+    "server/**/*.json",
+    "common/*"
+  ],
+  "references": [
+    { "path": "../../../src/core/tsconfig.json" },
+    { "path": "../spaces/tsconfig.json" },
+    { "path": "../security/tsconfig.json" },
+    { "path": "../licensing/tsconfig.json" },
+    { "path": "../task_manager/tsconfig.json" },
+    { "path": "../event_log/tsconfig.json" },
+    { "path": "../encrypted_saved_objects/tsconfig.json" },
+    { "path": "../features/tsconfig.json" },
+    { "path": "../../../src/plugins/usage_collection/tsconfig.json" }
+  ]
+}
diff --git a/x-pack/plugins/alerts/server/saved_objects/migrations.ts b/x-pack/plugins/alerts/server/saved_objects/migrations.ts
@@ -11,11 +11,9 @@ import {
 } from '../../../../../src/core/server';
 import { RawAlert } from '../types';
 import { EncryptedSavedObjectsPluginSetup } from '../../../encrypted_saved_objects/server';
-import {
-  APP_ID as SIEM_APP_ID,
-  SERVER_APP_ID as SIEM_SERVER_APP_ID,
-} from '../../../security_solution/common/constants';
 
+const SIEM_APP_ID = 'securitySolution';
+const SIEM_SERVER_APP_ID = 'siem';
 export const LEGACY_LAST_MODIFIED_VERSION = 'pre-7.10.0';
 
 type AlertMigration = (

diff --git a/x-pack/plugins/alerts/tsconfig.json b/x-pack/plugins/alerts/tsconfig.json
@@ -0,0 +1,30 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "composite": true,
+    "outDir": "./target/types",
+    "emitDeclarationOnly": true,
+    "declaration": true,
+    "declarationMap": true
+  },
+  "include": [
+    "server/**/*",
+    // have to declare *.json explicitly due to https://github.com/microsoft/TypeScript/issues/25636
+    "server/**/*.json",
+    "public/**/*",
+    "common/*"
+  ],
+  "references": [
+    { "path": "../../../src/core/tsconfig.json" },
+    { "path": "../actions/tsconfig.json" },
+    { "path": "../spaces/tsconfig.json" },
+    { "path": "../security/tsconfig.json" },
+    { "path": "../licensing/tsconfig.json" },
+    { "path": "../task_manager/tsconfig.json" },
+    { "path": "../event_log/tsconfig.json" },
+    { "path": "../encrypted_saved_objects/tsconfig.json" },
+    { "path": "../features/tsconfig.json" },
+    { "path": "../../../src/plugins/usage_collection/tsconfig.json" },
+    { "path": "../../../src/plugins/kibana_utils/tsconfig.json" }
+  ]
+}
diff --git a/x-pack/plugins/stack_alerts/tsconfig.json b/x-pack/plugins/stack_alerts/tsconfig.json
@@ -0,0 +1,25 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "composite": true,
+    "outDir": "./target/types",
+    "emitDeclarationOnly": true,
+    "declaration": true,
+    "declarationMap": true
+  },
+  "include": [
+    "server/**/*",
+    "server/**/*.json",
+    "public/**/*",
+    "common/*"
+  ],
+  "references": [
+    { "path": "../../../src/core/tsconfig.json" },
+    { "path": "../alerts/tsconfig.json" },
+    { "path": "../features/tsconfig.json" },
+    { "path": "../triggers_actions_ui/tsconfig.json" },
+    { "path": "../../../src/plugins/kibana_react/tsconfig.json" },
+    { "path": "../../../src/plugins/saved_objects/tsconfig.json" },
+    { "path": "../../../src/plugins/data/tsconfig.json" }
+  ]
+}
diff --git a/x-pack/plugins/triggers_actions_ui/tsconfig.json b/x-pack/plugins/triggers_actions_ui/tsconfig.json
@@ -0,0 +1,29 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "composite": true,
+    "outDir": "./target/types",
+    "emitDeclarationOnly": true,
+    "declaration": true,
+    "declarationMap": true
+  },
+  "include": [
+    "server/**/*",
+    "public/**/*",
+    "common/**/*",
+    "config.ts",
+    "../../../typings/**/*"
+  ],
+  "references": [
+    { "path": "../../../src/core/tsconfig.json" },
+    { "path": "../alerts/tsconfig.json" },
+    { "path": "../features/tsconfig.json" },
+    { "path": "../../../src/plugins/data/tsconfig.json" },
+    { "path": "../../../src/plugins/saved_objects/tsconfig.json" },
+    { "path": "../../../src/plugins/home/tsconfig.json" },
+    { "path": "../../../src/plugins/charts/tsconfig.json" },
+    { "path": "../../../src/plugins/kibana_react/tsconfig.json" },
+    { "path": "../../../src/plugins/kibana_utils/tsconfig.json" },
+    { "path": "../../../src/plugins/management/tsconfig.json" },
+  ]
+}
diff --git a/x-pack/test/tsconfig.json b/x-pack/test/tsconfig.json
@@ -36,6 +36,8 @@
     { "path": "../../src/plugins/ui_actions/tsconfig.json" },
     { "path": "../../src/plugins/url_forwarding/tsconfig.json" },
 
+    { "path": "../plugins/actions/tsconfig.json"},
+    { "path": "../plugins/alerts/tsconfig.json"},
     { "path": "../plugins/console_extensions/tsconfig.json" },
     { "path": "../plugins/data_enhanced/tsconfig.json" },
     { "path": "../plugins/global_search/tsconfig.json" },
@@ -46,10 +48,12 @@
     { "path": "../plugins/licensing/tsconfig.json" },
     { "path": "../plugins/task_manager/tsconfig.json" },
     { "path": "../plugins/telemetry_collection_xpack/tsconfig.json" },
+    { "path": "../plugins/triggers_actions_ui/tsconfig.json" },
     { "path": "../plugins/ui_actions_enhanced/tsconfig.json" },
     { "path": "../plugins/spaces/tsconfig.json" },
     { "path": "../plugins/security/tsconfig.json" },
     { "path": "../plugins/encrypted_saved_objects/tsconfig.json" },
+    { "path": "../plugins/stack_alerts/tsconfig.json" },
     { "path": "../plugins/beats_management/tsconfig.json" },
     { "path": "../plugins/cloud/tsconfig.json" },
     { "path": "../plugins/saved_objects_tagging/tsconfig.json" },

diff --git a/x-pack/tsconfig.json b/x-pack/tsconfig.json
@@ -2,6 +2,8 @@
   "extends": "../tsconfig.base.json",
   "include": ["mocks.ts", "typings/**/*", "plugins/**/*", "tasks/**/*"],
   "exclude": [
+    "plugins/actions/**/*",
+    "plugins/alerts/**/*",
     "plugins/apm/e2e/cypress/**/*",
     "plugins/apm/ftr_e2e/**/*",
     "plugins/apm/scripts/**/*",
@@ -21,10 +23,12 @@
     "plugins/task_manager/**/*",
     "plugins/telemetry_collection_xpack/**/*",
     "plugins/translations/**/*",
+    "plugins/triggers_actions_ui/**/*",
     "plugins/ui_actions_enhanced/**/*",
     "plugins/vis_type_timeseries_enhanced/**/*",
     "plugins/spaces/**/*",
     "plugins/security/**/*",
+    "plugins/stack_alerts/**/*",
     "plugins/encrypted_saved_objects/**/*",
     "plugins/beats_management/**/*",
     "plugins/cloud/**/*",
@@ -92,6 +96,10 @@
     { "path": "./plugins/beats_management/tsconfig.json" },
     { "path": "./plugins/cloud/tsconfig.json" },
     { "path": "./plugins/saved_objects_tagging/tsconfig.json" },
-    { "path": "./plugins/global_search_bar/tsconfig.json" }
+    { "path": "./plugins/global_search_bar/tsconfig.json" },
+    { "path": "./plugins/actions/tsconfig.json"},
+    { "path": "./plugins/alerts/tsconfig.json"},
+    { "path": "./plugins/triggers_actions_ui/tsconfig.json"},
+    { "path": "./plugins/stack_alerts/tsconfig.json"}
   ]
 }
diff --git a/x-pack/tsconfig.refs.json b/x-pack/tsconfig.refs.json
@@ -1,6 +1,8 @@
 {
   "include": [],
   "references": [
+    { "path": "./plugins/actions/tsconfig.json"},
+    { "path": "./plugins/alerts/tsconfig.json"},
     { "path": "./plugins/dashboard_enhanced/tsconfig.json" },
     { "path": "./plugins/licensing/tsconfig.json" },
     { "path": "./plugins/console_extensions/tsconfig.json" },
@@ -18,8 +20,10 @@
     { "path": "./plugins/ui_actions_enhanced/tsconfig.json" },
     { "path": "./plugins/vis_type_timeseries_enhanced/tsconfig.json" },
     { "path": "./plugins/translations/tsconfig.json" },
+    { "path": "./plugins/triggers_actions_ui/tsconfig.json"},
     { "path": "./plugins/spaces/tsconfig.json" },
     { "path": "./plugins/security/tsconfig.json" },
+    { "path": "./plugins/stack_alerts/tsconfig.json"},
     { "path": "./plugins/encrypted_saved_objects/tsconfig.json" },
     { "path": "./plugins/beats_management/tsconfig.json" },
     { "path": "./plugins/cloud/tsconfig.json" },