Fix ts errors

elastic · Oct 20, 2022 · 899c298 · 899c298
1 parent 4ed24f6
commit 899c298
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/x-pack/plugins/canvas/public/components/datasource/datasource_component.js b/x-pack/plugins/canvas/public/components/datasource/datasource_component.js
@@ -71,7 +71,6 @@ export class DatasourceComponent extends PureComponent {
       .getServices()
       .dataViews.getDefaultDataView()
       .then((defaultDataView) => {
-        console.log('componnentDidMount', defaultDataView);
         this.setState({ defaultIndex: defaultDataView.title });
       });
   }

diff --git a/x-pack/plugins/canvas/public/components/es_data_view_select/es_data_view_select.tsx b/x-pack/plugins/canvas/public/components/es_data_view_select/es_data_view_select.tsx
@@ -7,7 +7,7 @@
 
 import { DataView } from '@kbn/data-views-plugin/common';
 import { sortBy } from 'lodash';
-import React, { useRef, useState } from 'react';
+import React, { FC, useRef, useState } from 'react';
 import useEffectOnce from 'react-use/lib/useEffectOnce';
 import { useDataViewsService } from '../../services';
 import {
@@ -17,7 +17,7 @@ import {
 
 type ESDataViewSelectProps = Omit<Props, 'indices' | 'loading'>;
 
-export const ESDataViewSelect: React.FunctionComponent<ESDataViewSelectProps> = (props) => {
+export const ESDataViewSelect: FC<ESDataViewSelectProps> = (props) => {
   const { value, onChange } = props;
 
   const [dataViews, setDataViews] = useState<Array<Pick<DataView, 'id' | 'name' | 'title'>>>([]);
@@ -27,7 +27,6 @@ export const ESDataViewSelect: React.FunctionComponent<ESDataViewSelectProps> =
 
   useEffectOnce(() => {
     getDataViews().then((newDataViews) => {
-      console.log({ newDataViews });
       if (!mounted.current) {
         return;
       }

diff --git a/x-pack/plugins/canvas/public/services/kibana/data_views.ts b/x-pack/plugins/canvas/public/services/kibana/data_views.ts
@@ -26,7 +26,6 @@ export const dataViewsServiceFactory: DataViewsServiceFactory = ({ startPlugins
   getDataViews: async () => {
     try {
       const dataViews = await startPlugins.data.dataViews.getIdsWithTitle();
-      console.log({ dataViews });
       return dataViews.map(({ id, name, title }) => ({ id, name, title } as DataView));
     } catch (e) {
       notify.error(e, { title: strings.getIndicesFetchErrorMessage() });

diff --git a/x-pack/plugins/canvas/public/services/stubs/data_views.ts b/x-pack/plugins/canvas/public/services/stubs/data_views.ts
@@ -11,7 +11,16 @@ import { CanvasDataViewsService } from '../data_views';
 type DataViewsServiceFactory = PluginServiceFactory<CanvasDataViewsService>;
 
 export const dataViewsServiceFactory: DataViewsServiceFactory = () => ({
-  getDataViews: () => Promise.resolve(['dataview1', 'dataview2']),
+  getDataViews: () =>
+    Promise.resolve([
+      { id: 'dataview1', title: 'dataview1', name: 'Data view 1' },
+      { id: 'dataview2', title: 'dataview2', name: 'Data view 2' },
+    ]),
   getFields: () => Promise.resolve(['field1', 'field2']),
-  getDefaultDataView: () => Promise.resolve('defaultDataView'),
+  getDefaultDataView: () =>
+    Promise.resolve({
+      id: 'defaultDataViewId',
+      title: 'defaultDataView',
+      name: 'Default data view',
+    }),
 });