Merge remote-tracking branch 'upstream/master' into grok-debugger-mig…

…ration

.github/paths-labeller.yml

@@ -1,3 +1,19 @@
 ---
+  - "Team:AppArch":
+    - "src/plugins/bfetch/**/*.*"
+    - "src/plugins/dashboard_embeddable_container/**/*.*"
+    - "src/plugins/data/**/*.*"
+    - "src/plugins/embeddable/**/*.*"
+    - "src/plugins/expressions/**/*.*"
+    - "src/plugins/inspector/**/*.*"
+    - "src/plugins/ui_actions/**/*.*"
+    - "src/plugins/visualizations/**/*.*"
+  - "Feature:Embedding":
+    - "src/plugins/embeddable/**/*.*"
+    - "src/plugins/dashboard_embeddable_container/**/*.*"
   - "Feature:Drilldowns":
     - "x-pack/plugins/drilldowns/**/*.*"
+    - "x-pack/plugins/dashboard_enhanced/public/services/drilldowns/**/*.*"
+  - "Feature:ExpressionLanguage":
+    - "src/plugins/expressions/**/*.*"
+    - "src/plugins/bfetch/**/*.*"

docs/development/core/public/kibana-plugin-core-public.coresetup.getstartservices.md

@@ -9,5 +9,5 @@
 <b>Signature:</b>
 
 ```typescript
-getStartServices: StartServicesAccessor<TPluginsStart>;
+getStartServices: StartServicesAccessor<TPluginsStart, TStart>;
 ```

docs/development/core/public/kibana-plugin-core-public.coresetup.md

@@ -9,7 +9,7 @@ Core services exposed to the `Plugin` setup lifecycle
 <b>Signature:</b>
 
 ```typescript
-export interface CoreSetup<TPluginsStart extends object = object> 
+export interface CoreSetup<TPluginsStart extends object = object, TStart = unknown> 
 ```
 
 ## Properties
@@ -19,7 +19,7 @@ export interface CoreSetup<TPluginsStart extends object = object>
 |  [application](./kibana-plugin-core-public.coresetup.application.md) | <code>ApplicationSetup</code> | [ApplicationSetup](./kibana-plugin-core-public.applicationsetup.md) |
 |  [context](./kibana-plugin-core-public.coresetup.context.md) | <code>ContextSetup</code> | [ContextSetup](./kibana-plugin-core-public.contextsetup.md) |
 |  [fatalErrors](./kibana-plugin-core-public.coresetup.fatalerrors.md) | <code>FatalErrorsSetup</code> | [FatalErrorsSetup](./kibana-plugin-core-public.fatalerrorssetup.md) |
-|  [getStartServices](./kibana-plugin-core-public.coresetup.getstartservices.md) | <code>StartServicesAccessor&lt;TPluginsStart&gt;</code> | [StartServicesAccessor](./kibana-plugin-core-public.startservicesaccessor.md) |
+|  [getStartServices](./kibana-plugin-core-public.coresetup.getstartservices.md) | <code>StartServicesAccessor&lt;TPluginsStart, TStart&gt;</code> | [StartServicesAccessor](./kibana-plugin-core-public.startservicesaccessor.md) |
 |  [http](./kibana-plugin-core-public.coresetup.http.md) | <code>HttpSetup</code> | [HttpSetup](./kibana-plugin-core-public.httpsetup.md) |
 |  [injectedMetadata](./kibana-plugin-core-public.coresetup.injectedmetadata.md) | <code>{</code><br/><code>        getInjectedVar: (name: string, defaultValue?: any) =&gt; unknown;</code><br/><code>    }</code> | exposed temporarily until https://github.com/elastic/kibana/issues/41990 done use \*only\* to retrieve config values. There is no way to set injected values in the new platform. Use the legacy platform API instead. |
 |  [notifications](./kibana-plugin-core-public.coresetup.notifications.md) | <code>NotificationsSetup</code> | [NotificationsSetup](./kibana-plugin-core-public.notificationssetup.md) |

docs/development/core/public/kibana-plugin-core-public.httpsetup.basepath.md

@@ -4,7 +4,7 @@
 
 ## HttpSetup.basePath property
 
-APIs for manipulating the basePath on URL segments.
+APIs for manipulating the basePath on URL segments. See [IBasePath](./kibana-plugin-core-public.ibasepath.md)
 
 <b>Signature:</b>
 

docs/development/core/public/kibana-plugin-core-public.httpsetup.md

@@ -16,7 +16,7 @@ export interface HttpSetup
 |  Property | Type | Description |
 |  --- | --- | --- |
 |  [anonymousPaths](./kibana-plugin-core-public.httpsetup.anonymouspaths.md) | <code>IAnonymousPaths</code> | APIs for denoting certain paths for not requiring authentication |
-|  [basePath](./kibana-plugin-core-public.httpsetup.basepath.md) | <code>IBasePath</code> | APIs for manipulating the basePath on URL segments. |
+|  [basePath](./kibana-plugin-core-public.httpsetup.basepath.md) | <code>IBasePath</code> | APIs for manipulating the basePath on URL segments. See [IBasePath](./kibana-plugin-core-public.ibasepath.md) |
 |  [delete](./kibana-plugin-core-public.httpsetup.delete.md) | <code>HttpHandler</code> | Makes an HTTP request with the DELETE method. See [HttpHandler](./kibana-plugin-core-public.httphandler.md) for options. |
 |  [fetch](./kibana-plugin-core-public.httpsetup.fetch.md) | <code>HttpHandler</code> | Makes an HTTP request. Defaults to a GET request unless overriden. See [HttpHandler](./kibana-plugin-core-public.httphandler.md) for options. |
 |  [get](./kibana-plugin-core-public.httpsetup.get.md) | <code>HttpHandler</code> | Makes an HTTP request with the GET method. See [HttpHandler](./kibana-plugin-core-public.httphandler.md) for options. |

docs/development/core/public/kibana-plugin-core-public.legacycoresetup.md

@@ -13,7 +13,7 @@ Setup interface exposed to the legacy platform via the `ui/new_platform` module.
 <b>Signature:</b>
 
 ```typescript
-export interface LegacyCoreSetup extends CoreSetup<any> 
+export interface LegacyCoreSetup extends CoreSetup<any, any> 
 ```
 
 ## Remarks

docs/development/core/public/kibana-plugin-core-public.plugin.setup.md

@@ -7,14 +7,14 @@
 <b>Signature:</b>
 
 ```typescript
-setup(core: CoreSetup<TPluginsStart>, plugins: TPluginsSetup): TSetup | Promise<TSetup>;
+setup(core: CoreSetup<TPluginsStart, TStart>, plugins: TPluginsSetup): TSetup | Promise<TSetup>;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  core | <code>CoreSetup&lt;TPluginsStart&gt;</code> |  |
+|  core | <code>CoreSetup&lt;TPluginsStart, TStart&gt;</code> |  |
 |  plugins | <code>TPluginsSetup</code> |  |
 
 <b>Returns:</b>

docs/development/core/public/kibana-plugin-core-public.startservicesaccessor.md

@@ -9,5 +9,5 @@ Allows plugins to get access to APIs available in start inside async handlers, s
 <b>Signature:</b>
 
 ```typescript
-export declare type StartServicesAccessor<TPluginsStart extends object = object> = () => Promise<[CoreStart, TPluginsStart]>;
+export declare type StartServicesAccessor<TPluginsStart extends object = object, TStart = unknown> = () => Promise<[CoreStart, TPluginsStart, TStart]>;
 ```

docs/development/core/server/kibana-plugin-core-server.coresetup.getstartservices.md

@@ -9,5 +9,5 @@
 <b>Signature:</b>
 
 ```typescript
-getStartServices: StartServicesAccessor<TPluginsStart>;
+getStartServices: StartServicesAccessor<TPluginsStart, TStart>;
 ```

docs/development/core/server/kibana-plugin-core-server.coresetup.md

@@ -9,7 +9,7 @@ Context passed to the plugins `setup` method.
 <b>Signature:</b>
 
 ```typescript
-export interface CoreSetup<TPluginsStart extends object = object> 
+export interface CoreSetup<TPluginsStart extends object = object, TStart = unknown> 
 ```
 
 ## Properties
@@ -19,7 +19,7 @@ export interface CoreSetup<TPluginsStart extends object = object>
 |  [capabilities](./kibana-plugin-core-server.coresetup.capabilities.md) | <code>CapabilitiesSetup</code> | [CapabilitiesSetup](./kibana-plugin-core-server.capabilitiessetup.md) |
 |  [context](./kibana-plugin-core-server.coresetup.context.md) | <code>ContextSetup</code> | [ContextSetup](./kibana-plugin-core-server.contextsetup.md) |
 |  [elasticsearch](./kibana-plugin-core-server.coresetup.elasticsearch.md) | <code>ElasticsearchServiceSetup</code> | [ElasticsearchServiceSetup](./kibana-plugin-core-server.elasticsearchservicesetup.md) |
-|  [getStartServices](./kibana-plugin-core-server.coresetup.getstartservices.md) | <code>StartServicesAccessor&lt;TPluginsStart&gt;</code> | [StartServicesAccessor](./kibana-plugin-core-server.startservicesaccessor.md) |
+|  [getStartServices](./kibana-plugin-core-server.coresetup.getstartservices.md) | <code>StartServicesAccessor&lt;TPluginsStart, TStart&gt;</code> | [StartServicesAccessor](./kibana-plugin-core-server.startservicesaccessor.md) |
 |  [http](./kibana-plugin-core-server.coresetup.http.md) | <code>HttpServiceSetup</code> | [HttpServiceSetup](./kibana-plugin-core-server.httpservicesetup.md) |
 |  [metrics](./kibana-plugin-core-server.coresetup.metrics.md) | <code>MetricsServiceSetup</code> | [MetricsServiceSetup](./kibana-plugin-core-server.metricsservicesetup.md) |
 |  [savedObjects](./kibana-plugin-core-server.coresetup.savedobjects.md) | <code>SavedObjectsServiceSetup</code> | [SavedObjectsServiceSetup](./kibana-plugin-core-server.savedobjectsservicesetup.md) |

docs/development/core/server/kibana-plugin-core-server.md

@@ -115,8 +115,6 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
 |  [PluginConfigDescriptor](./kibana-plugin-core-server.pluginconfigdescriptor.md) | Describes a plugin configuration properties. |
 |  [PluginInitializerContext](./kibana-plugin-core-server.plugininitializercontext.md) | Context that's available to plugins during initialization stage. |
 |  [PluginManifest](./kibana-plugin-core-server.pluginmanifest.md) | Describes the set of required and optional properties plugin can define in its mandatory JSON manifest file. |
-|  [PluginsServiceSetup](./kibana-plugin-core-server.pluginsservicesetup.md) |  |
-|  [PluginsServiceStart](./kibana-plugin-core-server.pluginsservicestart.md) |  |
 |  [RequestHandlerContext](./kibana-plugin-core-server.requesthandlercontext.md) | Plugin specific context passed to a route handler.<!-- -->Provides the following clients and services: - [rendering](./kibana-plugin-core-server.iscopedrenderingclient.md) - Rendering client which uses the data of the incoming request - [savedObjects.client](./kibana-plugin-core-server.savedobjectsclient.md) - Saved Objects client which uses the credentials of the incoming request - [savedObjects.typeRegistry](./kibana-plugin-core-server.isavedobjecttyperegistry.md) - Type registry containing all the registered types. - [elasticsearch.dataClient](./kibana-plugin-core-server.scopedclusterclient.md) - Elasticsearch data client which uses the credentials of the incoming request - [elasticsearch.adminClient](./kibana-plugin-core-server.scopedclusterclient.md) - Elasticsearch admin client which uses the credentials of the incoming request - [uiSettings.client](./kibana-plugin-core-server.iuisettingsclient.md) - uiSettings client which uses the credentials of the incoming request |
 |  [RouteConfig](./kibana-plugin-core-server.routeconfig.md) | Route specific configuration. |
 |  [RouteConfigOptions](./kibana-plugin-core-server.routeconfigoptions.md) | Additional route options. |

docs/development/core/server/kibana-plugin-core-server.startservicesaccessor.md

@@ -9,5 +9,5 @@ Allows plugins to get access to APIs available in start inside async handlers. P
 <b>Signature:</b>
 
 ```typescript
-export declare type StartServicesAccessor<TPluginsStart extends object = object> = () => Promise<[CoreStart, TPluginsStart]>;
+export declare type StartServicesAccessor<TPluginsStart extends object = object, TStart = unknown> = () => Promise<[CoreStart, TPluginsStart, TStart]>;
 ```

examples/alerting_example/public/plugin.tsx

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { Plugin, CoreSetup, AppMountParameters, CoreStart } from 'kibana/public';
+import { Plugin, CoreSetup, AppMountParameters } from 'kibana/public';
 import { PluginSetupContract as AlertingSetup } from '../../../x-pack/plugins/alerting/public';
 import { ChartsPluginStart } from '../../../src/plugins/charts/public';
 import { TriggersAndActionsUIPublicPluginSetup } from '../../../x-pack/plugins/triggers_actions_ui/public';
@@ -43,17 +43,14 @@ export interface AlertingExamplePublicStartDeps {
 
 export class AlertingExamplePlugin implements Plugin<Setup, Start, AlertingExamplePublicSetupDeps> {
   public setup(
-    core: CoreSetup<AlertingExamplePublicStartDeps>,
+    core: CoreSetup<AlertingExamplePublicStartDeps, Start>,
     { alerting, triggers_actions_ui }: AlertingExamplePublicSetupDeps
   ) {
     core.application.register({
       id: 'AlertingExample',
       title: 'Alerting Example',
       async mount(params: AppMountParameters) {
-        const [coreStart, depsStart]: [
-          CoreStart,
-          AlertingExamplePublicStartDeps
-        ] = await core.getStartServices();
+        const [coreStart, depsStart] = await core.getStartServices();
         const { renderApp } = await import('./application');
         return renderApp(coreStart, depsStart, params);
       },

examples/bfetch_explorer/public/plugin.tsx

@@ -34,7 +34,10 @@ export interface BfetchExplorerStartPlugins {
 }
 
 export class BfetchExplorerPlugin implements Plugin {
-  public setup(core: CoreSetup<BfetchExplorerStartPlugins>, plugins: BfetchExplorerSetupPlugins) {
+  public setup(
+    core: CoreSetup<BfetchExplorerStartPlugins, void>,
+    plugins: BfetchExplorerSetupPlugins
+  ) {
     const double = plugins.bfetch.batchedFunction<{ num: number }, { num: number }>({
       url: '/bfetch_explorer/double',
     });

examples/embeddable_examples/public/index.ts

@@ -26,9 +26,18 @@ export {
 export { ListContainer, LIST_CONTAINER } from './list_container';
 export { TODO_EMBEDDABLE } from './todo';
 
-import { EmbeddableExamplesPlugin } from './plugin';
+import {
+  EmbeddableExamplesPlugin,
+  EmbeddableExamplesSetupDependencies,
+  EmbeddableExamplesStartDependencies,
+} from './plugin';
 
 export { SearchableListContainer, SEARCHABLE_LIST_CONTAINER } from './searchable_list_container';
 export { MULTI_TASK_TODO_EMBEDDABLE } from './multi_task_todo';
 
-export const plugin: PluginInitializer<void, void> = () => new EmbeddableExamplesPlugin();
+export const plugin: PluginInitializer<
+  void,
+  void,
+  EmbeddableExamplesSetupDependencies,
+  EmbeddableExamplesStartDependencies
+> = () => new EmbeddableExamplesPlugin();

examples/embeddable_examples/public/plugin.ts

@@ -28,11 +28,11 @@ import {
 } from './searchable_list_container';
 import { LIST_CONTAINER, ListContainerFactory } from './list_container';
 
-interface EmbeddableExamplesSetupDependencies {
+export interface EmbeddableExamplesSetupDependencies {
   embeddable: EmbeddableSetup;
 }
 
-interface EmbeddableExamplesStartDependencies {
+export interface EmbeddableExamplesStartDependencies {
   embeddable: EmbeddableStart;
 }
 

examples/search_explorer/public/plugin.tsx

@@ -21,7 +21,7 @@ import { Plugin, CoreSetup, AppMountParameters } from 'kibana/public';
 import { AppPluginStartDependencies } from './types';
 
 export class SearchExplorerPlugin implements Plugin {
-  public setup(core: CoreSetup<AppPluginStartDependencies>) {
+  public setup(core: CoreSetup<AppPluginStartDependencies, void>) {
     core.application.register({
       id: 'searchExplorer',
       title: 'Search Explorer',