[Discover] Consider pinned filters too in No fields message

elastic · Dec 1, 2022 · 82f62a0 · 82f62a0
1 parent 1d46c8a
commit 82f62a0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/plugins/discover/public/application/main/components/sidebar/discover_sidebar.test.tsx b/src/plugins/discover/public/application/main/components/sidebar/discover_sidebar.test.tsx
@@ -103,6 +103,7 @@ function getCompProps(): DiscoverSidebarProps {
     availableFields$,
     useNewFieldsApi: true,
     showFieldList: true,
+    isAffectedByGlobalFilter: false,
   };
 }
 

diff --git a/src/plugins/discover/public/application/main/components/sidebar/discover_sidebar.tsx b/src/plugins/discover/public/application/main/components/sidebar/discover_sidebar.tsx
@@ -101,6 +101,11 @@ export interface DiscoverSidebarProps extends DiscoverSidebarResponsiveProps {
    * Whether to render the field list or not (we don't show it unless documents are loaded)
    */
   showFieldList?: boolean;
+
+  /**
+   * Whether filters are applied
+   */
+  isAffectedByGlobalFilter: boolean;
 }
 
 export function DiscoverSidebarComponent({
@@ -125,13 +130,13 @@ export function DiscoverSidebarComponent({
   createNewDataView,
   showDataViewPicker,
   showFieldList,
+  isAffectedByGlobalFilter,
 }: DiscoverSidebarProps) {
   const { uiSettings, dataViewFieldEditor, dataViews } = useDiscoverServices();
   const isPlainRecord = useAppStateSelector(
     (state) => getRawRecordType(state.query) === RecordRawType.PLAIN
   );
   const query = useAppStateSelector((state) => state.query);
-  const isGlobalFilterApplied = useAppStateSelector((state) => Boolean(state.filters?.length));
 
   const onChangeFieldSearch = useCallback(
     (filterName: string, value: string | boolean | undefined) => {
@@ -270,7 +275,7 @@ export function DiscoverSidebarComponent({
     allFields,
     popularFieldsLimit: !isPlainRecord ? popularFieldsLimit : 0,
     sortedSelectedFields: selectedFieldsState.selectedFields,
-    isAffectedByGlobalFilter: isGlobalFilterApplied,
+    isAffectedByGlobalFilter,
     services: {
       dataViews,
     },

diff --git a/...ugins/discover/public/application/main/components/sidebar/discover_sidebar_responsive.tsx b/...ugins/discover/public/application/main/components/sidebar/discover_sidebar_responsive.tsx
@@ -188,6 +188,7 @@ export function DiscoverSidebarResponsive(props: DiscoverSidebarResponsiveProps)
   }, [selectedDataView, dispatchSidebarStateAction, selectedDataViewRef]);
 
   const querySubscriberResult = useQuerySubscriber({ data });
+  const isAffectedByGlobalFilter = Boolean(querySubscriberResult.filters?.length);
   const { isProcessing, refetchFieldsExistenceInfo } = useExistingFieldsFetcher({
     disableAutoFetching: true,
     dataViews: !isPlainRecord && sidebarState.dataView ? [sidebarState.dataView] : [],
@@ -323,6 +324,7 @@ export function DiscoverSidebarResponsive(props: DiscoverSidebarResponsiveProps)
             editField={editField}
             createNewDataView={createNewDataView}
             showFieldList={showFieldList}
+            isAffectedByGlobalFilter={isAffectedByGlobalFilter}
           />
         </EuiHideFor>
       )}
@@ -389,6 +391,7 @@ export function DiscoverSidebarResponsive(props: DiscoverSidebarResponsiveProps)
                 createNewDataView={createNewDataView}
                 showDataViewPicker={true}
                 showFieldList={showFieldList}
+                isAffectedByGlobalFilter={isAffectedByGlobalFilter}
               />
             </EuiFlyout>
           </EuiPortal>