Fix type errors

elastic · Oct 22, 2024 · 82a6197 · 82a6197
1 parent b0718ce
commit 82a6197
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.../application/sections/home/data_stream_list/edit_data_retention_modal/validations.test.ts b/.../application/sections/home/data_stream_list/edit_data_retention_modal/validations.test.ts
@@ -9,9 +9,9 @@ import { isBiggerThanGlobalMaxRetention } from './validations';
 
 describe('isBiggerThanGlobalMaxRetention', () => {
   it('should return undefined if any argument is missing', () => {
-    expect(isBiggerThanGlobalMaxRetention(undefined, 'd', '30d')).toBeUndefined();
-    expect(isBiggerThanGlobalMaxRetention(10, undefined, '30d')).toBeUndefined();
-    expect(isBiggerThanGlobalMaxRetention(10, 'd', undefined)).toBeUndefined();
+    expect(isBiggerThanGlobalMaxRetention('', 'd', '30d')).toBeUndefined();
+    expect(isBiggerThanGlobalMaxRetention(10, '', '30d')).toBeUndefined();
+    expect(isBiggerThanGlobalMaxRetention(10, 'd', '')).toBeUndefined();
   });
 
   it('should return an error message if retention is bigger than global max retention (in days)', () => {

diff --git a/...ublic/application/sections/home/data_stream_list/edit_data_retention_modal/validations.ts b/...ublic/application/sections/home/data_stream_list/edit_data_retention_modal/validations.ts
@@ -38,9 +38,9 @@ const isRetentionBiggerThan = (valueA: string, valueB: string) => {
 };
 
 export const isBiggerThanGlobalMaxRetention = (
-  retentionValue,
-  retentionTimeUnit,
-  globalMaxRetention
+  retentionValue: string | number,
+  retentionTimeUnit: string,
+  globalMaxRetention: string
 ) => {
   if (!retentionValue || !retentionTimeUnit || !globalMaxRetention) {
     return undefined;