Skip to content

Commit

Permalink
[Lens] Unskips heatmap test suite & stabilizes the dimensionConfigura…
Browse files Browse the repository at this point in the history
…tion helper (#117811)

* [Lens] Unskips heatmap test suite

* Check if operation button exists
  • Loading branch information
stratoula authored Nov 8, 2021
1 parent 0c60ccc commit 828a579
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
13 changes: 7 additions & 6 deletions x-pack/test/functional/apps/lens/heatmap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['visualize', 'lens', 'common', 'header']);
const elasticChart = getService('elasticChart');
const testSubjects = getService('testSubjects');
const retry = getService('retry');

// FLAKY: https://github.com/elastic/kibana/issues/117404
// FLAKY: https://github.com/elastic/kibana/issues/113043
describe.skip('lens heatmap', () => {
describe('lens heatmap', () => {
before(async () => {
await PageObjects.visualize.navigateToNewVisualization();
await PageObjects.visualize.clickVisType('lens');
Expand Down Expand Up @@ -73,9 +72,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('should reflect stop colors change on the chart', async () => {
await PageObjects.lens.openDimensionEditor('lnsHeatmap_cellPanel > lns-dimensionTrigger');
await PageObjects.lens.openPalettePanel('lnsHeatmap');
await testSubjects.setValue('lnsPalettePanel_dynamicColoring_stop_value_0', '10', {
clearWithKeyboard: true,
typeCharByChar: true,
await retry.try(async () => {
await testSubjects.setValue('lnsPalettePanel_dynamicColoring_stop_value_0', '10', {
clearWithKeyboard: true,
typeCharByChar: true,
});
});
await PageObjects.lens.waitForVisualization();

Expand Down
6 changes: 4 additions & 2 deletions x-pack/test/functional/page_objects/lens_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,11 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
const operationSelector = opts.isPreviousIncompatible
? `lns-indexPatternDimension-${opts.operation} incompatible`
: `lns-indexPatternDimension-${opts.operation}`;
await testSubjects.click(operationSelector);
await retry.try(async () => {
await testSubjects.exists(operationSelector);
await testSubjects.click(operationSelector);
});
}

if (opts.field) {
const target = await testSubjects.find('indexPattern-dimension-field');
await comboBox.openOptionsList(target);
Expand Down

0 comments on commit 828a579

Please sign in to comment.