Fixing flaky find tests (#183746)

Resolves #182263 Resolves #182284 Resolves #182314 ## Summary Missing `await` in the backfill tests caused a rule created for those tests not to finish getting deleted before the `find` tests ran --------- Co-authored-by: Kibana Machine <[email protected]>
elastic · May 20, 2024 · 8289548 · 8289548
1 parent 79b8bab
commit 8289548
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/...lerting_api_integration/security_and_spaces/group1/tests/alerting/backfill/task_runner.ts b/...lerting_api_integration/security_and_spaces/group1/tests/alerting/backfill/task_runner.ts
@@ -92,7 +92,7 @@ export default function createBackfillTaskRunnerTests({ getService }: FtrProvide
       await esTestIndexTool.setup();
     });
     afterEach(async () => {
-      objectRemover.removeAll();
+      await objectRemover.removeAll();
       await esTestIndexTool.destroy();
     });
     after(async () => {

diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/find.ts b/x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/find.ts
@@ -19,8 +19,10 @@ const findTestUtils = (
   supertest: SuperTestAgent,
   supertestWithoutAuth: any
 ) => {
-  describe.skip(describeType, () => {
-    afterEach(() => objectRemover.removeAll());
+  describe(describeType, () => {
+    afterEach(async () => {
+      await objectRemover.removeAll();
+    });
 
     for (const scenario of UserAtSpaceScenarios) {
       const { user, space } = scenario;
@@ -651,12 +653,12 @@ export default function createFindTests({ getService }: FtrProviderContext) {
   const supertest = getService('supertest');
   const supertestWithoutAuth = getService('supertestWithoutAuth');
 
-  // Failing: See https://github.com/elastic/kibana/issues/182263
-  // Failing: See https://github.com/elastic/kibana/issues/182284
-  describe.skip('find', () => {
+  describe('find', () => {
     const objectRemover = new ObjectRemover(supertest);
 
-    afterEach(() => objectRemover.removeAll());
+    afterEach(async () => {
+      await objectRemover.removeAll();
+    });
 
     findTestUtils('public', objectRemover, supertest, supertestWithoutAuth);
     findTestUtils('internal', objectRemover, supertest, supertestWithoutAuth);

diff --git a/...test/alerting_api_integration/security_and_spaces/group1/tests/alerting/find_with_post.ts b/...test/alerting_api_integration/security_and_spaces/group1/tests/alerting/find_with_post.ts
@@ -19,14 +19,14 @@ const findTestUtils = (
   supertest: SuperTestAgent,
   supertestWithoutAuth: any
 ) => {
-  // FLAKY: https://github.com/elastic/kibana/issues/182314
-  describe.skip(describeType, () => {
-    afterEach(() => objectRemover.removeAll());
+  describe(describeType, () => {
+    afterEach(async () => {
+      await objectRemover.removeAll();
+    });
 
     for (const scenario of UserAtSpaceScenarios) {
       const { user, space } = scenario;
-      // FLAKY: https://github.com/elastic/kibana/issues/182314
-      describe.skip(scenario.id, () => {
+      describe(scenario.id, () => {
         it('should handle find alert request appropriately', async () => {
           const { body: createdAlert } = await supertest
             .post(`${getUrlPrefix(space.id)}/api/alerting/rule`)
@@ -581,7 +581,9 @@ export default function createFindTests({ getService }: FtrProviderContext) {
   describe('find with post', () => {
     const objectRemover = new ObjectRemover(supertest);
 
-    afterEach(() => objectRemover.removeAll());
+    afterEach(async () => {
+      await objectRemover.removeAll();
+    });
 
     findTestUtils('internal', objectRemover, supertest, supertestWithoutAuth);
   });