fix: make Toolbar and Workpad pure

neither take props, so this stops some re-rendering
elastic · Feb 28, 2019 · 82525ac · 82525ac
1 parent a773403
commit 82525ac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/x-pack/plugins/canvas/public/components/toolbar/index.js b/x-pack/plugins/canvas/public/components/toolbar/index.js
@@ -6,7 +6,7 @@
 
 import { connect } from 'react-redux';
 import PropTypes from 'prop-types';
-import { compose, withState, getContext, withHandlers } from 'recompose';
+import { pure, compose, withState, getContext, withHandlers } from 'recompose';
 
 import {
   getWorkpad,
@@ -26,6 +26,7 @@ const mapStateToProps = state => ({
 });
 
 export const Toolbar = compose(
+  pure,
   connect(mapStateToProps),
   getContext({
     router: PropTypes.object,

diff --git a/x-pack/plugins/canvas/public/components/workpad/index.js b/x-pack/plugins/canvas/public/components/workpad/index.js
@@ -6,7 +6,7 @@
 
 import { connect } from 'react-redux';
 import PropTypes from 'prop-types';
-import { compose, withState, withProps, getContext, withHandlers } from 'recompose';
+import { pure, compose, withState, withProps, getContext, withHandlers } from 'recompose';
 import { transitionsRegistry } from '../../lib/transitions_registry';
 import { undoHistory, redoHistory } from '../../state/actions/history';
 import { fetchAllRenderables } from '../../state/actions/elements';
@@ -40,6 +40,7 @@ const mapDispatchToProps = {
 };
 
 export const Workpad = compose(
+  pure,
   getContext({
     router: PropTypes.object,
   }),