Rename config name

elastic · Apr 29, 2024 · 813297e · 813297e
1 parent 06d98ba
commit 813297e
Show file tree

Hide file tree

Showing 12 changed files with 19 additions and 19 deletions.
diff --git a/config/serverless.yml b/config/serverless.yml
@@ -49,7 +49,7 @@ xpack.index_management.editableIndexSettings: limited
 # Disable Storage size column in the Data streams table from Index Management UI
 xpack.index_management.enableDataStreamsStorageColumn: false
 # Disable _source field in the Mappings editor's advanced options form from Index Management UI
-xpack.index_management.enableMappingsSourceField: false
+xpack.index_management.enableMappingsSourceFieldSection: false
 
 # Keep deeplinks visible so that they are shown in the sidenav
 dev_tools.deeplinks.navLinkStatus: visible

diff --git a/test/plugin_functional/test_suites/core_plugins/rendering.ts b/test/plugin_functional/test_suites/core_plugins/rendering.ts
@@ -291,7 +291,7 @@ export default function ({ getService }: PluginFunctionalProviderContext) {
         'xpack.index_management.enableIndexStats (any)',
         'xpack.index_management.editableIndexSettings (any)',
         'xpack.index_management.enableDataStreamsStorageColumn (any)',
-        'xpack.index_management.enableMappingsSourceField (any)',
+        'xpack.index_management.enableMappingsSourceFieldSection (any)',
         'xpack.license_management.ui.enabled (boolean)',
         'xpack.maps.preserveDrawingBuffer (boolean)',
         'xpack.maps.showMapsInspectorAdapter (boolean)',

diff --git a/x-pack/plugins/index_management/__jest__/client_integration/helpers/setup_environment.tsx b/x-pack/plugins/index_management/__jest__/client_integration/helpers/setup_environment.tsx
@@ -84,7 +84,7 @@ const appDependencies = {
     enableIndexStats: true,
     editableIndexSettings: 'all',
     enableDataStreamsStorageColumn: true,
-    enableMappingsSourceField: true,
+    enableMappingsSourceFieldSection: true,
   },
 } as any;
 

diff --git a/x-pack/plugins/index_management/public/application/app_context.tsx b/x-pack/plugins/index_management/public/application/app_context.tsx
@@ -62,7 +62,7 @@ export interface AppDependencies {
     enableIndexStats: boolean;
     editableIndexSettings: 'all' | 'limited';
     enableDataStreamsStorageColumn: boolean;
-    enableMappingsSourceField: boolean;
+    enableMappingsSourceFieldSection: boolean;
   };
   history: ScopedHistory;
   setBreadcrumbs: (type: IndexManagementBreadcrumb, additionalBreadcrumb?: EuiBreadcrumb) => void;

diff --git a/...cation/components/mappings_editor/__jest__/client_integration/configuration_form.test.tsx b/...cation/components/mappings_editor/__jest__/client_integration/configuration_form.test.tsx
@@ -53,7 +53,7 @@ describe('Mappings editor: configuration form', () => {
   it('renders the form', async () => {
     const ctx = {
       config: {
-        enableMappingsSourceField: true,
+        enableMappingsSourceFieldSection: true,
       },
     } as unknown as AppDependencies;
 
@@ -70,7 +70,7 @@ describe('Mappings editor: configuration form', () => {
     it('renders the _source field when it is enabled', async () => {
       const ctx = {
         config: {
-          enableMappingsSourceField: true,
+          enableMappingsSourceFieldSection: true,
         },
       } as unknown as AppDependencies;
 
@@ -86,7 +86,7 @@ describe('Mappings editor: configuration form', () => {
     it("doesn't render the _source field when it is disabled", async () => {
       const ctx = {
         config: {
-          enableMappingsSourceField: false,
+          enableMappingsSourceFieldSection: false,
         },
       } as unknown as AppDependencies;
 

diff --git a/...plication/components/mappings_editor/__jest__/client_integration/mappings_editor.test.tsx b/...plication/components/mappings_editor/__jest__/client_integration/mappings_editor.test.tsx
@@ -135,7 +135,7 @@ describe('Mappings editor: core', () => {
 
     const ctx = {
       config: {
-        enableMappingsSourceField: true,
+        enableMappingsSourceFieldSection: true,
       },
     };
 
@@ -293,7 +293,7 @@ describe('Mappings editor: core', () => {
 
     const ctx = {
       config: {
-        enableMappingsSourceField: true,
+        enableMappingsSourceFieldSection: true,
       },
     };
 

diff --git a/...plication/components/mappings_editor/components/configuration_form/configuration_form.tsx b/...plication/components/mappings_editor/components/configuration_form/configuration_form.tsx
@@ -99,7 +99,7 @@ const formDeserializer = (formData: GenericObject) => {
 
 export const ConfigurationForm = React.memo(({ value, esNodesPlugins }: Props) => {
   const {
-    config: { enableMappingsSourceField },
+    config: { enableMappingsSourceFieldSection },
   } = useAppContext();
 
   const isMounted = useRef(false);
@@ -164,7 +164,7 @@ export const ConfigurationForm = React.memo(({ value, esNodesPlugins }: Props) =
       <EuiSpacer size="xl" />
       <MetaFieldSection />
       <EuiSpacer size="xl" />
-      {enableMappingsSourceField && (
+      {enableMappingsSourceFieldSection && (
         <>
           <SourceFieldSection /> <EuiSpacer size="xl" />
         </>

diff --git a/x-pack/plugins/index_management/public/plugin.ts b/x-pack/plugins/index_management/public/plugin.ts
@@ -44,7 +44,7 @@ export class IndexMgmtUIPlugin
     editableIndexSettings: 'all' | 'limited';
     enableDataStreamsStorageColumn: boolean;
     isIndexManagementUiEnabled: boolean;
-    enableMappingsSourceField: boolean;
+    enableMappingsSourceFieldSection: boolean;
   };
 
   constructor(ctx: PluginInitializerContext) {
@@ -59,7 +59,7 @@ export class IndexMgmtUIPlugin
       enableIndexStats,
       editableIndexSettings,
       enableDataStreamsStorageColumn,
-      enableMappingsSourceField,
+      enableMappingsSourceFieldSection,
     } = ctx.config.get<ClientConfigType>();
     this.config = {
       isIndexManagementUiEnabled,
@@ -68,7 +68,7 @@ export class IndexMgmtUIPlugin
       enableIndexStats: enableIndexStats ?? true,
       editableIndexSettings: editableIndexSettings ?? 'all',
       enableDataStreamsStorageColumn: enableDataStreamsStorageColumn ?? true,
-      enableMappingsSourceField: enableMappingsSourceField ?? true,
+      enableMappingsSourceFieldSection: enableMappingsSourceFieldSection ?? true,
     };
   }
 

diff --git a/x-pack/plugins/index_management/public/types.ts b/x-pack/plugins/index_management/public/types.ts
@@ -39,5 +39,5 @@ export interface ClientConfigType {
   enableIndexStats?: boolean;
   editableIndexSettings?: 'all' | 'limited';
   enableDataStreamsStorageColumn?: boolean;
-  enableMappingsSourceField?: boolean;
+  enableMappingsSourceFieldSection?: boolean;
 }
diff --git a/x-pack/plugins/index_management/server/config.ts b/x-pack/plugins/index_management/server/config.ts
@@ -52,7 +52,7 @@ const schemaLatest = schema.object(
       // We take this approach in order to have a central place (serverless.yml) for serverless config across Kibana
       serverless: schema.boolean({ defaultValue: true }),
     }),
-    enableMappingsSourceField: offeringBasedSchema({
+    enableMappingsSourceFieldSection: offeringBasedSchema({
       // The _source field in the Mappings editor's advanced options form is disabled in serverless; refer to the serverless.yml file as the source of truth
       // We take this approach in order to have a central place (serverless.yml) for serverless config across Kibana
       serverless: schema.boolean({ defaultValue: true }),
@@ -69,7 +69,7 @@ const configLatest: PluginConfigDescriptor<IndexManagementConfig> = {
     enableIndexStats: true,
     editableIndexSettings: true,
     enableDataStreamsStorageColumn: true,
-    enableMappingsSourceField: true,
+    enableMappingsSourceFieldSection: true,
   },
   schema: schemaLatest,
   deprecations: ({ unused }) => [unused('dev.enableIndexDetailsPage', { level: 'warning' })],

diff --git a/x-pack/plugins/index_management/server/plugin.ts b/x-pack/plugins/index_management/server/plugin.ts
@@ -57,7 +57,7 @@ export class IndexMgmtServerPlugin implements Plugin<IndexManagementPluginSetup,
         isLegacyTemplatesEnabled: this.config.enableLegacyTemplates,
         isIndexStatsEnabled: this.config.enableIndexStats,
         isDataStreamsStorageColumnEnabled: this.config.enableDataStreamsStorageColumn,
-        enableMappingsSourceField: this.config.enableMappingsSourceField,
+        enableMappingsSourceFieldSection: this.config.enableMappingsSourceFieldSection,
       },
       indexDataEnricher: this.indexDataEnricher,
       lib: {

diff --git a/x-pack/plugins/index_management/server/types.ts b/x-pack/plugins/index_management/server/types.ts
@@ -26,7 +26,7 @@ export interface RouteDependencies {
     isLegacyTemplatesEnabled: boolean;
     isIndexStatsEnabled: boolean;
     isDataStreamsStorageColumnEnabled: boolean;
-    enableMappingsSourceField: boolean;
+    enableMappingsSourceFieldSection: boolean;
   };
   indexDataEnricher: IndexDataEnricher;
   lib: {