Adding clarifying comment and removing root controller

elastic · Jan 24, 2020 · 7f97c7f · 7f97c7f
1 parent 7de5b89
commit 7f97c7f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/x-pack/legacy/plugins/canvas/public/legacy.ts b/x-pack/legacy/plugins/canvas/public/legacy.ts
@@ -23,6 +23,9 @@ const shimCoreStart = {
   ...npStart.core,
 };
 const shimSetupPlugins = {
+  // When the frontend Canvas plugin is moved to NP, we can declare reporting as an optional dependency
+  // and enable exports based on existence of the plugin.
+  // For now, use an injected config to mimic this behavior in the meantime.
   reporting: npSetup.core.injectedMetadata.getInjectedVar('reportingBrowserType') ? {} : undefined,
 };
 
@@ -34,8 +37,6 @@ const shimStartPlugins: CanvasStartDeps = {
     // ToDo: Copy directly into canvas
     formatMsg,
     QueryString,
-    // ToDo: Remove in favor of core.application.register
-    setRootController: chrome.setRootController,
     storage: Storage,
     // ToDo: Won't be a part of New Platform. Will need to handle internally
     trackSubUrlForApp: chrome.trackSubUrlForApp,

diff --git a/x-pack/legacy/plugins/canvas/public/plugin.tsx b/x-pack/legacy/plugins/canvas/public/plugin.tsx
@@ -43,7 +43,6 @@ export interface CanvasStartDeps {
     absoluteToParsedUrl: (url: string, basePath: string) => any;
     formatMsg: any;
     QueryString: any;
-    setRootController: Chrome['setRootController'];
     storage: typeof Storage;
     trackSubUrlForApp: Chrome['trackSubUrlForApp'];
   };