Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
nreese committed Mar 31, 2021
1 parent 9aaec81 commit 7cc8b81
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 16 deletions.
20 changes: 9 additions & 11 deletions docs/maps/import-geospatial-data.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,15 @@ spaces in the **{stack-manage-app}** in {kib}. For more information, see
<<kibana-privileges, {kib} privileges>>, and <<xpack-kibana-role-management, {kib} role management>>.

To upload GeoJSON files in {kib} with *Maps*, you must have:
* [ ] `all` {kib}
privilege for the `Maps` feature
* [ ] `all` {kib}
privilege for the `Index Pattern Management` feature
* [ ] `create` and `create_index` index privileges for destination indices.
To use the index in Maps, you must also have `read` and `view_index_metadata` index privileges.

To upload CSV files in {kib} with the *{file-data-viz}*, in addition to upload GeoJson privileges, to you must have:
* [ ] `manage_pipeline` cluster privilege
* [ ] `read` {kib} privilege for the `Machine Learning` feature
* [ ] `machine_learning_admin` or `machine_learning_user` role
* `all` {kib} privilege for `Maps`
* `all` {kib} privilege for `Index Pattern Management`
* `create` and `create_index` index privileges for destination indices.
* To use the index in Maps, you must also have `read` and `view_index_metadata` index privileges for destination indices.

To upload CSV files in {kib} with the *{file-data-viz}*, you must have privileges to upload GeoJSON files and:
* `manage_pipeline` cluster privilege
* `read` {kib} privilege for `Machine Learning`
* `machine_learning_admin` or `machine_learning_user` role


[discrete]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class ImportCompleteView extends Component<Props, {}> {
return (
<EuiCallOut
title={i18n.translate('xpack.fileUpload.uploadFailureTitle', {
defaultMessage: 'File upload failed',
defaultMessage: 'Unable to upload file',
})}
color="danger"
iconType="alert"
Expand All @@ -115,7 +115,7 @@ export class ImportCompleteView extends Component<Props, {}> {
external
>
{i18n.translate('xpack.fileUpload.permission.docLink', {
defaultMessage: 'View file import permissions.',
defaultMessage: 'View file import permissions',
})}
</EuiLink>
</EuiCallOut>
Expand All @@ -133,7 +133,7 @@ export class ImportCompleteView extends Component<Props, {}> {
return (
<EuiCallOut
title={i18n.translate('xpack.fileUpload.uploadFailureTitle', {
defaultMessage: 'File upload failed',
defaultMessage: 'Unable to upload file',
})}
color="danger"
iconType="alert"
Expand Down Expand Up @@ -181,7 +181,7 @@ export class ImportCompleteView extends Component<Props, {}> {
<p>
<FormattedMessage
id="xpack.fileUpload.jsonImport.indexModsMsg"
defaultMessage="Further index modifications can be made using "
defaultMessage="To modify the index, go to "
/>
<a
data-test-subj="indexManagementNewIndexLink"
Expand All @@ -190,7 +190,7 @@ export class ImportCompleteView extends Component<Props, {}> {
>
<FormattedMessage
id="xpack.fileUpload.jsonImport.indexMgmtLink"
defaultMessage="Index Management"
defaultMessage="Index Management."
/>
</a>
</p>
Expand Down

0 comments on commit 7cc8b81

Please sign in to comment.