Merge remote-tracking branch 'upstream/master' into fix-transform-clo…

…ne-fields

.ci/Jenkinsfile_coverage

@@ -12,8 +12,12 @@ kibanaPipeline(timeoutMinutes: 240) {
     ]) {
       workers.base(name: 'coverage-worker', size: 'l', ramDisk: false, bootstrapped: false) {
         catchError {
+
+          kibanaPipeline.bash("""
+            echo '${TIME_STAMP}'
+          """, "### Print Canonical Time Stamp")
+
           kibanaCoverage.runTests()
-          kibanaTeamAssign.load('team_assignment', "### Upload Team Assignment JSON")
           handleIngestion(TIME_STAMP)
         }
         handleFail()
@@ -30,7 +34,7 @@ def handleIngestion(timestamp) {
   kibanaCoverage.collectVcsInfo("### Collect VCS Info")
   kibanaCoverage.generateReports("### Merge coverage reports")
   kibanaCoverage.uploadCombinedReports()
-  kibanaCoverage.ingest(env.JOB_NAME, BUILD_NUMBER, BUILD_URL, timestamp, previousSha, '### Ingest && Upload')
+  kibanaCoverage.ingest(env.JOB_NAME, BUILD_NUMBER, BUILD_URL, timestamp, previousSha, teamAssignmentsPath(), '### Generate Team Assignments && Ingest')
   kibanaCoverage.uploadCoverageStaticSite(timestamp)
 }
 
@@ -42,11 +46,15 @@ def handlePreviousSha() {
 
 def handleFail() {
   def buildStatus = buildUtils.getBuildStatus()
-  if(params.NOTIFY_ON_FAILURE && buildStatus != 'SUCCESS' && buildStatus != 'ABORTED' && buildStatus != 'UNSTABLE') {
+  if (params.NOTIFY_ON_FAILURE && buildStatus != 'SUCCESS' && buildStatus != 'ABORTED' && buildStatus != 'UNSTABLE') {
     slackNotifications.sendFailedBuild(
       channel: '#kibana-qa',
       username: 'Kibana QA'
     )
   }
 }
 
+def teamAssignmentsPath() {
+  return 'src/dev/code_coverage/ingest_coverage/team_assignment/team_assignments.txt'
+}
+

.eslintrc.js

@@ -1229,5 +1229,20 @@ module.exports = {
         '@typescript-eslint/prefer-ts-expect-error': 'error',
       },
     },
+    {
+      files: [
+        '**/public/**/*.{js,mjs,ts,tsx}',
+        '**/common/**/*.{js,mjs,ts,tsx}',
+        'packages/**/*.{js,mjs,ts,tsx}',
+      ],
+      rules: {
+        'no-restricted-imports': [
+          'error',
+          {
+            patterns: ['lodash/*', '!lodash/fp'],
+          },
+        ],
+      },
+    },
   ],
 };

.github/CODEOWNERS

@@ -2,6 +2,9 @@
 # Identify which groups will be pinged by changes to different parts of the codebase.
 # For more info, see https://help.github.com/articles/about-codeowners/
 
+# The #CC# prefix delineates Code Coverage,
+# used for the 'team' designator within Kibana Stats
+
 # App
 /x-pack/plugins/dashboard_enhanced/ @elastic/kibana-app
 /x-pack/plugins/discover_enhanced/ @elastic/kibana-app
@@ -25,6 +28,34 @@
 /src/plugins/vis_type_vislib/ @elastic/kibana-app
 /src/plugins/vis_type_xy/ @elastic/kibana-app
 /src/plugins/visualize/ @elastic/kibana-app
+/src/plugins/visualizations/ @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/public/local_application_service/ @elastic/kibana-app
+#CC# /src/plugins/vis_type @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/ @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/common/utils @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/migrations @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/public @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/public/dev_tools/ @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/public/discover/ @elastic/kibana-app
+#CC# /src/legacy/core_plugins/kibana/public/local_application_service/ @elastic/kibana-app
+#CC# /src/legacy/core_plugins/console_legacy @elastic/kibana-app
+#CC# /src/legacy/core_plugins/input_control_vis @elastic/kibana-app
+#CC# /src/legacy/core_plugins/timelion @elastic/kibana-app
+#CC# /src/legacy/core_plugins/vis_type_tagcloud @elastic/kibana-app
+#CC# /src/legacy/core_plugins/vis_type_vega @elastic/kibana-app
+#CC# /src/legacy/core_plugins/vis_type_vislib/ @elastic/kibana-app
+#CC# /src/legacy/server/sample_data/ @elastic/kibana-app
+#CC# /src/legacy/server/url_shortening/ @elastic/kibana-app
+#CC# /src/legacy/ui/public/state_management @elastic/kibana-app
+#CC# /src/plugins/charts/public/static/color_maps @elastic/kibana-app
+#CC# /src/plugins/index_pattern_management/public @elastic/kibana-app
+#CC# /src/plugins/input_control_vis/ @elastic/kibana-app
+#CC# /src/plugins/kibana_legacy/ @elastic/kibana-app
+#CC# /src/plugins/timelion @elastic/kibana-app
+#CC# /x-pack/legacy/plugins/dashboard_mode/ @elastic/kibana-app
+#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-app
+#CC# /x-pack/plugins/lens/ @elastic/kibana-app
 
 # App Architecture
 /examples/bfetch_explorer/ @elastic/kibana-app-arch
@@ -51,17 +82,41 @@
 /src/plugins/navigation/ @elastic/kibana-app-arch
 /src/plugins/share/ @elastic/kibana-app-arch
 /src/plugins/ui_actions/ @elastic/kibana-app-arch
-/src/plugins/visualizations/ @elastic/kibana-app-arch
 /x-pack/examples/ui_actions_enhanced_examples/ @elastic/kibana-app-arch
 /x-pack/plugins/data_enhanced/ @elastic/kibana-app-arch
 /x-pack/plugins/embeddable_enhanced/ @elastic/kibana-app-arch
 /x-pack/plugins/ui_actions_enhanced/ @elastic/kibana-app-arch
+#CC# /src/legacy/core_plugins/kibana/public/management/ @elastic/kibana-app-arch
+#CC# /src/legacy/core_plugins/kibana/server/routes/api/management/ @elastic/kibana-app-arch
+#CC# /src/legacy/core_plugins/embeddable_api/ @elastic/kibana-app-arch
+#CC# /src/legacy/core_plugins/interpreter/ @elastic/kibana-app-arch
+#CC# /src/legacy/core_plugins/kibana_react/ @elastic/kibana-app-arch
+#CC# /src/legacy/core_plugins/status_page/public @elastic/kibana-app-arch
+#CC# /src/legacy/server/index_patterns/ @elastic/kibana-app-arch
+#CC# /src/legacy/ui/public/field_editor @elastic/kibana-app-arch
+#CC# /src/legacy/ui/public/management @elastic/kibana-app-arch
+#CC# /src/plugins/advanced_settings/ @elastic/kibana-app-arch
+#CC# /src/plugins/bfetch/ @elastic/kibana-app-arch
+#CC# /src/plugins/charts/ @elastic/kibana-app-arch
+#CC# /src/plugins/index_pattern_management/public/service @elastic/kibana-app-arch
+#CC# /src/plugins/inspector/ @elastic/kibana-app-arch
+#CC# /src/plugins/saved_objects/ @elastic/kibana-app-arch
+#CC# /src/plugins/share/ @elastic/kibana-app-arch
+#CC# /src/plugins/vis_default_editor @elastic/kibana-app-arch
+#CC# /x-pack/plugins/advanced_ui_actions/ @elastic/kibana-app-arch
+#CC# /x-pack/plugins/drilldowns/ @elastic/kibana-app-arch
+#CC# /packages/kbn-interpreter/ @elastic/kibana-app-arch
 
 # APM
 /x-pack/plugins/apm/  @elastic/apm-ui
 /x-pack/test/functional/apps/apm/  @elastic/apm-ui
 /src/plugins/apm_oss/  @elastic/apm-ui
 /src/apm.js @watson @vigneshshanmugam
+#CC# /src/plugins/apm_oss/ @elastic/apm-ui
+#CC# /src/legacy/core_plugins/apm_oss/ @elastic/apm-ui
+#CC# /src/legacy/ui/public/apm @elastic/apm-ui
+#CC# /x-pack/legacy/plugins/apm/ @elastic/apm-ui
+#CC# /x-pack/plugins/observability/ @elastic/apm-ui
 
 # Client Side Monitoring (lives in APM directories but owned by Uptime)
 /x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm @elastic/uptime
@@ -71,20 +126,32 @@
 /x-pack/plugins/apm/server/lib/rum_client @elastic/uptime
 /x-pack/plugins/apm/server/routes/rum_client.ts @elastic/uptime
 /x-pack/plugins/apm/server/projections/rum_page_load_transactions.ts @elastic/uptime
+/x-pack/plugins/apm/server/projections/rum_overview.ts @elastic/uptime
+#CC# /x-pack/legacy/plugins/uptime @elastic/uptime
 
 # Beats
 /x-pack/plugins/beats_management/  @elastic/beats
+/x-pack/legacy/plugins/beats_management/  @elastic/beats
+#CC# /x-pack/plugins/beats_management/ @elastic/beats
 
 # Canvas
 /x-pack/plugins/canvas/  @elastic/kibana-canvas
 /x-pack/test/functional/apps/canvas/  @elastic/kibana-canvas
+#CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-canvas
+#CC# /x-pack/legacy/plugins/canvas/ @elastic/kibana-canvas
 
 # Core UI
 # Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon
 /src/plugins/home/public @elastic/kibana-core-ui
 /src/plugins/home/server/*.ts @elastic/kibana-core-ui
 /src/plugins/home/server/services/ @elastic/kibana-core-ui
 /x-pack/plugins/global_search_bar/ @elastic/kibana-core-ui
+#CC# /src/legacy/core_plugins/newsfeed @elastic/kibana-core-ui
+#CC# /src/plugins/newsfeed @elastic/kibana-core-ui
+#CC# /src/plugins/home/public @elastic/kibana-core-ui
+#CC# /src/plugins/home/server/services/ @elastic/kibana-core-ui
+#CC# /src/plugins/home/ @elastic/kibana-core-ui
+#CC# /x-pack/plugins/global_search_providers/ @elastic/kibana-core-ui
 
 # Observability UIs
 /x-pack/plugins/infra/ @elastic/logs-metrics-ui
@@ -110,6 +177,14 @@
 /x-pack/test/functional/apps/maps/ @elastic/kibana-gis
 /x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis
 /x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis
+#CC# /src/legacy/core_plugins/region_map @elastic/kibana-gis
+#CC# /src/legacy/core_plugins/tile_map @elastic/kibana-gis
+#CC# /src/plugins/maps_legacy/ @elastic/kibana-gis
+#CC# /x-pack/plugins/file_upload @elastic/kibana-gis
+#CC# /x-pack/plugins/maps_legacy_licensing @elastic/kibana-gis
+#CC# /src/plugins/home/server/tutorials @elastic/kibana-gis
+#CC# /src/plugins/tile_map/ @elastic/kibana-gis
+#CC# /src/plugins/region_map/ @elastic/kibana-gis
 
 # Operations
 /src/dev/ @elastic/kibana-operations
@@ -132,6 +207,7 @@
 /src/legacy/server/warnings/ @elastic/kibana-operations
 /.ci/es-snapshots/ @elastic/kibana-operations
 /vars/ @elastic/kibana-operations
+#CC# /packages/kbn-expect/ @elastic/kibana-operations
 
 # Quality Assurance
 /src/dev/code_coverage @elastic/kibana-qa
@@ -158,6 +234,31 @@
 /src/plugins/status_page/ @elastic/kibana-platform
 /src/plugins/saved_objects_management/ @elastic/kibana-platform
 /src/dev/run_check_published_api_changes.ts @elastic/kibana-platform
+#CC# /src/core/server/csp/ @elastic/kibana-platform
+#CC# /src/legacy/core_plugins/kibana/server/lib @elastic/kibana-platform
+#CC# /src/legacy/core_plugins/kibana/server/lib/management/saved_objects @elastic/kibana-platform
+#CC# /src/legacy/core_plugins/kibana/server/routes/api/import/ @elastic/kibana-platform
+#CC# /src/legacy/core_plugins/kibana/server/routes/api/export/ @elastic/kibana-platform
+#CC# /src/legacy/core_plugins/elasticsearch @elastic/kibana-platform
+#CC# /src/legacy/core_plugins/testbed @elastic/kibana-platform
+#CC# /src/legacy/server/config/ @elastic/kibana-platform
+#CC# /src/legacy/server/http/ @elastic/kibana-platform
+#CC# /src/legacy/server/status/ @elastic/kibana-platform
+#CC# /src/legacy/ui/public/new_platform @elastic/kibana-platform
+#CC# /src/legacy/ui/public/plugin_discovery @elastic/kibana-platform
+#CC# /src/legacy/ui/public/chrome @elastic/kibana-platform
+#CC# /src/legacy/ui/public/notify @elastic/kibana-platform
+#CC# /src/legacy/ui/public/documentation_links @elastic/kibana-platform
+#CC# /src/legacy/ui/public/autoload @elastic/kibana-platform
+#CC# /src/plugins/legacy_export/ @elastic/kibana-platform
+#CC# /src/plugins/status_page/ @elastic/kibana-platform
+#CC# /src/plugins/testbed/server/ @elastic/kibana-platform
+#CC# /x-pack/legacy/plugins/xpack_main/server/ @elastic/kibana-platform
+#CC# /x-pack/legacy/server/lib/ @elastic/kibana-platform
+#CC# /x-pack/plugins/cloud/ @elastic/kibana-platform
+#CC# /x-pack/plugins/features/ @elastic/kibana-platform
+#CC# /x-pack/plugins/global_search/ @elastic/kibana-platform
+#CC# /src/legacy/plugin_discovery/ @elastic/kibana-platform
 
 # Security
 /src/core/server/csp/  @elastic/kibana-security @elastic/kibana-platform
@@ -177,12 +278,19 @@
 /x-pack/test/security_functional/ @elastic/kibana-security
 /x-pack/test/spaces_api_integration/ @elastic/kibana-security
 /x-pack/test/token_api_integration/ @elastic/kibana-security
+#CC# /src/legacy/ui/public/capabilities @elastic/kibana-security
+#CC# /x-pack/legacy/plugins/encrypted_saved_objects/ @elastic/kibana-security
+#CC# /x-pack/plugins/security_solution/ @elastic/kibana-security
+#CC# /x-pack/plugins/security/ @elastic/kibana-security
+#CC# /x-pack/plugins/audit_trail/ @elastic/kibana-security
 
 # Kibana Localization
 /src/dev/i18n/  @elastic/kibana-localization
 /src/legacy/server/i18n/  @elastic/kibana-localization
 /src/core/public/i18n/  @elastic/kibana-localization
 /packages/kbn-i18n/  @elastic/kibana-localization
+#CC# /src/legacy/server/i18n/ @elastic/kibana-localization
+#CC# /x-pack/plugins/translations/ @elastic/kibana-localization
 
 # Kibana Telemetry
 /packages/kbn-analytics/ @elastic/kibana-telemetry
@@ -211,6 +319,11 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
 /x-pack/plugins/triggers_actions_ui/ @elastic/kibana-alerting-services
 /x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/ @elastic/kibana-alerting-services
 /x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/ @elastic/kibana-alerting-services
+#CC# /x-pack/legacy/plugins/actions/ @elastic/kibana-alerting-services
+#CC# /x-pack/legacy/plugins/alerting/ @elastic/kibana-alerting-services
+#CC# /x-pack/legacy/plugins/task_manager @elastic/kibana-alerting-services
+#CC# /x-pack/legacy/plugins/triggers_actions_ui/ @elastic/kibana-alerting-services
+#CC# /x-pack/plugins/alerting_builtins @elastic/kibana-alerting-services
 
 # Enterprise Search
 # Shared
@@ -246,6 +359,14 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
 /x-pack/plugins/upgrade_assistant/  @elastic/es-ui
 /x-pack/plugins/watcher/  @elastic/es-ui
 /x-pack/plugins/ingest_pipelines/  @elastic/es-ui
+/packages/kbn-ace/ @elastic/es-ui
+/packages/kbn-monaco/ @elastic/es-ui
+#CC# /x-pack/legacy/plugins/rollup/ @elastic/es-ui
+#CC# /x-pack/legacy/server/lib/create_router/ @elastic/es-ui
+#CC# /x-pack/legacy/server/lib/check_license/ @elastic/es-ui
+#CC# /x-pack/plugins/console_extensions/ @elastic/es-ui
+#CC# /x-pack/plugins/cross_cluster_replication/ @elastic/es-ui
+#CC# /x-pack/plugins/es_ui_shared/ @elastic/es-u
 
 # Endpoint
 /x-pack/plugins/endpoint/ @elastic/endpoint-app-team @elastic/siem
@@ -255,6 +376,9 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
 /x-pack/test/functional/es_archives/endpoint/ @elastic/endpoint-app-team @elastic/siem
 /x-pack/test/plugin_functional/plugins/resolver_test/ @elastic/endpoint-app-team @elastic/siem
 /x-pack/test/plugin_functional/test_suites/resolver/ @elastic/endpoint-app-team @elastic/siem
+#CC# /x-pack/legacy/plugins/siem/ @elastic/siem
+#CC# /x-pack/plugins/siem/ @elastic/siem
+#CC# /x-pack/plugins/security_solution/ @elastic/siem
 
 # Security Solution
 /x-pack/plugins/security_solution/ @elastic/siem @elastic/endpoint-app-team
@@ -269,6 +393,7 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
 
 # Design (at the bottom for specificity of SASS files)
 **/*.scss  @elastic/kibana-design
+#CC# /packages/kbn-ui-framework/ @elastic/kibana-design
 
 # Core design
 /src/plugins/dashboard/**/*.scss @elastic/kibana-core-ui-designers
@@ -290,3 +415,9 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
 /x-pack/plugins/endpoint/**/*.scss @elastic/security-design
 /x-pack/plugins/security_solution/**/*.scss @elastic/security-design
 
+# Logstash
+#CC# /x-pack/plugins/logstash/ @elastic/logstash
+
+# Reporting
+#CC# /x-pack/plugins/reporting/ @elastic/kibana-reporting-services
+

.telemetryrc.json

@@ -6,10 +6,7 @@
       "src/plugins/kibana_react/",
       "src/plugins/testbed/",
       "src/plugins/kibana_utils/",
-      "src/plugins/kibana_usage_collection/server/collectors/kibana/kibana_usage_collector.ts",
-      "src/plugins/kibana_usage_collection/server/collectors/management/telemetry_management_collector.ts",
-      "src/plugins/kibana_usage_collection/server/collectors/ui_metric/telemetry_ui_metric_collector.ts",
-      "src/plugins/telemetry/server/collectors/usage/telemetry_usage_collector.ts"
+      "src/plugins/kibana_usage_collection/server/collectors/ui_metric/telemetry_ui_metric_collector.ts"
     ]
   }
 ]

docs/api/saved-objects/create.asciidoc

@@ -13,7 +13,7 @@ experimental[] Create {kib} saved objects.
 
 `POST <kibana host>:<port>/api/saved_objects/<type>/<id>`
 
-`POST <kibana host>:<port>/s/<space_id>/api/saved_objects/<type>`
+`POST <kibana host>:<port>/s/<space_id>/saved_objects/<type>`
 
 [[saved-objects-api-create-path-params]]
 ==== Path parameters

docs/canvas/canvas-edit-workpads.asciidoc

@@ -25,12 +25,12 @@ For example, to change the index pattern for a set of charts:
 Specify the variable options.
 
 [role="screenshot"]
-image::images/specify_variable_syntax.png[Specify the variable syntax]
+image::images/specify_variable_syntax.png[Image describing how to specify the variable syntax]
 
 Copy the variable, then apply it to each element you want to update in the *Expression editor*.
 
 [role="screenshot"]
-image::images/copy_variable_syntax.png[Copy the variable syntax]
+image::images/copy_variable_syntax.png[Image demonstrating expression editor]
 
 [float]
 [[apply-changes-to-the-entire-workpad]]
@@ -85,7 +85,7 @@ To use an element with the same functionality and appearance in multiple places,
 Select the element, then click *Edit > Clone*. 
 
 [role="screenshot"]
-image::images/clone_element.gif[Clone elements]
+image::images/clone_element.gif[Image showing how to clone elements]
 
 [float]
 [[move-and-resize-elements]]

docs/canvas/canvas-expression-lifecycle.asciidoc

@@ -30,7 +30,7 @@ The filtered <<demodata_fn, demo data>> becomes the _context_ of the next functi
 
 Let’s look at another expression, which uses the same <<demodata_fn, demodata>> function, but instead produces a pie chart.
 
-image::images/canvas-functions-can-take-arguments-pie-chart.png[Pie Chart, height=400]
+image::images/canvas-functions-can-take-arguments-pie-chart.png[Pie chart showing output of demodata function]
 [source,text]
 ----
 filters
@@ -47,7 +47,7 @@ If the expression stopped there, it would produce a `pointseries` data type as t
 The end result is a simple pie chart that uses the default color palette, but the <<pie_fn, pie>> function can take additional arguments that control how it gets rendered. For example, you can provide a `hole` argument to turn your pie chart into a donut chart by changing the expression to:
 
 
-image::images/canvas-functions-can-take-arguments-donut-chart.png[Donut Chart, height=400]
+image::images/canvas-functions-can-take-arguments-donut-chart.png[Alternative output as donut chart]
 [source,text]
 ----
 filters
@@ -83,7 +83,7 @@ You can substitute one function for another to change the output. For example, y
 
 Let’s change that last pie chart into a bubble chart by replacing the <<pie_fn, pie>> function with the <<plot_fn, plot>> function. This is possible because both functions can accept a `pointseries` data type as their _context_. Switching the functions will work, but it won’t produce a useful visualization on its own since you don’t have the x-axis and y-axis defined. You will also need to modify the <<pointseries_fn, pointseries>> function to change its output. In this case, you can change the `size` argument to `y`, so the maximum price values are plotted on the y-axis, and add an `x` argument using the `@timestamp` field in the data to plot those values over time. This leaves you with the following expression and produces a bubble chart showing the max price of each state over time:
 
-image::images/canvas-change-your-expression-chart.png[Bubble Chart, height=400]
+image::images/canvas-change-your-expression-chart.png[Bubble Chart, with price along x axis, and time along y axis]
 [source,text]
 ----
 filters
@@ -95,7 +95,7 @@ filters
 
 Similar to the <<pie_fn, pie>> function, the <<plot_fn, plot>> function takes arguments that control the design elements of the visualization. As one example, passing a `legend` argument with a value of `false` to the function will hide the legend on the chart.
 
-image::images/canvas-change-your-expression-chart-no-legend.png[Bubble Chart Without Legend, height=400]
+image::images/canvas-change-your-expression-chart-no-legend.png[Bubble Chart Without Legend]
 [source,text,subs=+quotes]
 ----
 filters