Skip to content

Commit

Permalink
Fix flaky tests (#175965)
Browse files Browse the repository at this point in the history
## Summary

These changes fix flaky alert assignments cypress tests:
- #173429
- #172520
- #172557

@MadameSheema mentioned that there were a lot of changes around login
functionality recently which could have fixed original issues. We agreed
that we will run a flaky test runner and if everything works fine we
would un-skip tests and monitor them after the merge.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ESS 97
times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5064)
- [Serverless 97
times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5052)
  • Loading branch information
e40pud authored Feb 7, 2024
1 parent cc00868 commit 7a8d819
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ import {
} from '../../../../../tasks/alert_assignments';
import { ALERTS_COUNT } from '../../../../../screens/alerts';

// Failing: See https://github.com/elastic/kibana/issues/173429
describe.skip('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@serverless'] }, () => {
describe('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@serverless'] }, () => {
before(() => {
cy.task('esArchiverLoad', { archiveName: 'auditbeat_multiple' });

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ import {
loadPageAs,
} from '../../../../../tasks/alert_assignments';

// FLAKY: https://github.com/elastic/kibana/issues/172557
describe.skip(
describe(
'Alert user assignment - Serverless Complete',
{
tags: ['@serverless'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ import {
loadPageAs,
} from '../../../../../tasks/alert_assignments';

// FLAKY: https://github.com/elastic/kibana/issues/172520
describe.skip(
describe(
'Alert user assignment - Serverless Essentials',
{
tags: ['@serverless'],
Expand Down

0 comments on commit 7a8d819

Please sign in to comment.