[Cases] Do not show deprecated callout on deleted connectors (#116615) (

#116912) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Christos Nasikas <[email protected]>
elastic · Nov 1, 2021 · 7986541 · 7986541
1 parent a2c77e1
commit 7986541
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 5 deletions.
diff --git a/x-pack/plugins/cases/public/components/utils.test.ts b/x-pack/plugins/cases/public/components/utils.test.ts
@@ -7,7 +7,7 @@
 
 import { actionTypeRegistryMock } from '../../../triggers_actions_ui/public/application/action_type_registry.mock';
 import { triggersActionsUiMock } from '../../../triggers_actions_ui/public/mocks';
-import { getConnectorIcon } from './utils';
+import { getConnectorIcon, isDeprecatedConnector } from './utils';
 
 describe('Utils', () => {
   describe('getConnectorIcon', () => {
@@ -37,4 +37,10 @@ describe('Utils', () => {
       expect(getConnectorIcon(mockTriggersActionsUiService, '.not-registered')).toBe('');
     });
   });
+
+  describe('isDeprecatedConnector', () => {
+    it('returns false if the connector is not defined', () => {
+      expect(isDeprecatedConnector()).toBe(false);
+    });
+  });
 });
diff --git a/x-pack/plugins/cases/public/components/utils.ts b/x-pack/plugins/cases/public/components/utils.ts
@@ -80,7 +80,7 @@ export const getConnectorIcon = (
 // TODO: Remove when the applications are certified
 export const isDeprecatedConnector = (connector?: CaseActionConnector): boolean => {
   if (connector == null) {
-    return true;
+    return false;
   }
 
   if (!ENABLE_NEW_SN_ITSM_CONNECTOR && connector.actionTypeId === '.servicenow') {

diff --git a/..._actions_ui/public/application/components/builtin_action_types/servicenow/helpers.test.ts b/..._actions_ui/public/application/components/builtin_action_types/servicenow/helpers.test.ts
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { isRESTApiError, isFieldInvalid } from './helpers';
+import { isRESTApiError, isFieldInvalid, isDeprecatedConnector } from './helpers';
 
 describe('helpers', () => {
   describe('isRESTApiError', () => {
@@ -48,4 +48,10 @@ describe('helpers', () => {
       expect(isFieldInvalid('description', [])).toBeFalsy();
     });
   });
+
+  describe('isDeprecatedConnector', () => {
+    it('returns false if the connector is not defined', () => {
+      expect(isDeprecatedConnector()).toBe(false);
+    });
+  });
 });
diff --git a/...ggers_actions_ui/public/application/components/builtin_action_types/servicenow/helpers.ts b/...ggers_actions_ui/public/application/components/builtin_action_types/servicenow/helpers.ts
@@ -28,9 +28,9 @@ export const isFieldInvalid = (
 ): boolean => error !== undefined && error.length > 0 && field != null;
 
 // TODO: Remove when the applications are certified
-export const isDeprecatedConnector = (connector: ServiceNowActionConnector): boolean => {
+export const isDeprecatedConnector = (connector?: ServiceNowActionConnector): boolean => {
   if (connector == null) {
-    return true;
+    return false;
   }
 
   if (!ENABLE_NEW_SN_ITSM_CONNECTOR && connector.actionTypeId === '.servicenow') {