[Uptime] Unskip certs func tests (#73086) (#73957)

* Temporarily unload all other functional tests. * Unskip certificates test. * Uncomment skipped test files. * Add explicit fields to check generator call to prevent grouping issues that can lead to test flakiness. * added wait for loading * update missing func Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
elastic · Aug 6, 2020 · 78419d0 · 78419d0
1 parent ed08468
commit 78419d0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/x-pack/test/functional/apps/uptime/certificates.ts b/x-pack/test/functional/apps/uptime/certificates.ts
@@ -57,6 +57,15 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         const certId = getSha256();
         const { monitorId } = await makeCheck({
           es,
+          monitorId: 'cert-test-check-id',
+          fields: {
+            monitor: {
+              name: 'Cert Test Check',
+            },
+            url: {
+              full: 'https://site-to-check.com/',
+            },
+          },
           tls: {
             sha256: certId,
           },

diff --git a/x-pack/test/functional/apps/uptime/index.ts b/x-pack/test/functional/apps/uptime/index.ts
@@ -55,6 +55,7 @@ export default ({ loadTestFile, getService }: FtrProviderContext) => {
       loadTestFile(require.resolve('./settings'));
       loadTestFile(require.resolve('./certificates'));
     });
+
     describe('with real-world data', () => {
       before(async () => {
         await esArchiver.unload(ARCHIVE);

diff --git a/x-pack/test/functional/services/uptime/certificates.ts b/x-pack/test/functional/services/uptime/certificates.ts
@@ -7,10 +7,12 @@
 import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../ftr_provider_context';
 
-export function UptimeCertProvider({ getService }: FtrProviderContext) {
+export function UptimeCertProvider({ getService, getPageObjects }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
   const retry = getService('retry');
 
+  const PageObjects = getPageObjects(['common', 'timePicker', 'header']);
+
   const changeSearchField = async (text: string) => {
     const input = await testSubjects.find('uptimeCertSearch');
     await input.clearValueWithKeyboard();
@@ -61,6 +63,7 @@ export function UptimeCertProvider({ getService }: FtrProviderContext) {
       const self = this;
       return retry.tryForTime(60 * 1000, async () => {
         await changeSearchField(monId);
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await self.hasCertificates(1);
       });
     },