Skip to content

Commit

Permalink
Revert "disable save button if visualization is dirty (#11576)" (#12152)
Browse files Browse the repository at this point in the history
This reverts commit efc6218.
  • Loading branch information
thomasneirynck authored Jun 12, 2017
1 parent fe1ca5d commit 781a7b5
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 74 deletions.
8 changes: 0 additions & 8 deletions src/core_plugins/kibana/public/visualize/editor/editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,6 @@ function VisEditor($rootScope, $scope, $route, timefilter, AppState, $window, kb
description: 'Save Visualization',
template: require('plugins/kibana/visualize/editor/panels/save.html'),
testId: 'visualizeSaveButton',
disableButton() {
return Boolean(editableVis.dirty);
},
tooltip() {
if (editableVis.dirty) {
return 'Apply or Discard your changes before saving';
}
}
}, {
key: 'share',
description: 'Share Visualization',
Expand Down
59 changes: 0 additions & 59 deletions test/functional/apps/visualize/_editor.js

This file was deleted.

1 change: 0 additions & 1 deletion test/functional/apps/visualize/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default function ({ getService, loadTestFile }) {
});
});

loadTestFile(require.resolve('./_editor'));
loadTestFile(require.resolve('./_chart_types'));
loadTestFile(require.resolve('./_gauge_chart'));
loadTestFile(require.resolve('./_area_chart'));
Expand Down
6 changes: 0 additions & 6 deletions test/functional/page_objects/visualize_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,6 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
}


async isSaveButtonEnabled() {
const saveButton = await testSubjects.find('visualizeSaveButton');
const clazz = await saveButton.getProperty('className');
return clazz.indexOf('kuiLocalMenuItem-isDisabled') === -1;
}

saveVisualization(vizName) {
return testSubjects.click('visualizeSaveButton')
.then(() => {
Expand Down

0 comments on commit 781a7b5

Please sign in to comment.