[Lens] Add retry and remove unused test (#93233)

elastic · Mar 3, 2021 · 73f8b33 · 73f8b33
1 parent 6467afa
commit 73f8b33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 41 deletions.
diff --git a/x-pack/test/functional/apps/lens/smokescreen.ts b/x-pack/test/functional/apps/lens/smokescreen.ts
@@ -12,7 +12,6 @@ import { FtrProviderContext } from '../../ftr_provider_context';
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const PageObjects = getPageObjects(['visualize', 'lens', 'common', 'header']);
   const find = getService('find');
-  const retry = getService('retry');
   const listingTable = getService('listingTable');
   const testSubjects = getService('testSubjects');
   const elasticChart = getService('elasticChart');
@@ -600,42 +599,5 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
       expect(await testSubjects.isEnabled('lnsApp_downloadCSVButton')).to.eql(true);
     });
-
-    it('should able to sort a table by a column', async () => {
-      await PageObjects.visualize.gotoVisualizationLandingPage();
-      await listingTable.searchForItemWithName('lnsXYvis');
-      await PageObjects.lens.clickVisualizeListItemTitle('lnsXYvis');
-      await PageObjects.lens.goToTimeRange();
-      await PageObjects.lens.switchToVisualization('lnsDatatable');
-      // Sort by number
-      await PageObjects.lens.changeTableSortingBy(2, 'ascending');
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      expect(await PageObjects.lens.getDatatableCellText(0, 2)).to.eql('17,246');
-      // Now sort by IP
-      await PageObjects.lens.changeTableSortingBy(0, 'ascending');
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      expect(await PageObjects.lens.getDatatableCellText(0, 0)).to.eql('78.83.247.30');
-      // Change the sorting
-      await PageObjects.lens.changeTableSortingBy(0, 'descending');
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      expect(await PageObjects.lens.getDatatableCellText(0, 0)).to.eql('169.228.188.120');
-      // Remove the sorting
-      await PageObjects.lens.changeTableSortingBy(0, 'none');
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      expect(await PageObjects.lens.isDatatableHeaderSorted(0)).to.eql(false);
-    });
-
-    it('should able to use filters cell actions in table', async () => {
-      const firstCellContent = await PageObjects.lens.getDatatableCellText(0, 0);
-      await retry.try(async () => {
-        await PageObjects.lens.clickTableCellAction(0, 0, 'lensDatatableFilterOut');
-        await PageObjects.header.waitUntilLoadingHasFinished();
-        expect(
-          await find.existsByCssSelector(
-            `[data-test-subj*="filter-value-${firstCellContent}"][data-test-subj*="filter-negated"]`
-          )
-        ).to.eql(true);
-      });
-    });
   });
 }
diff --git a/x-pack/test/functional/apps/lens/table.ts b/x-pack/test/functional/apps/lens/table.ts
@@ -34,9 +34,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.header.waitUntilLoadingHasFinished();
       expect(await PageObjects.lens.getDatatableCellText(0, 0)).to.eql('169.228.188.120');
       // Remove the sorting
-      await PageObjects.lens.changeTableSortingBy(0, 'none');
-      await PageObjects.header.waitUntilLoadingHasFinished();
-      expect(await PageObjects.lens.isDatatableHeaderSorted(0)).to.eql(false);
+      await retry.try(async () => {
+        await PageObjects.lens.changeTableSortingBy(0, 'none');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        expect(await PageObjects.lens.isDatatableHeaderSorted(0)).to.eql(false);
+      });
     });
 
     it('should able to use filters cell actions in table', async () => {