-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ResponseOps][Cases] Add assignee user actions (#139392)
* Adding user actions for assignees * Fixing merge issues * Fixing test mock errors * Fixing display name errors and themselves * Fixing test for time being * Addressing feedback * Addressing comma and uniq feedback * Using core getUserDisplayName * Fixing import and removing flickering * Fixing tests Co-authored-by: Kibana Machine <[email protected]>
- Loading branch information
1 parent
939f52b
commit 72d0ee9
Showing
21 changed files
with
620 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
230 changes: 230 additions & 0 deletions
230
x-pack/plugins/cases/public/components/user_actions/assignees.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,230 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { EuiCommentList } from '@elastic/eui'; | ||
| import { render, screen } from '@testing-library/react'; | ||
|
|
||
| import { Actions } from '../../../common/api'; | ||
| import { elasticUser, getUserAction } from '../../containers/mock'; | ||
| import { TestProviders } from '../../common/mock'; | ||
| import { createAssigneesUserActionBuilder, shouldAddAnd, shouldAddComma } from './assignees'; | ||
| import { getMockBuilderArgs } from './mock'; | ||
|
|
||
| jest.mock('../../common/lib/kibana'); | ||
| jest.mock('../../common/navigation/hooks'); | ||
|
|
||
| describe('createAssigneesUserActionBuilder', () => { | ||
| describe('shouldAddComma', () => { | ||
| it('returns false if there are only 2 items', () => { | ||
| expect(shouldAddComma(0, 2)).toBeFalsy(); | ||
| }); | ||
|
|
||
| it('returns false it is the last items', () => { | ||
| expect(shouldAddComma(2, 3)).toBeFalsy(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('shouldAddAnd', () => { | ||
| it('returns false if there is only 1 item', () => { | ||
| expect(shouldAddAnd(0, 1)).toBeFalsy(); | ||
| }); | ||
|
|
||
| it('returns false it is not the last items', () => { | ||
| expect(shouldAddAnd(1, 3)).toBeFalsy(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('component', () => { | ||
| const builderArgs = getMockBuilderArgs(); | ||
|
|
||
| beforeEach(() => { | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('renders assigned users', () => { | ||
| const userAction = getUserAction('assignees', Actions.add, { | ||
| createdBy: { | ||
| // damaged_raccoon uid | ||
| profileUid: 'u_J41Oh6L9ki-Vo2tOogS8WRTENzhHurGtRc87NgEAlkc_0', | ||
| }, | ||
| }); | ||
| const builder = createAssigneesUserActionBuilder({ | ||
| ...builderArgs, | ||
| userAction, | ||
| }); | ||
|
|
||
| const createdUserAction = builder.build(); | ||
| render( | ||
| <TestProviders> | ||
| <EuiCommentList comments={createdUserAction} /> | ||
| </TestProviders> | ||
| ); | ||
|
|
||
| expect(screen.getByText('assigned')).toBeInTheDocument(); | ||
| expect(screen.getByText('themselves')).toBeInTheDocument(); | ||
| expect(screen.getByText('Physical Dinosaur')).toBeInTheDocument(); | ||
|
|
||
| expect(screen.getByTestId('ua-assignee-physical_dinosaur')).toContainElement( | ||
| screen.getByText('and') | ||
| ); | ||
| }); | ||
|
|
||
| it('renders assigned users with a comma', () => { | ||
| const userAction = getUserAction('assignees', Actions.add, { | ||
| createdBy: { | ||
| // damaged_raccoon uid | ||
| profileUid: 'u_J41Oh6L9ki-Vo2tOogS8WRTENzhHurGtRc87NgEAlkc_0', | ||
| }, | ||
| payload: { | ||
| assignees: [ | ||
| // These values map to uids in x-pack/plugins/cases/public/containers/user_profiles/api.mock.ts | ||
| { uid: 'u_J41Oh6L9ki-Vo2tOogS8WRTENzhHurGtRc87NgEAlkc_0' }, | ||
| { uid: 'u_A_tM4n0wPkdiQ9smmd8o0Hr_h61XQfu8aRPh9GMoRoc_0' }, | ||
| { uid: 'u_9xDEQqUqoYCnFnPPLq5mIRHKL8gBTo_NiKgOnd5gGk0_0' }, | ||
| ], | ||
| }, | ||
| }); | ||
| const builder = createAssigneesUserActionBuilder({ | ||
| ...builderArgs, | ||
| userAction, | ||
| }); | ||
|
|
||
| const createdUserAction = builder.build(); | ||
| render( | ||
| <TestProviders> | ||
| <EuiCommentList comments={createdUserAction} /> | ||
| </TestProviders> | ||
| ); | ||
|
|
||
| expect(screen.getByText('assigned')).toBeInTheDocument(); | ||
| expect(screen.getByText('themselves,')).toBeInTheDocument(); | ||
| expect(screen.getByText('Physical Dinosaur')).toBeInTheDocument(); | ||
|
|
||
| expect(screen.getByTestId('ua-assignee-physical_dinosaur')).toContainElement( | ||
| screen.getByText(',') | ||
| ); | ||
|
|
||
| expect(screen.getByText('Wet Dingo')).toBeInTheDocument(); | ||
| expect(screen.getByTestId('ua-assignee-wet_dingo')).toContainElement(screen.getByText('and')); | ||
| }); | ||
|
|
||
| it('renders unassigned users', () => { | ||
| const userAction = getUserAction('assignees', Actions.delete, { | ||
| createdBy: { | ||
| // damaged_raccoon uid | ||
| profileUid: 'u_J41Oh6L9ki-Vo2tOogS8WRTENzhHurGtRc87NgEAlkc_0', | ||
| }, | ||
| }); | ||
| const builder = createAssigneesUserActionBuilder({ | ||
| ...builderArgs, | ||
| userAction, | ||
| }); | ||
|
|
||
| const createdUserAction = builder.build(); | ||
| render( | ||
| <TestProviders> | ||
| <EuiCommentList comments={createdUserAction} /> | ||
| </TestProviders> | ||
| ); | ||
|
|
||
| expect(screen.getByText('unassigned')).toBeInTheDocument(); | ||
| expect(screen.getByText('themselves')).toBeInTheDocument(); | ||
| expect(screen.getByText('Physical Dinosaur')).toBeInTheDocument(); | ||
|
|
||
| expect(screen.getByTestId('ua-assignee-physical_dinosaur')).toContainElement( | ||
| screen.getByText('and') | ||
| ); | ||
| }); | ||
|
|
||
| it('renders a single assigned user', () => { | ||
| const userAction = getUserAction('assignees', Actions.add, { | ||
| payload: { | ||
| assignees: [ | ||
| // only render the physical dinosaur | ||
| { uid: 'u_A_tM4n0wPkdiQ9smmd8o0Hr_h61XQfu8aRPh9GMoRoc_0' }, | ||
| ], | ||
| }, | ||
| }); | ||
| const builder = createAssigneesUserActionBuilder({ | ||
| ...builderArgs, | ||
| userAction, | ||
| }); | ||
|
|
||
| const createdUserAction = builder.build(); | ||
| render( | ||
| <TestProviders> | ||
| <EuiCommentList comments={createdUserAction} /> | ||
| </TestProviders> | ||
| ); | ||
|
|
||
| expect(screen.getByText('Physical Dinosaur')).toBeInTheDocument(); | ||
| expect(screen.queryByText('themselves,')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('and')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders a single assigned user that is themselves using matching profile uids', () => { | ||
| const userAction = getUserAction('assignees', Actions.add, { | ||
| createdBy: { | ||
| ...elasticUser, | ||
| profileUid: 'u_J41Oh6L9ki-Vo2tOogS8WRTENzhHurGtRc87NgEAlkc_0', | ||
| }, | ||
| payload: { | ||
| assignees: [ | ||
| // only render the damaged raccoon which is the current user | ||
| { uid: 'u_J41Oh6L9ki-Vo2tOogS8WRTENzhHurGtRc87NgEAlkc_0' }, | ||
| ], | ||
| }, | ||
| }); | ||
| const builder = createAssigneesUserActionBuilder({ | ||
| ...builderArgs, | ||
| userAction, | ||
| }); | ||
|
|
||
| const createdUserAction = builder.build(); | ||
| render( | ||
| <TestProviders> | ||
| <EuiCommentList comments={createdUserAction} /> | ||
| </TestProviders> | ||
| ); | ||
|
|
||
| expect(screen.getByText('themselves')).toBeInTheDocument(); | ||
| expect(screen.queryByText('Physical Dinosaur')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('and')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders a single assigned user that is themselves using matching usernames', () => { | ||
| const userAction = getUserAction('assignees', Actions.add, { | ||
| createdBy: { | ||
| ...elasticUser, | ||
| username: 'damaged_raccoon', | ||
| }, | ||
| payload: { | ||
| assignees: [ | ||
| // only render the damaged raccoon which is the current user | ||
| { uid: 'u_J41Oh6L9ki-Vo2tOogS8WRTENzhHurGtRc87NgEAlkc_0' }, | ||
| ], | ||
| }, | ||
| }); | ||
| const builder = createAssigneesUserActionBuilder({ | ||
| ...builderArgs, | ||
| userAction, | ||
| }); | ||
|
|
||
| const createdUserAction = builder.build(); | ||
| render( | ||
| <TestProviders> | ||
| <EuiCommentList comments={createdUserAction} /> | ||
| </TestProviders> | ||
| ); | ||
|
|
||
| expect(screen.getByText('themselves')).toBeInTheDocument(); | ||
| expect(screen.queryByText('Physical Dinosaur')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('and')).not.toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.