Check response in Swimlane

elastic · Oct 20, 2021 · 6fd2cdc · 6fd2cdc
1 parent ce7df44
commit 6fd2cdc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/lib/axios_utils.ts b/x-pack/plugins/actions/server/builtin_action_types/lib/axios_utils.ts
@@ -86,9 +86,8 @@ export const throwIfRequestIsNotValid = ({
   requiredAttributesToBeInTheResponse?: string[];
 }) => {
   const requiredContentType = 'application/json';
-  const contentType = res.headers['content-type'];
+  const contentType = res.headers['content-type'] ?? '';
   const data = res.data;
-
   /**
    * This check ensures that the response is a valid JSON.
    * First we check that the content-type of the response is application/json.

diff --git a/x-pack/plugins/actions/server/builtin_action_types/swimlane/service.ts b/x-pack/plugins/actions/server/builtin_action_types/swimlane/service.ts
@@ -9,7 +9,7 @@ import { Logger } from '@kbn/logging';
 import axios from 'axios';
 
 import { ActionsConfigurationUtilities } from '../../actions_config';
-import { getErrorMessage, request } from '../lib/axios_utils';
+import { getErrorMessage, request, throwIfRequestIsNotValid } from '../lib/axios_utils';
 import { getBodyForEventAction } from './helpers';
 import {
   CreateCommentParams,
@@ -89,6 +89,12 @@ export const createExternalService = (
         method: 'post',
         url: getPostRecordUrl(appId),
       });
+
+      throwIfRequestIsNotValid({
+        res,
+        requiredAttributesToBeInTheResponse: ['id', 'name', 'createdDate'],
+      });
+
       return {
         id: res.data.id,
         title: res.data.name,
@@ -124,6 +130,11 @@ export const createExternalService = (
         url: getPostRecordIdUrl(appId, params.incidentId),
       });
 
+      throwIfRequestIsNotValid({
+        res,
+        requiredAttributesToBeInTheResponse: ['id', 'name', 'modifiedDate'],
+      });
+
       return {
         id: res.data.id,
         title: res.data.name,