Merge remote-tracking branch 'upstream/master' into testbed/move-to-oss

.eslintrc.js

@@ -50,7 +50,7 @@ const ELASTIC_LICENSE_HEADER = `
 `;
 
 const allMochaRulesOff = {};
-Object.keys(require('eslint-plugin-mocha').rules).forEach(k => {
+Object.keys(require('eslint-plugin-mocha').rules).forEach((k) => {
   allMochaRulesOff['mocha/' + k] = 'off';
 });
 
@@ -197,6 +197,11 @@ module.exports = {
                 from: ['src/core/utils/**/*'],
                 errorMessage: `Plugins may only import from src/core/server and src/core/public.`,
               },
+              {
+                target: ['(src|x-pack)/plugins/*/public/**/*'],
+                from: ['(src|x-pack)/plugins/*/server/**/*'],
+                errorMessage: `Public code can not import from server, use a common directory.`,
+              },
               {
                 target: [
                   '(src|x-pack)/legacy/**/*',

Gruntfile.js

@@ -19,7 +19,7 @@
 
 require('./src/setup_node_env');
 
-module.exports = function(grunt) {
+module.exports = function (grunt) {
   // set the config once before calling load-grunt-config
   // and once during so that we have access to it via
   // grunt.config.get() within the config files

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md

@@ -7,7 +7,7 @@
 <b>Signature:</b>
 
 ```typescript
-SearchBar: React.ComponentClass<Pick<Pick<SearchBarProps, "query" | "isLoading" | "filters" | "intl" | "indexPatterns" | "refreshInterval" | "customSubmitButton" | "screenTitle" | "dataTestSubj" | "showQueryBar" | "showQueryInput" | "showFilterBar" | "showDatePicker" | "showAutoRefreshOnly" | "isRefreshPaused" | "dateRangeFrom" | "dateRangeTo" | "showSaveQuery" | "savedQuery" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated" | "onClearSavedQuery" | "onRefresh" | "timeHistory" | "onFiltersUpdated" | "onRefreshChange">, "query" | "isLoading" | "filters" | "indexPatterns" | "refreshInterval" | "customSubmitButton" | "screenTitle" | "dataTestSubj" | "showQueryBar" | "showQueryInput" | "showFilterBar" | "showDatePicker" | "showAutoRefreshOnly" | "isRefreshPaused" | "dateRangeFrom" | "dateRangeTo" | "showSaveQuery" | "savedQuery" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated" | "onClearSavedQuery" | "onRefresh" | "timeHistory" | "onFiltersUpdated" | "onRefreshChange">, any> & {
-    WrappedComponent: React.ComponentType<Pick<SearchBarProps, "query" | "isLoading" | "filters" | "intl" | "indexPatterns" | "refreshInterval" | "customSubmitButton" | "screenTitle" | "dataTestSubj" | "showQueryBar" | "showQueryInput" | "showFilterBar" | "showDatePicker" | "showAutoRefreshOnly" | "isRefreshPaused" | "dateRangeFrom" | "dateRangeTo" | "showSaveQuery" | "savedQuery" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated" | "onClearSavedQuery" | "onRefresh" | "timeHistory" | "onFiltersUpdated" | "onRefreshChange"> & ReactIntl.InjectedIntlProps>;
+SearchBar: React.ComponentClass<Pick<Pick<SearchBarProps, "query" | "isLoading" | "filters" | "onRefresh" | "onRefreshChange" | "refreshInterval" | "intl" | "indexPatterns" | "customSubmitButton" | "screenTitle" | "dataTestSubj" | "showQueryBar" | "showQueryInput" | "showFilterBar" | "showDatePicker" | "showAutoRefreshOnly" | "isRefreshPaused" | "dateRangeFrom" | "dateRangeTo" | "showSaveQuery" | "savedQuery" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated" | "onClearSavedQuery" | "timeHistory" | "onFiltersUpdated">, "query" | "isLoading" | "filters" | "onRefresh" | "onRefreshChange" | "refreshInterval" | "indexPatterns" | "customSubmitButton" | "screenTitle" | "dataTestSubj" | "showQueryBar" | "showQueryInput" | "showFilterBar" | "showDatePicker" | "showAutoRefreshOnly" | "isRefreshPaused" | "dateRangeFrom" | "dateRangeTo" | "showSaveQuery" | "savedQuery" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated" | "onClearSavedQuery" | "timeHistory" | "onFiltersUpdated">, any> & {
+    WrappedComponent: React.ComponentType<Pick<SearchBarProps, "query" | "isLoading" | "filters" | "onRefresh" | "onRefreshChange" | "refreshInterval" | "intl" | "indexPatterns" | "customSubmitButton" | "screenTitle" | "dataTestSubj" | "showQueryBar" | "showQueryInput" | "showFilterBar" | "showDatePicker" | "showAutoRefreshOnly" | "isRefreshPaused" | "dateRangeFrom" | "dateRangeTo" | "showSaveQuery" | "savedQuery" | "onQueryChange" | "onQuerySubmit" | "onSaved" | "onSavedQueryUpdated" | "onClearSavedQuery" | "timeHistory" | "onFiltersUpdated"> & ReactIntl.InjectedIntlProps>;
 }
 ```

examples/alerting_example/public/alert_types/always_firing.tsx

@@ -71,7 +71,7 @@ export const AlwaysFiringExpression: React.FunctionComponent<AlwaysFiringParamsP
             <EuiFieldNumber
               name="instances"
               value={instances}
-              onChange={event => {
+              onChange={(event) => {
                 setAlertParams('instances', event.target.valueAsNumber);
               }}
             />

examples/alerting_example/public/alert_types/astros.tsx

@@ -51,7 +51,7 @@ interface PeopleinSpaceParamsProps {
 }
 
 function isValueInEnum(enumeratin: Record<string, any>, value: any): boolean {
-  return !!Object.values(enumeratin).find(enumVal => enumVal === value);
+  return !!Object.values(enumeratin).find((enumVal) => enumVal === value);
 }
 
 export function getAlertType(): AlertTypeModel {
@@ -139,7 +139,7 @@ export const PeopleinSpaceExpression: React.FunctionComponent<PeopleinSpaceParam
 
   const errorsCallout = flatten(
     Object.entries(errors).map(([field, errs]: [string, string[]]) =>
-      errs.map(e => (
+      errs.map((e) => (
         <p>
           <EuiTextColor color="accent">{field}:</EuiTextColor>`: ${errs}`
         </p>
@@ -189,7 +189,7 @@ export const PeopleinSpaceExpression: React.FunctionComponent<PeopleinSpaceParam
               <EuiSelect
                 compressed
                 value={craftTrigger.craft}
-                onChange={event => {
+                onChange={(event) => {
                   setAlertParams('craft', event.target.value);
                   setCraftTrigger({
                     craft: event.target.value,
@@ -238,7 +238,7 @@ export const PeopleinSpaceExpression: React.FunctionComponent<PeopleinSpaceParam
                   <EuiSelect
                     compressed
                     value={outerSpaceCapacityTrigger.op}
-                    onChange={event => {
+                    onChange={(event) => {
                       setAlertParams('op', event.target.value);
                       setOuterSpaceCapacity({
                         ...outerSpaceCapacityTrigger,
@@ -258,7 +258,7 @@ export const PeopleinSpaceExpression: React.FunctionComponent<PeopleinSpaceParam
                   <EuiFieldNumber
                     compressed
                     value={outerSpaceCapacityTrigger.outerSpaceCapacity}
-                    onChange={event => {
+                    onChange={(event) => {
                       setAlertParams('outerSpaceCapacity', event.target.valueAsNumber);
                       setOuterSpaceCapacity({
                         ...outerSpaceCapacityTrigger,

examples/alerting_example/server/alert_types/astros.ts

@@ -68,10 +68,7 @@ export const alertType: AlertType = {
 
     if (getOperator(op)(peopleInCraft.length, outerSpaceCapacity)) {
       peopleInCraft.forEach(({ craft, name }) => {
-        services
-          .alertInstanceFactory(name)
-          .replaceState({ craft })
-          .scheduleActions('default');
+        services.alertInstanceFactory(name).replaceState({ craft }).scheduleActions('default');
       });
     }
 

examples/bfetch_explorer/public/components/count_until/index.tsx

@@ -82,7 +82,7 @@ export const CountUntil: React.FC<Props> = ({ fetchStreaming }) => {
         <EuiFieldNumber
           placeholder="Some integer"
           value={data}
-          onChange={e => setData(Number(e.target.value))}
+          onChange={(e) => setData(Number(e.target.value))}
         />
       </EuiFormRow>
       <EuiButton type="submit" fill onClick={handleSubmit}>

examples/bfetch_explorer/public/components/double_integers/index.tsx

@@ -49,18 +49,18 @@ export const DoubleIntegers: React.FC<Props> = ({ double }) => {
     setShowingResults(true);
     const nums = numbers
       .split('\n')
-      .map(num => num.trim())
+      .map((num) => num.trim())
       .filter(Boolean)
       .map(Number);
     counter.set(nums.length);
-    nums.forEach(num => {
+    nums.forEach((num) => {
       double({ num }).then(
-        result => {
+        (result) => {
           if (!isMounted()) return;
           counter.dec();
           pushResult({ num, result });
         },
-        error => {
+        (error) => {
           if (!isMounted()) return;
           counter.dec();
           pushResult({ num, error });
@@ -94,7 +94,7 @@ export const DoubleIntegers: React.FC<Props> = ({ double }) => {
           fullWidth
           placeholder="Enter numbers in milliseconds separated by new line"
           value={numbers}
-          onChange={e => setNumbers(e.target.value)}
+          onChange={(e) => setNumbers(e.target.value)}
         />
       </EuiFormRow>
       <EuiButton type="submit" fill onClick={handleSubmit}>

examples/bfetch_explorer/public/containers/app/index.tsx

@@ -30,7 +30,7 @@ export const App: React.FC = () => {
   const routeElements: React.ReactElement[] = [];
   for (const { items } of routes) {
     for (const { id, component } of items) {
-      routeElements.push(<Route key={id} path={`/${id}`} render={props => component} />);
+      routeElements.push(<Route key={id} path={`/${id}`} render={(props) => component} />);
     }
   }
 

examples/bfetch_explorer/public/containers/app/sidebar/index.tsx

@@ -39,7 +39,7 @@ export const Sidebar: React.FC<SidebarProps> = () => {
               id,
               name: title,
               isSelected: true,
-              items: items.map(route => ({
+              items: items.map((route) => ({
                 id: route.id,
                 name: route.title,
                 onClick: () => history.push(`/${route.id}`),

examples/bfetch_explorer/server/plugin.ts

@@ -54,7 +54,7 @@ export class BfetchExplorerPlugin implements Plugin {
           // Validate inputs.
           if (num < 0) throw new Error('Invalid number');
           // Wait number of specified milliseconds.
-          await new Promise(r => setTimeout(r, num));
+          await new Promise((r) => setTimeout(r, num));
           // Double the number and send it back.
           return { num: 2 * num };
         },

examples/demo_search/server/async_demo_search_strategy.ts

@@ -40,7 +40,7 @@ const totalMap = new Map<string, number>();
 
 export const asyncDemoSearchStrategyProvider: TSearchStrategyProvider<typeof ASYNC_DEMO_SEARCH_STRATEGY> = () => {
   return {
-    search: async request => {
+    search: async (request) => {
       const id = request.id ?? generateId();
 
       const loaded = (loadedMap.get(id) ?? 0) + 1;
@@ -52,7 +52,7 @@ export const asyncDemoSearchStrategyProvider: TSearchStrategyProvider<typeof ASY
       const fibonacciSequence = getFibonacciSequence(loaded);
       return { id, total, loaded, fibonacciSequence };
     },
-    cancel: async id => {
+    cancel: async (id) => {
       loadedMap.delete(id);
       totalMap.delete(id);
     },

examples/demo_search/server/demo_search_strategy.ts

@@ -22,7 +22,7 @@ import { DEMO_SEARCH_STRATEGY } from '../common';
 
 export const demoSearchStrategyProvider: TSearchStrategyProvider<typeof DEMO_SEARCH_STRATEGY> = () => {
   return {
-    search: request => {
+    search: (request) => {
       return Promise.resolve({
         greeting:
           request.mood === 'happy'

examples/embeddable_examples/public/list_container/list_container_component.tsx

@@ -40,7 +40,7 @@ function renderList(
   embeddableServices: EmbeddableStart
 ) {
   let number = 0;
-  const list = Object.values(panels).map(panel => {
+  const list = Object.values(panels).map((panel) => {
     const child = embeddable.getChild(panel.explicitInput.id);
     number++;
     return (

examples/embeddable_examples/public/multi_task_todo/multi_task_todo_component.tsx

@@ -55,7 +55,7 @@ function wrapSearchTerms(task: string, search?: string) {
 }
 
 function renderTasks(tasks: MultiTaskTodoInput['tasks'], search?: string) {
-  return tasks.map(task => (
+  return tasks.map((task) => (
     <EuiListGroupItem
       key={task}
       data-test-subj="multiTaskTodoTask"

examples/embeddable_examples/public/multi_task_todo/multi_task_todo_embeddable.tsx

@@ -48,7 +48,7 @@ function getHasMatch(tasks: string[], title?: string, search?: string) {
 
   if (title && title.match(search)) return true;
 
-  const match = tasks.find(task => task.match(search));
+  const match = tasks.find((task) => task.match(search));
   if (match) return true;
 
   return false;

examples/embeddable_examples/public/searchable_list_container/searchable_list_container_component.tsx

@@ -65,26 +65,26 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
 
     const checked: { [id: string]: boolean } = {};
     const hasMatch: { [id: string]: boolean } = {};
-    props.embeddable.getChildIds().forEach(id => {
+    props.embeddable.getChildIds().forEach((id) => {
       checked[id] = false;
       const output = props.embeddable.getChild(id).getOutput();
       hasMatch[id] = hasHasMatchOutput(output) && output.hasMatch;
     });
-    props.embeddable.getChildIds().forEach(id => (checked[id] = false));
+    props.embeddable.getChildIds().forEach((id) => (checked[id] = false));
     this.state = {
       checked,
       hasMatch,
     };
   }
 
   componentDidMount() {
-    this.props.embeddable.getChildIds().forEach(id => {
+    this.props.embeddable.getChildIds().forEach((id) => {
       this.subscriptions[id] = this.props.embeddable
         .getChild(id)
         .getOutput$()
-        .subscribe(output => {
+        .subscribe((output) => {
           if (hasHasMatchOutput(output)) {
-            this.setState(prevState => ({
+            this.setState((prevState) => ({
               hasMatch: {
                 ...prevState.hasMatch,
                 [id]: output.hasMatch,
@@ -96,15 +96,15 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
   }
 
   componentWillUnmount() {
-    Object.values(this.subscriptions).forEach(sub => sub.unsubscribe());
+    Object.values(this.subscriptions).forEach((sub) => sub.unsubscribe());
   }
 
   private updateSearch = (search: string) => {
     this.props.embeddable.updateInput({ search });
   };
 
   private deleteChecked = () => {
-    Object.values(this.props.input.panels).map(panel => {
+    Object.values(this.props.input.panels).map((panel) => {
       if (this.state.checked[panel.explicitInput.id]) {
         this.props.embeddable.removeEmbeddable(panel.explicitInput.id);
         this.subscriptions[panel.explicitInput.id].unsubscribe();
@@ -115,7 +115,7 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
   private checkMatching = () => {
     const { input, embeddable } = this.props;
     const checked: { [key: string]: boolean } = {};
-    Object.values(input.panels).map(panel => {
+    Object.values(input.panels).map((panel) => {
       const child = embeddable.getChild(panel.explicitInput.id);
       const output = child.getOutput();
       if (hasHasMatchOutput(output) && output.hasMatch) {
@@ -126,7 +126,7 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
   };
 
   private toggleCheck = (isChecked: boolean, id: string) => {
-    this.setState(prevState => ({ checked: { ...prevState.checked, [id]: isChecked } }));
+    this.setState((prevState) => ({ checked: { ...prevState.checked, [id]: isChecked } }));
   };
 
   public renderControls() {
@@ -156,7 +156,7 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
             <EuiFieldText
               data-test-subj="filterTodos"
               value={this.props.input.search || ''}
-              onChange={ev => this.updateSearch(ev.target.value)}
+              onChange={(ev) => this.updateSearch(ev.target.value)}
             />
           </EuiFormRow>
         </EuiFlexItem>
@@ -183,7 +183,7 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
   private renderList() {
     const { embeddableServices, input, embeddable } = this.props;
     let id = 0;
-    const list = Object.values(input.panels).map(panel => {
+    const list = Object.values(input.panels).map((panel) => {
       const childEmbeddable = embeddable.getChild(panel.explicitInput.id);
       id++;
       return childEmbeddable ? (
@@ -195,7 +195,7 @@ export class SearchableListContainerComponentInner extends Component<Props, Stat
                 disabled={!childEmbeddable}
                 id={childEmbeddable ? childEmbeddable.id : ''}
                 checked={this.state.checked[childEmbeddable.id]}
-                onChange={e => this.toggleCheck(e.target.checked, childEmbeddable.id)}
+                onChange={(e) => this.toggleCheck(e.target.checked, childEmbeddable.id)}
               />
             </EuiFlexItem>
             <EuiFlexItem>

examples/embeddable_examples/public/todo/todo_embeddable_factory.tsx

@@ -34,7 +34,7 @@ function TaskInput({ onSave }: { onSave: (task: string) => void }) {
         data-test-subj="taskInputField"
         value={task}
         placeholder="Enter task here"
-        onChange={e => setTask(e.target.value)}
+        onChange={(e) => setTask(e.target.value)}
       />
       <EuiButton data-test-subj="createTodoEmbeddable" onClick={() => onSave(task)}>
         Save
@@ -69,7 +69,7 @@ export class TodoEmbeddableFactory
    */
   public getExplicitInput = async () => {
     const { openModal } = await this.getStartServices();
-    return new Promise<{ task: string }>(resolve => {
+    return new Promise<{ task: string }>((resolve) => {
       const onSave = (task: string) => resolve({ task });
       const overlay = openModal(
         toMountPoint(

examples/embeddable_explorer/public/app.tsx

@@ -51,7 +51,7 @@ type NavProps = RouteComponentProps & {
 };
 
 const Nav = withRouter(({ history, navigateToApp, pages }: NavProps) => {
-  const navItems = pages.map(page => ({
+  const navItems = pages.map((page) => ({
     id: page.id,
     name: page.title,
     onClick: () => history.push(`/${page.id}`),
@@ -122,7 +122,7 @@ const EmbeddableExplorerApp = ({
   ];
 
   const routes = pages.map((page, i) => (
-    <Route key={i} path={`/${page.id}`} render={props => page.component} />
+    <Route key={i} path={`/${page.id}`} render={(props) => page.component} />
   ));
 
   return (

examples/embeddable_explorer/public/embeddable_panel_example.tsx

@@ -84,7 +84,7 @@ export function EmbeddablePanelExample({ embeddableServices }: Props) {
       const factory = embeddableServices.getEmbeddableFactory(SEARCHABLE_LIST_CONTAINER);
       const promise = factory?.create(searchableInput);
       if (promise) {
-        promise.then(e => {
+        promise.then((e) => {
           if (ref.current) {
             setEmbeddable(e);
           }