Skip to content

Commit

Permalink
[7.x] [Design] A couple fixes for 7.10 (#78801) (#79016)
Browse files Browse the repository at this point in the history
* [Design] A couple fixes for 7.10 (#78801)

* A few header and KQL bar fixes

* More fixes (alerts, modals)

* Fixing bottom padding for advanced settings bottom bar

* One more alerts responsive fix
  • Loading branch information
cchaos authored Sep 30, 2020
1 parent 2dc34ac commit 6f953c0
Show file tree
Hide file tree
Showing 12 changed files with 223 additions and 110 deletions.
280 changes: 186 additions & 94 deletions src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions src/core/public/chrome/ui/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ import {
EuiHeaderSection,
EuiHeaderSectionItem,
EuiHeaderSectionItemButton,
EuiHideFor,
EuiIcon,
EuiShowFor,
htmlIdGenerator,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
Expand Down Expand Up @@ -117,12 +119,19 @@ export function Header({
},
{
...(observables.navControlsCenter$ && {
items: [<HeaderNavControls navControls$={observables.navControlsCenter$} />],
items: [
<EuiShowFor sizes={['m', 'l', 'xl']}>
<HeaderNavControls navControls$={observables.navControlsCenter$} />
</EuiShowFor>,
],
}),
borders: 'none',
},
{
items: [
<EuiHideFor sizes={['m', 'l', 'xl']}>
<HeaderNavControls navControls$={observables.navControlsCenter$} />
</EuiHideFor>,
<HeaderHelpMenu
helpExtension$={observables.helpExtension$}
helpSupportUrl$={observables.helpSupportUrl$}
Expand Down Expand Up @@ -154,8 +163,6 @@ export function Header({
</EuiHeaderSectionItemButton>
</EuiHeaderSectionItem>

<EuiHeaderSectionItem border="right" />

<HeaderNavControls side="left" navControls$={observables.navControlsLeft$} />
</EuiHeaderSection>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,7 @@
.mgtAdvancedSettingsForm__button {
width: 100%;
}

.kbnBody--mgtAdvancedSettingsHasBottomBar .mgtPage__body {
padding-bottom: $euiSizeXL * 2;
}
Loading

0 comments on commit 6f953c0

Please sign in to comment.