[ci] Run linting before tests

elastic · Oct 22, 2024 · 6d52cb8 · 6d52cb8
1 parent f629d96
commit 6d52cb8
Show file tree

Hide file tree

Showing 30 changed files with 93 additions and 30 deletions.
diff --git a/.buildkite/pipelines/on_merge.yml b/.buildkite/pipelines/on_merge.yml
@@ -46,6 +46,21 @@ steps:
         - exit_status: '-1'
           limit: 3
 
+  - command: .buildkite/scripts/steps/lint.sh
+    label: 'Linting'
+    agents:
+      image: family/kibana-ubuntu-2004
+      imageProject: elastic-images-prod
+      provider: gcp
+      machineType: n2-standard-16
+      preemptible: true
+    key: linting
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
   - wait
 
   - command: .buildkite/scripts/steps/on_merge_api_docs.sh
@@ -109,6 +124,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 3
     retry:
@@ -127,6 +143,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 2
     retry:
@@ -145,6 +162,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 8
     retry:
@@ -163,6 +181,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 5
     retry:
@@ -181,6 +200,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 1
     retry:
@@ -199,6 +219,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 4
     retry:
@@ -217,6 +238,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 6
     retry:
@@ -235,6 +257,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 5
     retry:
@@ -253,6 +276,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 6
     retry:
@@ -271,6 +295,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 5
     retry:
@@ -289,6 +314,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 6
     retry:
@@ -307,6 +333,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 1
     retry:
@@ -325,6 +352,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 1
     retry:
@@ -343,6 +371,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 2
     retry:
@@ -361,6 +390,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 2
     retry:
@@ -379,6 +409,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 6
     retry:
@@ -397,6 +428,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 8
     retry:
@@ -415,6 +447,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 8
     retry:
@@ -435,6 +468,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 20
     retry:
@@ -455,6 +489,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 14
     retry:
@@ -468,27 +503,13 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     agents:
       image: family/kibana-ubuntu-2004
       imageProject: elastic-images-prod
       provider: gcp
       machineType: n2-standard-2
 
-  - command: .buildkite/scripts/steps/lint.sh
-    label: 'Linting'
-    agents:
-      image: family/kibana-ubuntu-2004
-      imageProject: elastic-images-prod
-      provider: gcp
-      machineType: n2-standard-8
-      preemptible: true
-    key: linting
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
   - command: .buildkite/scripts/steps/lint_with_types.sh
     label: 'Linting (with types)'
     agents:

diff --git a/.buildkite/pipelines/pull_request/apm_cypress.yml b/.buildkite/pipelines/pull_request/apm_cypress.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 120
     parallelism: 1 # TODO: Set parallelism when apm_cypress handles it
     retry:

diff --git a/.buildkite/pipelines/pull_request/base.yml b/.buildkite/pipelines/pull_request/base.yml
@@ -32,6 +32,18 @@ steps:
         - exit_status: '-1'
           limit: 3
 
+  - command: .buildkite/scripts/steps/lint.sh
+    label: 'Linting'
+    agents:
+      machineType: n2-standard-16
+      preemptible: true
+    key: linting
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
+
   - wait
 
   - command: .buildkite/scripts/steps/ci_stats_ready.sh
@@ -61,18 +73,6 @@ steps:
         - exit_status: '*'
           limit: 1
 
-  - command: .buildkite/scripts/steps/lint.sh
-    label: 'Linting'
-    agents:
-      machineType: n2-standard-8
-      preemptible: true
-    key: linting
-    timeout_in_minutes: 60
-    retry:
-      automatic:
-        - exit_status: '-1'
-          limit: 3
-
   - command: .buildkite/scripts/steps/check_types.sh
     label: 'Check Types'
     agents:

diff --git a/.buildkite/pipelines/pull_request/deploy_cloud.yml b/.buildkite/pipelines/pull_request/deploy_cloud.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 30
     soft_fail: true
     retry:

diff --git a/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml b/.buildkite/pipelines/pull_request/exploratory_view_plugin.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     artifact_paths:
       - 'x-pack/plugins/observability_solution/exploratory_view/e2e/.journeys/**/*'

diff --git a/.buildkite/pipelines/pull_request/fips.yml b/.buildkite/pipelines/pull_request/fips.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     soft_fail: true
     retry:

diff --git a/.buildkite/pipelines/pull_request/fleet_cypress.yml b/.buildkite/pipelines/pull_request/fleet_cypress.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 50
     parallelism: 6
     retry:

diff --git a/.buildkite/pipelines/pull_request/inventory_cypress.yml b/.buildkite/pipelines/pull_request/inventory_cypress.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 120
     parallelism: 1
     retry:

diff --git a/.buildkite/pipelines/pull_request/kbn_handlebars.yml b/.buildkite/pipelines/pull_request/kbn_handlebars.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 5
     retry:
       automatic:

diff --git a/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml b/.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 120
     retry:
       automatic:

diff --git a/.buildkite/pipelines/pull_request/profiling_cypress.yml b/.buildkite/pipelines/pull_request/profiling_cypress.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 120
     parallelism: 2
     retry:

diff --git a/.buildkite/pipelines/pull_request/response_ops.yml b/.buildkite/pipelines/pull_request/response_ops.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 120
     parallelism: 9
     retry:

diff --git a/.buildkite/pipelines/pull_request/response_ops_cases.yml b/.buildkite/pipelines/pull_request/response_ops_cases.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 120
     retry:
       automatic:

diff --git a/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml b/.buildkite/pipelines/pull_request/security_solution/ai_assistant.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 1
     retry:
@@ -22,6 +23,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 1
     retry:

diff --git a/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml b/.buildkite/pipelines/pull_request/security_solution/cloud_security_posture.yml
@@ -7,6 +7,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 1
     retry:
@@ -22,6 +23,7 @@ steps:
     depends_on:
       - build
       - quick_checks
+      - linting
     timeout_in_minutes: 60
     parallelism: 1
     retry: