fix alias comparator (#61764)

* fix alias comparator * added test
elastic · Mar 30, 2020 · 67bfaf8 · 67bfaf8
1 parent 5605b46
commit 67bfaf8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/plugins/data/common/query/filter_manager/compare_filters.test.ts b/src/plugins/data/common/query/filter_manager/compare_filters.test.ts
@@ -197,6 +197,22 @@ describe('filter manager utilities', () => {
       expect(compareFilters([f1], [f2], COMPARE_ALL_OPTIONS)).toBeTruthy();
     });
 
+    test('should compare alias with alias true', () => {
+      const f1 = {
+        $state: { store: FilterStateStore.GLOBAL_STATE },
+        ...buildQueryFilter({ _type: { match: { query: 'apache', type: 'phrase' } } }, 'index', ''),
+      };
+      const f2 = {
+        $state: { store: FilterStateStore.GLOBAL_STATE },
+        ...buildQueryFilter({ _type: { match: { query: 'apache', type: 'phrase' } } }, 'index', ''),
+      };
+
+      f2.meta.alias = 'wassup';
+      f2.meta.alias = 'dog';
+
+      expect(compareFilters([f1], [f2], { alias: true })).toBeFalsy();
+    });
+
     test('should compare alias with COMPARE_ALL_OPTIONS', () => {
       const f1 = {
         $state: { store: FilterStateStore.GLOBAL_STATE },

diff --git a/src/plugins/data/common/query/filter_manager/compare_filters.ts b/src/plugins/data/common/query/filter_manager/compare_filters.ts
@@ -46,7 +46,7 @@ const mapFilter = (
 
   if (comparators.negate) cleaned.negate = filter.meta && Boolean(filter.meta.negate);
   if (comparators.disabled) cleaned.disabled = filter.meta && Boolean(filter.meta.disabled);
-  if (comparators.disabled) cleaned.alias = filter.meta?.alias;
+  if (comparators.alias) cleaned.alias = filter.meta?.alias;
 
   return cleaned;
 };