[ML] fix job and datafeed states check, add comments

elastic · Jul 22, 2021 · 65dbb89 · 65dbb89
1 parent a6e0f92
commit 65dbb89
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/x-pack/plugins/ml/server/lib/alerts/jobs_health_service.ts b/x-pack/plugins/ml/server/lib/alerts/jobs_health_service.ts
@@ -75,7 +75,7 @@ export function jobsHealthServiceProvider(
 
   return {
     /**
-     * Gets not started datafeeds and not opened jobs for provided jobs selection.
+     * Gets not started datafeeds for opened jobs.
      * @param jobIds
      */
     async getNotStartedDatafeeds(jobIds: string[]): Promise<NotStartedDatafeedResponse | void> {
@@ -104,10 +104,10 @@ export function jobsHealthServiceProvider(
               job_state: jobState,
             };
           })
-          .filter(
-            (datafeedStat) =>
-              datafeedStat.state !== 'started' || datafeedStat.job_state !== 'opened'
-          );
+          .filter((datafeedStat) => {
+            // Find opened jobs with not started datafeeds
+            return datafeedStat.job_state === 'opened' && datafeedStat.state !== 'started';
+          });
       }
     },
     /**