Update error messages

elastic · Jun 17, 2021 · 64bb5fe · 64bb5fe
1 parent bb35aa6
commit 64bb5fe
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/plugins/expressions/common/expression_functions/specs/math_column.ts b/src/plugins/expressions/common/expression_functions/specs/math_column.ts
@@ -69,7 +69,11 @@ export const mathColumn: ExpressionFunctionDefinition<
       return id === args.id;
     });
     if (existingColumnIndex > -1) {
-      throw new Error('ID must be unique');
+      throw new Error(
+        i18n.translate('expressions.functions.mathColumn.uniqueIdError', {
+          defaultMessage: 'ID must be unique',
+        })
+      );
     }
 
     const newRows = input.rows.map((row) => {
@@ -90,7 +94,12 @@ export const mathColumn: ExpressionFunctionDefinition<
         if (result.length === 1) {
           return { ...row, [args.id]: result[0] };
         }
-        throw new Error(`Cannot perform math on array values at ${args.name}`);
+        throw new Error(
+          i18n.translate('expressions.functions.mathColumn.arrayValueError', {
+            defaultMessage: 'Cannot perform math on array values at {name}',
+            values: { name: args.name },
+          })
+        );
       }
 
       return { ...row, [args.id]: result };

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/math.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/math.tsx
@@ -48,7 +48,7 @@ export const mathOperation: OperationDefinition<MathIndexPatternColumn, 'managed
         function: 'mathColumn',
         arguments: {
           id: [columnId],
-          name: [columnId],
+          name: [column.label],
           expression: [astToString(column.params.tinymathAst)],
           onError: ['null'],
         },